public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ryan Hill <dirtyepic@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: FEATURES=test, sys-devel/gcc ignored test failures
Date: Mon, 21 Mar 2011 16:02:30 -0600	[thread overview]
Message-ID: <20110321160230.160f8f5e@gentoo.org> (raw)
In-Reply-To: 4D873F85.5070203@gentoo.org

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

On Mon, 21 Mar 2011 13:07:33 +0100
"Paweł Hajdan, Jr." <phajdan.jr@gentoo.org> wrote:

> sys-devel/gcc runs tests, but the results are ignored and I remember the
> tests fail most of the time.

s/most/all
 
> Because the tests take long time to run and fail anyway (I understand
> it's non-trivial to fix those on Gentoo side), I wonder whether it makes
> sense to run them at all:

It does to me, I use them all the time. ;)  The important part is that we
install the test results, which can then be used for regression testing when
rolling patchsets.

> toolchain.eclass:
> 
> gcc_src_test() {
>     cd "${WORKDIR}"/build
>     emake -j1 -k check || ewarn "check failed and that sucks :("
> }
> 
> My suggestion is to make the src_test empty (I think the default one
> still calls make). I can produce a patch if needed.
> 
> What do you think?

I think that glibc and gcc tests and other testsuites that nearly always
fail shouldn't be run for the average user but should still be easily
accessible in a standard way.  I think we need a more finely grained test
setup, where we can say tests are "expensive" or "interesting only to
developers" or "known to fail", and let people opt-in to these on a
per-package basis. Right now you always have to opt-out using
package.use.mask which "works" but is unintuitive.


-- 
fonts, gcc-porting,                  it makes no sense how it makes no sense
toolchain, wxwidgets                           but i'll take it free anytime
@ gentoo.org                EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2011-03-21 21:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21 12:07 [gentoo-dev] FEATURES=test, sys-devel/gcc ignored test failures "Paweł Hajdan, Jr."
2011-03-21 12:29 ` Amadeusz Żołnowski
2011-03-21 22:02 ` Ryan Hill [this message]
2011-03-22 12:09   ` [gentoo-dev] " "Paweł Hajdan, Jr."
2011-03-22 15:01     ` Matt Turner
2011-03-22 23:25     ` Ryan Hill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110321160230.160f8f5e@gentoo.org \
    --to=dirtyepic@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox