From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: phajdan.jr@gentoo.org
Subject: Re: [gentoo-dev] virtualx eclass possible issue
Date: Sun, 13 Mar 2011 08:49:09 +0100 [thread overview]
Message-ID: <20110313084909.0c23b7ed@pomiocik.lan> (raw)
In-Reply-To: <4D7B4CE8.6030808@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
On Sat, 12 Mar 2011 11:37:28 +0100
"Paweł Hajdan, Jr." <phajdan.jr@gentoo.org> wrote:
> Shouldn't that last line look more like this (notice $retval instead
> of $?):
>
> [[ $retval -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND}
> failed."
>
> What do you think?
I'd say even '${VIRTUALX_COMMAND}'.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-03-13 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 10:37 [gentoo-dev] virtualx eclass possible issue "Paweł Hajdan, Jr."
2011-03-13 5:26 ` [gentoo-dev] " Ryan Hill
2011-03-13 7:49 ` Michał Górny [this message]
2011-03-13 8:25 ` [gentoo-dev] " Tomáš Chvátal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110313084909.0c23b7ed@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=phajdan.jr@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox