From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1P69st-0005h5-5N for garchives@archives.gentoo.org; Wed, 13 Oct 2010 22:33:19 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A0F2BE099C; Wed, 13 Oct 2010 22:33:17 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 0C9F5E0991 for ; Wed, 13 Oct 2010 22:33:01 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 966DE1B4040 for ; Wed, 13 Oct 2010 22:33:00 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild Date: Wed, 13 Oct 2010 18:32:40 -0400 User-Agent: KMail/1.13.5 (Linux/2.6.35.4; KDE/4.5.2; x86_64; ; ) References: <20100927113752.CF4CE20051@flycatcher.gentoo.org> <201010131746.44700.vapier@gentoo.org> <1287006762-sup-7540@etiriah> In-Reply-To: <1287006762-sup-7540@etiriah> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2930096.1PTDDub6Uh"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201010131832.41125.vapier@gentoo.org> X-Archives-Salt: a6a1ad7a-a89c-4b2a-b1c4-6c80d6a52d55 X-Archives-Hash: 8539b7efb76df16443823e47fbf622b5 --nextPart2930096.1PTDDub6Uh Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday, October 13, 2010 18:13:18 Amadeusz =C5=BBo=C5=82nowski wrote: > Excerpts from Mike Frysinger's message of Wed Oct 13 23:46:43 +0200 2010: > > On Wednesday, October 13, 2010 15:57:17 Amadeusz =C5=BBo=C5=82nowski wr= ote: > > > And why putting different tasks into one function? > >=20 > > for the same reason we dont have separate test binaries: test_exist, > > test_file, test_dir, etc... > >=20 > > it makes more sense in my mind to combine the functionality. >=20 > So the only argument for having more complicated, less intuitive and > less readable function is the old 'test' program? Please, reconsider my > solution with more reason. we prioritize differently. i prefer unified code with options. you prefer= red=20 unrolled duplicated code. > Moreover we're using 'test' as '[[ =E2=80=A6 ]]' which changes much in re= adability. what are you talking about ? no one is using `test` in their code and if t= hey=20 are, their code is broken. none of the stuff ive posted is running `test`. =2Dmike --nextPart2930096.1PTDDub6Uh Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJMtjOJAAoJEEFjO5/oN/WBjU0P/1M2zSdhrAO208ByG9w9iodw oRngw3pDiUb4VYUGyqhuJac9tP+nCKiqnQvicC+bSMMjoFXwf5YtGKTxad2iNvLt gSB4u1nFm5je7oyK4Jek0mc0i+IPRYqGkYAIXtU0/O26e03/NVSVJQabs6WMsoz9 7vbQzsBcGl1q9WFYdFYihx6uJPXqbJy7TLlZbV2XRINru4eTUSk3WPw8FbI4x+Xd hFaQYOIiVRL9RFvVxhr1BlIzHZgijbPBBB7wj9NhwUOXwsfFRiGmJBGANNT00Q9K nicmDHgkZIqPBcmzIUoTW3GroALVAF8PYSB0ubVTcqFXzpbJL3urxbgTCYjbuBTf pRhF5gyEO/bHXnPCGRiIKkhhtTRwJcknuU7NmITkHM840dJw8h3d/cWYNEz1miUn 6zCO3OqwhiO0ZvVNU4VeM6CPch5aE7NZmJvPKwHq6FVCP+wfJv2B9BpuFir8sUr8 d3VJIMTtCGA1WvZbdrYCt6Byd52PSTx2+kvEoAZRwB0UPqxljgj5QQxFT4Uvp84Q ByBNZogm3kh6jL7Zkl9KnG6iZsSypvXHx8HeLPAhZAKu8ixuTUTUzIOnc8lTK6SW FWBhFAn6A/2XVBCscdKNL9fP7Kqy0js3zOgRBAOIotlAfTUd3qxzslB4p+OoY97I EglIY2BxnEUgtniDxZr/ =KgaM -----END PGP SIGNATURE----- --nextPart2930096.1PTDDub6Uh--