From: Jeroen Roovers <jer@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild
Date: Tue, 12 Oct 2010 22:26:31 +0200 [thread overview]
Message-ID: <20101012222631.2d04b907@epia.jer-c2.orkz.net> (raw)
In-Reply-To: <AANLkTik=kMxt60oJ_9e7eYYEq-cN2XJy7dZqRD00PwU1@mail.gmail.com>
On Tue, 12 Oct 2010 22:09:06 +0200
Dirkjan Ochtman <djc@gentoo.org> wrote:
> On Fri, Oct 1, 2010 at 15:07, Peter Volkov <pva@gentoo.org> wrote:
> > [a very thorough review of the openvpn ebuild]
>
> Thanks for reviewing, I've fixed most of the issues.
>
> >> if [[ -n $(ls /etc/openvpn/*/local.conf 2>/dev/null) ]] ;
> >> then
> >
> > I'd suggested [ -e /etc/openvpn/*/local.conf ] here, but probably
> > there are better alternatives. Also ${ROOT} is missed here.
>
> I've put ${ROOT} in, are there no better alternatives? I don't think
> anyone mentioned any.
for foo in ${ROOT}/etc/openvpn/*/local.conf; do
[ -e ${foo} ] && bar ${foo}
done
If no ${ROOT}/etc/openvpn/*/local.conf is found, it returns the exact
string; which doesn't exist so Nothing Happens.
jer
next prev parent reply other threads:[~2010-10-12 20:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100927113752.CF4CE20051@flycatcher.gentoo.org>
2010-10-01 13:07 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild Peter Volkov
2010-10-01 13:34 ` Thomas Sachau
2010-10-01 15:17 ` Nirbheek Chauhan
2010-10-02 3:38 ` Ryan Hill
2010-10-02 12:32 ` Nirbheek Chauhan
2010-10-05 4:20 ` Jeroen Roovers
2010-10-12 20:09 ` Dirkjan Ochtman
2010-10-12 20:17 ` Mike Frysinger
2010-10-12 20:26 ` Jeroen Roovers [this message]
2010-10-12 20:57 ` Mike Frysinger
2010-10-13 8:23 ` Amadeusz Żołnowski
2010-10-13 14:13 ` Mike Frysinger
2010-10-13 16:36 ` Amadeusz Żołnowski
2010-10-13 16:41 ` Michał Górny
2010-10-13 16:51 ` Amadeusz Żołnowski
2010-10-13 17:26 ` Michał Górny
2010-10-13 18:04 ` Mike Frysinger
2010-10-13 18:51 ` Mike Frysinger
2010-10-13 19:20 ` Amadeusz Żołnowski
2010-10-13 19:57 ` Amadeusz Żołnowski
2010-10-13 21:46 ` Mike Frysinger
2010-10-13 22:13 ` Amadeusz Żołnowski
2010-10-13 22:32 ` Mike Frysinger
2010-10-13 23:08 ` Amadeusz Żołnowski
2010-10-17 21:33 ` Mike Frysinger
2010-10-17 23:06 ` Amadeusz Żołnowski
2010-10-18 7:08 ` Michał Górny
2010-10-18 18:06 ` Mike Frysinger
2010-10-18 18:25 ` Mike Frysinger
2010-10-19 4:03 ` Michał Górny
2010-10-13 19:37 ` Ulrich Mueller
2010-10-13 21:45 ` Mike Frysinger
2010-10-17 21:35 ` Mike Frysinger
[not found] <fyNx7-2Qx-7@gated-at.bofh.it>
[not found] ` <fCTuh-8on-5@gated-at.bofh.it>
[not found] ` <fCTDX-aL-5@gated-at.bofh.it>
[not found] ` <fCUgF-1kl-15@gated-at.bofh.it>
2010-10-13 7:08 ` Vaeth
2010-10-13 14:15 ` Mike Frysinger
[not found] <fD3Dj-k9-9@gated-at.bofh.it>
[not found] ` <fD3Dj-k9-15@gated-at.bofh.it>
[not found] ` <fD3Dj-k9-7@gated-at.bofh.it>
[not found] ` <fDbhw-4Y2-5@gated-at.bofh.it>
2010-10-13 16:35 ` Vaeth
2010-10-13 18:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012222631.2d04b907@epia.jer-c2.orkz.net \
--to=jer@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox