From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OxWrJ-0006Jo-Fg for garchives@archives.gentoo.org; Mon, 20 Sep 2010 03:16:02 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E6C4DE0AF0 for ; Mon, 20 Sep 2010 03:15:57 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 6DDF6E09F7 for ; Mon, 20 Sep 2010 02:52:19 +0000 (UTC) Received: from afta-gentoo.localnet (ip-85-198-235-97.broker.com.pl [85.198.235.97]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPSA id 7F2461B41AC; Mon, 20 Sep 2010 02:52:18 +0000 (UTC) From: Arfrever Frehtes Taifersar Arahesis To: Gentoo Development Subject: Re: [gentoo-dev] Re: Patch for python.eclass Date: Mon, 20 Sep 2010 04:53:31 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.34-tuxonice-r1-AFTA; KDE/4.4.5; x86_64; ; ) Cc: qa@gentoo.org References: <201009200320.07877.Arfrever@gentoo.org> <201009192145.14827.vapier@gentoo.org> In-Reply-To: <201009192145.14827.vapier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4890348.on353e40j0"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201009200453.32815.Arfrever@gentoo.org> X-Archives-Salt: 4741e0bf-cdaf-49bb-afef-a1dc884ca3a2 X-Archives-Hash: ee7a2b279ee9c874d9699fa33d1434ab --nextPart4890348.on353e40j0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable 2010-09-20 03:45:14 Mike Frysinger napisa=C5=82(a): > On Sunday, September 19, 2010 21:18:51 Arfrever Frehtes Taifersar Arahesi= s=20 > wrote: > > -evaluated_PYTHONPATH=3D"$(eval echo -n "${PYTHONPATH_template}")" > > +eval "evaluated_PYTHONPATH=3D\"${PYTHONPATH_template}\"" >=20 > the quotes in the 2nd one are useless. this should work the same: > eval evaluated_PYTHONPATH=3D\"${PYTHONPATH_template}\" The quotes are required: $ PYTHONPATH_template=3D"/usr/share/a b" $ eval "evaluated_PYTHONPATH=3D\"${PYTHONPATH_template}\"" $ echo "${evaluated_PYTHONPATH}" /usr/share/a b $ eval evaluated_PYTHONPATH=3D\"${PYTHONPATH_template}\" $ echo "${evaluated_PYTHONPATH}" /usr/share/a b > while you're in the process of cleaning things up, i know we dont have a = rule=20 > anywhere in terms of line length, but python.eclass has always struck me = as a=20 > file with incredibly excessive line length. comparing to other eclasses,= it=20 > has multiple lines in it longer than any single line in any other eclass. >=20 > i normally develop in a terminal with 170 cols (which i think is larger t= han=20 > average), so i'm pretty lenient, but even python.eclass exceeds that mult= iple=20 > times if not running close to it. python.eclass has many nested checks, loops etc. =2D-=20 Arfrever Frehtes Taifersar Arahesis --nextPart4890348.on353e40j0 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJMlsysAAoJEFU3/w1zlLfg/18QAKzwx88XgGfD3t++zm0yI6lr 0MR75CR+IUcSnFvBkXNlB2YJlXKYU18k+JQ5EeDE8U6+R+jMaGGpbQqhQgB+pGzJ Mtxihdh7/sRdhrLYJPOmNQ1Mh215OTOMS8PIKqPHLI9MRN+V+j+OttSDJ6eL8dX1 TAkNC8HO+ePuUd3fA21UyUraUQaa4SSjebJUD6ggi245giggibISpJCq2nhZ7Z8M JQAupvMR5nfZCQyGduHiCFPwyeAIsFqmCYcvfCrK71Oo+++iNhOgekQuZumb9KoX VcGUZ4IKr1Ipg1r3EMna0VsyCJ3zyNlhZs2v3CxYLbCQS6FBp7A3T2adHCWXG6Nu C6Rvpjn2OyC1IkbN+3hC0hY5mF3fZWVDMn8Oi9zE7yqqE72wq6fx2D8cRa2y/bHq rRqIVHc153Zq83laiNxYOSIV01gtoEU7+PoZjtCZ+WkTff2HGX1mrvtRu1DTVsU0 Fb4sVOmCqeJne+A+EDWOqvDdqJYPQluo8CcdhNWMrth7v3I2tDhRz0Di4kyWodce PEi+0/9Ce1WjOYpfROy03k5zGwyix4EbRUv5rubw8PZJAKUBDkfxI6lCoyXbm3nu uIcnvlHMhMTBdugfmaOfmYKghFAtXNcqK+bJZoQ46QaLcBkxxlWGckxot1kZLpav L/N5RKIBnk2qPetrldsk =aCPB -----END PGP SIGNATURE----- --nextPart4890348.on353e40j0--