From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OxWsC-0006Or-1P for garchives@archives.gentoo.org; Mon, 20 Sep 2010 03:16:56 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 99DE6E0AF4 for ; Mon, 20 Sep 2010 03:16:55 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id A3715E063C for ; Mon, 20 Sep 2010 03:01:02 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 6C2421B4126; Mon, 20 Sep 2010 03:01:01 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: Gentoo Development Subject: Re: [gentoo-dev] Re: Patch for python.eclass Date: Sun, 19 Sep 2010 23:00:21 -0400 User-Agent: KMail/1.13.1 (Linux/2.6.35.4; KDE/4.4.5; x86_64; ; ) Cc: qa@gentoo.org References: <201009200320.07877.Arfrever@gentoo.org> <201009192145.14827.vapier@gentoo.org> <201009200453.32815.Arfrever@gentoo.org> In-Reply-To: <201009200453.32815.Arfrever@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1600401.cXumLgYt9r"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201009192300.22064.vapier@gentoo.org> X-Archives-Salt: 97064c9d-011b-4ccb-8329-01fe828cf94e X-Archives-Hash: 9279596c9893b4bd1a416eecd4302149 --nextPart1600401.cXumLgYt9r Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday, September 19, 2010 22:53:31 Arfrever Frehtes Taifersar Arahesis= =20 wrote: > 2010-09-20 03:45:14 Mike Frysinger napisa=C5=82(a): > > while you're in the process of cleaning things up, i know we dont have a > > rule anywhere in terms of line length, but python.eclass has always > > struck me as a file with incredibly excessive line length. comparing to > > other eclasses, it has multiple lines in it longer than any single line > > in any other eclass. > >=20 > > i normally develop in a terminal with 170 cols (which i think is larger > > than average), so i'm pretty lenient, but even python.eclass exceeds > > that multiple times if not running close to it. >=20 > python.eclass has many nested checks, loops etc. so what ? actually look at the long lines. none of them need to be so lon= g: lines 33 & 802 & 2226 - a large number of local variables that could easily= be=20 line wrapped otherwise we get 344+ cols. good luck figuring out what vars = are=20 at the tail end of that. lines 274 & 290 - a lot of checks in a single if statement that too could=20 easily be line wrapped line 2354 - a really long ebegin message that is shown to users line 489 - a single sed statement that can easily be line wrapped lines 1158 & 1184 - a single inline python command that can easily be line= =20 wrapped =2Dmike --nextPart1600401.cXumLgYt9r Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJMls5GAAoJEEFjO5/oN/WBOuQQAI0Hd6y/U9P0w+l9seJijAMx ZsyiCymmDic8S2scNJojA981H4HoGD4apgesEfkG9S7J2nw2G9DO8GuapJcbUy+W AJJ6vdLrU1ejtNfx42gfmuelQ3iZbjls4mjpHzygvU4mHFKA1BZk43uTtCAqw9G7 hl3RjH036uWMN7PIjzI8P1KxqaQDHfuOWGqdtRR47Jkh2FZ5+eDEG11BSDInSQed XNDIaoQYGEFvCVrxRBUuOZmVHSZ5GvGD2SqL9VO2gXSzmr2RSuy4dSvFdatGzGBR fDZtqFf7m6JW3FcBN4DE4jNRydD5V7R0yQdfn1Lhmjl6WtclH7wsn7IbtGpJSQrh dLa1+YMY180d7QEbfH/VohYK5HJ/SJlGmV0iNl7dL5rBfDzFZR0fKldEnwAWxOH2 XqYxq0DNEhhYF/6M2U/pr2gGHN8QYtDjcMTH/ZAmK64mPVofjp1UUHsqrpGDUqMw AY70SO0C+z70S981Dl/yM1ywwOSjrAzef3vqR1M06QhTzc2qe6ByS4qQcq5vXiSq eNBwXVmeyw40H1OR+zHNGeeqtZFWVP4kdDgSVaKX7JccE7cFrUgNVZ7U+cdz4zBU UqyD4CJe9ZePvLT1uD1VbNx0vXunVNh9p+iBE1r2EzYJApBsbBZOMvUtjAwAULts zAbb+D7kwtoemLCZOGDT =DlrT -----END PGP SIGNATURE----- --nextPart1600401.cXumLgYt9r--