From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OwU6F-0008PF-Ts for garchives@archives.gentoo.org; Fri, 17 Sep 2010 06:07:08 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 85026E0A5D for ; Fri, 17 Sep 2010 06:07:07 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 954FCE09E1 for ; Fri, 17 Sep 2010 05:21:43 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 239401B4084 for ; Fri, 17 Sep 2010 05:21:43 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: fox.eclass update Date: Fri, 17 Sep 2010 01:24:27 -0400 User-Agent: KMail/1.13.1 (Linux/2.6.35.4; KDE/4.4.5; x86_64; ; ) References: <4C921C29.6010502@gentoo.org> <201009161834.18258.vapier@gentoo.org> <1284699979.19441.15.camel@tablet> In-Reply-To: <1284699979.19441.15.camel@tablet> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1837127.tnH9Xg1ZpE"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201009170124.28352.vapier@gentoo.org> X-Archives-Salt: 8eda956a-edb5-4b40-8e02-b8278df7b92c X-Archives-Hash: 4f589f54ad61cfcb0a92aa6de85e8420 --nextPart1837127.tnH9Xg1ZpE Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Friday, September 17, 2010 01:06:19 Peter Volkov wrote: > =D0=92 =D0=A7=D1=82=D0=B2, 16/09/2010 =D0=B2 18:34 -0400, Mike Frysinger = =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On Thursday, September 16, 2010 15:41:27 Peter Volkov wrote: > > > =D0=92 =D0=A7=D1=82=D0=B2, 16/09/2010 =D0=B2 15:29 -0400, Mike Frysin= ger =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > FOX_PV=3D"${FOX_PV:-${PV}}" > > > >=20 > > > > while you're here, i'd change to: > > > > : ${FOX_PV:=3D${PV}} > > >=20 > > > Why? This looks less readable... > >=20 > > only because your eyes arent tuned to it >=20 > Instead of explicit variable assignment (what was intended) you suggest > to call `:` command and implicitly assign variable with bash parameter > expansion... what exactly is your point ? there is no performance difference. my style= =20 suggestion however is significantly more compact and has no redundancy. =2Dmike --nextPart1837127.tnH9Xg1ZpE Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJMkvuMAAoJEEFjO5/oN/WBzKwQANa+JBkNs/tz03KvQiEThTNx vn9EYPIaqofDKf7AipWbSzPnzIPDJC5fkNA078xo0ONYFjTI9H2N7A8ip0RTEbr4 GpF0ixN618Bi3HgZxY0HkgUdt1rqfSFt1nKKft5ImfOInmERtkK784hfkFLVSG52 xqV2BermpIrqvdiFypZf9c7pUg3cFJAeQ983vKBsfkrPdQIzWW3yBm1e0E5ApRWR RrJ43FazGGgZR/q99XyF/YG+g97pGVfobHf5ODy7Ee42ekZiaH8R3XLaR05YpxdZ Bmn5gxSlP4LHQd6JpsSn1T0dDr5zLMQwN5WjqwItWsxr+XYJ+/DZDIiuj0iPcT4h Xmpzo28PkZcdz8tiJY1pV5E81pKbhSdnXv08AxrcGbrMewMAcazl1WH3rf5+Y1n3 m+59TC4mUy9qW4XlhNddBx3IF1SVic/YxfbRa8Uo3owl54s1550CoZ+khZZkr3Jm hWSAJMVwEocq2Gu5Q3U5cxl1DjP7z0t9Z1BaG184QeC2tPLNti0sDyYHmwiJFqHJ z98k9ZVvix32YTPqgdc/bCPinEgrMBqbugyM6Xfk4hcugsbD4PaRunHwWOJrl4Xn awXifvjfYhHoe0r/bGCYt9lae1d26+tWSUtvXdcA/g9Zj+u7Yao69XG2Tz+u+ZkP 9yUZc/K47Ec95E8o2EnH =bnBo -----END PGP SIGNATURE----- --nextPart1837127.tnH9Xg1ZpE--