From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OwKkM-00043n-Ls for garchives@archives.gentoo.org; Thu, 16 Sep 2010 20:07:55 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 85A0AE0698 for ; Thu, 16 Sep 2010 20:07:52 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id B2796E073E for ; Thu, 16 Sep 2010 19:27:33 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 0B6791B4230 for ; Thu, 16 Sep 2010 19:27:33 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: fox.eclass update Date: Thu, 16 Sep 2010 15:29:56 -0400 User-Agent: KMail/1.13.1 (Linux/2.6.35.4; KDE/4.4.5; x86_64; ; ) References: <4C921C29.6010502@gentoo.org> <1284661949.14378.289.camel@tablet> <4C92673B.7040702@gentoo.org> In-Reply-To: <4C92673B.7040702@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6948595.fY0UT14gth"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201009161530.12532.vapier@gentoo.org> X-Archives-Salt: 33a662dd-b35e-4843-bcad-1140b54f213c X-Archives-Hash: 12ee09b10ce789de32e404278349d0dc --nextPart6948595.fY0UT14gth Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thursday, September 16, 2010 14:51:39 Matti Bickel wrote: > +# 1.6: 'x11-libs/fox:1.6' > +# 1.7: '~x11-libs/fox-${PV}' first line is using a tab while second is spaces. both should be tabs. > FOX_PV=3D"${FOX_PV:-${PV}}" while you're here, i'd change to: : ${FOX_PV:=3D${PV}} > for d in ${FOX_APPS} ; do your prepare func should declare 'd' as local > + if use doc && [[ -z ${FOX_COMPONENT} ]] ; then > + cd "${S}/doc" > make docs || die "doxygen error" > fi should be `emake`, and better to use -C "${S}"/doc so that you dont change= =20 $PWD on people > + if ! use doc && [[ -d ${D}/usr/share/doc/${PF}/html ]] ; then > + rm -fr "${D}/usr/share/doc/${PF}/html" > fi you dont really need the -d check as the -f option to rm will keep it from= =20 warning on missing dirs use doc || rm -rf "${D}"/usr/share/doc/${PF}/html > + if [[ -f ${D}/usr/bin/fox-config ]] ; then > + mv "${D}/usr/bin/fox-config" "${D}/usr/bin/fox-${FOXVER}-config" > fi seems like you would want || die here =2Dmike --nextPart6948595.fY0UT14gth Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJMknBEAAoJEEFjO5/oN/WBDr4QAIpjtU3y/46K1DzmI3NYri93 v+msQWmmPs6XRRxQ0hNi+v/yboOStswZ16KnTlWvmjO/zbW5NU+UxYgbl8ntjhf0 ppig6GNcfnAPs2p8DLfwMayR3q0TDy1LPcv1ICK//f4ZUcueMwoRlCNL3Oy6fzKf L6Xxf5SsLre9JSil5VGeWhBqVrAGkeZ7fxU2YVGJU3CxKuHK3+/TXdFalq6+YoEi ME+eOrmD/TynntvafCOG0QBX9qqdsqMfTqKc5r4c+EvKxHcaUd8VhZjC3Up+dE+M MDD2ViWaJSrmWAhq+rh/L2HPMEbCX2sYZTOtem5/JAmybBf/1mMFYugofa9juDW8 rw+1mrmtbDcUyw8c+dzmmYVTPAdAPhUCC8W0Hpv/JRlTcvw+ZsOsQvmtu0Wt5TO6 eW2mzYog6HSDm6umCy59o1DnuAOXRqsP8SecM9/PUAolKCUEBpTQTmdxqaO2Wvzo QXPF3XBOpjPakukJgTiGEv2fPdjPAt29MTQINcDTIrPZWc6TbZMr0tkgLrEV/7eT paisp3M2tcAzlho/S2xUCE+8Mnwen4XVRxYcqb6h2vaccG1yV+5r5GnyAoV/lpI8 awVlx6O20bi7x/G3vrcRB+HdR45QOKztI6ljtAoYeCK54S2gmPxetR5fltWVVz01 8Zyxsms0mqREp1LTkKli =l2Yr -----END PGP SIGNATURE----- --nextPart6948595.fY0UT14gth--