From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OkJPA-0003Wt-Up for garchives@archives.gentoo.org; Sat, 14 Aug 2010 16:16:21 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 18803E07CB; Sat, 14 Aug 2010 16:16:17 +0000 (UTC) Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) by pigeon.gentoo.org (Postfix) with ESMTP id 5D52CE0809 for ; Sat, 14 Aug 2010 16:16:04 +0000 (UTC) Received: by wwb17 with SMTP id 17so1160134wwb.4 for ; Sat, 14 Aug 2010 09:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=nDXSUiHOw5QQPxIJJDxo/ssQLfSZQU22hIZ76jYWWWQ=; b=TLIheOL2GBu/hpnv02x9b/DqdFwe92GbE2MShGpYR4w9kMlN7IWfYbxzZuuMhO8N9S gdTN9XMIcxuRBgyNkoVcdQOc7fsstASO8ZDDxvAo07vILClwzDA2zDhN3aOshH/LqN4V dREpJElx7jWMr+Pnv3pVXejiOJjJJL21RgIHQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=UeDNtoytufUcdlS/iBSmon7l+EOPmelgFvp3CCytP0QQWkU83IjKLQ+g7byc2uDzkj yTJqD0GHIQVagcVu2REPJFe+rpKi4d8OQVsOfteoiAtqt8XIrAeKuzFzC+S+PArkNVjZ eOB7KSl2otUXd1BD3n4JH4NF4E+nY0KAnMZwQ= Received: by 10.227.146.135 with SMTP id h7mr2465532wbv.212.1281802563618; Sat, 14 Aug 2010 09:16:03 -0700 (PDT) Received: from linuxized.com (linuxized.net [109.74.194.171]) by mx.google.com with ESMTPS id w32sm2706090wbd.13.2010.08.14.09.16.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 14 Aug 2010 09:16:02 -0700 (PDT) Sender: Alex Alexander Date: Sat, 14 Aug 2010 19:16:26 +0300 From: Alex Alexander To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/mlt: ChangeLog mlt-0.5.4-r1.ebuild Message-ID: <20100814161626.GB1363@linuxized.com> References: <20100806212139.9E8422CE15@corvid.gentoo.org> <201008141535.35239.aballier@gentoo.org> <20100814125053.GA3085@Eternity> <20100814131013.GA1363@linuxized.com> <20100814134739.GA4529@Mystical> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H+4ONPRPur6+Ovig" Content-Disposition: inline In-Reply-To: <20100814134739.GA4529@Mystical> User-Agent: Mutt/1.5.20 (2009-06-14) X-Archives-Salt: 320fd0ab-8048-477c-94ab-c997e60f6312 X-Archives-Hash: b4fce9ac80f183fd93c6d57e62166d43 --H+4ONPRPur6+Ovig Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 14, 2010 at 04:47:39PM +0300, Markos Chandras wrote: > On Sat, Aug 14, 2010 at 04:10:13PM +0300, Alex Alexander wrote: > > On Sat, Aug 14, 2010 at 03:50:53PM +0300, Markos Chandras wrote: > > > > - If you are not in cc of the gentoo bug nor in the herd alias, ple= ase cc=20 > > > > yourself on the bug. > > > > - Please close the bugs, even the dupes (and apply previous point t= o the dupes=20 > > > > too). > > > > - That way you'll be able to quickly fix (apparently, I didn't chec= k) obvious=20 > > > > mistakes [1]. > > > > - You'll have to do a rev. bump for *FLAGS respect, please also che= ck if you=20 > > > > can avoid it by doing a version bump instead. > > > Well not always. If something is on ~testing then I don't think I sho= uld > > > "spam" the tree with revbumps. Stable users are my first priority so > >=20 > > Stable may be more critical, but we support ~testing as well. How do you > > expect your changes to be tested before landing on stable if you don't > > revbump the packages, allowing them to reach our users? > I expect arch testers to do a pretty good testing before they mark them > stable. Seems like I am the only one who fixes such issues without revbum= p. > Strange, cvs log must be lying... >=20 > Now lets see >=20 > http://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html >=20 > "Ebuilds should have their -rX incremented whenever a change is made whic= h will > make a **substantial** difference to what gets installed by the package = =E2=80=94 by > substantial, we generally mean "something for which many users would want= to > upgrade". This is usually for bugfixes." >=20 > Seems like it is up to maintainer's discretion to decide what it is > substantial change and what it is not. Many users wont be directly affect= ed from my changes. It is not like not > respect CXX, CXXFLAGS after all. >=20 > "Simple compile fixes do not warrant a revision bump; this is because the= y do > not affect the installed package for users who already managed to compile= it. > Small documentation fixes are also usually not grounds for a new revision= =2E" >=20 > So you want me to force everyone to update the package just to respect the > LDFLAGS. Why, since until recently, nobody gave a crap about this kind of= QA > issues? >=20 >=20 > Please provide a patch for devmanual to make it more clear. If it is > already clear maybe I am that stupid after all.=20 >=20 > In any case, I will keep doing what I do because you didn't convince me s= o far > that my changes need a revbump. If arch testers fail to do proper testing > thats really *REALLY* not my fault. Testing is testing and I can't do a > revbump for every little piece of shit I fix everytime.=20 Does respecting LDFLAGS change the installed files in any way? yes. Will users benefit from your change if you don't revbump? No. I think that chain of logic is enough to warrant a revbump and it is covered by the devmanual since the change affects the installed package. It's merely a cp, why are you making such a fuss about it? You're doing a good job already, we're just pointing out ways to make it even better :) BTW, archs do the final testing, but much testing is done by the users themselves, who report the bugs that get fixed before the packages get a STABLEREQ bug ;) =20 > >=20 > > Please, don't skip revbumps to avoid "tree spamming", thats why we have > > revbumps in the first place ;) > >=20 > > > unless something is on stable branch, I fix it as it is. I don't want= to > > > version bump anything because I don't want to mess with anyones > > > packages. I only do QA fixing. If you have problem touching your > > > packages just say it > > > > > > > > A. > > > >=20 > > > > [1] https://bugs.gentoo.org/show_bug.cgi?id=3D332523 > > >=20 > > > --=20 > > > Markos Chandras (hwoarang) > > > Gentoo Linux Developer > > > Web: http://hwoarang.silverarrow.org > >=20 > > --=20 > > Alex Alexander -=3D- wired > > Gentoo Linux Developer -=3D- Council / Qt / KDE / more > > www.linuxized.com >=20 >=20 >=20 > --=20 > Markos Chandras (hwoarang) > Gentoo Linux Developer > Web: http://hwoarang.silverarrow.org > Key ID: 441AC410 > Key FP: AAD0 8591 E3CD 445D 6411 3477 F7F7 1E8E 441A C410 --=20 Alex Alexander -=3D- wired Gentoo Linux Developer -=3D- Council / Qt / KDE / more www.linuxized.com --H+4ONPRPur6+Ovig Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (GNU/Linux) iQIcBAEBCAAGBQJMZsFaAAoJEDZF8K7rm0r6+44P/09+BZpoy0A1yfRWjPvtmrIB 7JYVUzqZpEUx5zcyA9gqJdrVTM+HR1scDsoQ4lpTcbD0ktqIRORq6NCa1zT4YhmV YwvGNb50C2j7nEoyhjCE/0GI1H2FRb34DSwxv0VI6t7FkhEUDdEkzJJcrJUjueny SGCJPrfRBU9OFuolX3ZxSfAfhc7pcd3new2KznCT/TM7PfW0VKogsa8nmjsmvjrW ZpgjJyxZGqhp1J1hKu8MEWBoctM14dSzcTr+RZ1yRj9aLAXifYPMvIXhZgBO58/g RwUF7SlbFu1kuF3pUhGXUnxzrK7baMIyhDjUywY1uj1WJSfHh6p8b+JxGATuHDXv fKGgDQeeePBYfm8KjCGEnmycMOFexgWfS/THv7c2nX2i+BOrmQUMOKkuX+uL1hRZ wzm9YICnplfI+hJTnICuYGPO7xlJGFU4wGrb0X6zAF6dWGkMhm6wEXtMA87BjlyB PJabYx5T98e1v4GotusgavHy1n89Ak3K9G4QWFxxcYcP/Ua06OD7JUa/OUKgWFJp mez7v1WxWCm2oR0LBrYHrHUihWbtsdxAd5TuUZ5YdrOodfwUMbMWNzhPg4x1qaZ/ zThusCOOHEh+ZccV2IT4uGzJgLALWSj0FhI54dtBsNAo54VHFhGhc8qVH2oMu9n/ G8bcOKGYtj3TpCOBxkWZ =BKCx -----END PGP SIGNATURE----- --H+4ONPRPur6+Ovig--