From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OkHGL-0007RX-7v for garchives@archives.gentoo.org; Sat, 14 Aug 2010 13:59:05 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1A39EE08AE; Sat, 14 Aug 2010 13:59:02 +0000 (UTC) Received: from mail-ww0-f53.google.com (mail-ww0-f53.google.com [74.125.82.53]) by pigeon.gentoo.org (Postfix) with ESMTP id D6CD5E086D for ; Sat, 14 Aug 2010 13:58:49 +0000 (UTC) Received: by wwb17 with SMTP id 17so2575900wwb.10 for ; Sat, 14 Aug 2010 06:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=aX4xWMKFhEfUpzzNnHsLoUvktyG6uD4WF8B+r+QY3w4=; b=VNoLpjRx+9AJsF7FjgbJ3L/ufgIcLXlTp2U8x0IjTIoDsOnD6IuooUYwp1CDaLHI21 6+2ZiKEphV5ulPRkYbbAJorRtl23NdFfhmqL1lYqkdDXfb+JCDN8FVO6xl1Yc6PCybQ7 KyOCkU0NAH6BL83745i+RImawx26kfm36kZRc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=qtaGPfkBKG0Alc6/oiJGfMsKl2R5pKW6mS1aBVii0JTPXjxxIncvmOUsqbBdBdi8AC UqKsyjf+HRIyZtMMCPzEYnQjddbXo80r8jIp0uIGcWS7Gj0FCw5o0INunmPScgN6IKa1 fE3OXCofK7zT7ty4UFMSQJfgjSZmLbakRKs4Q= Received: by 10.227.147.198 with SMTP id m6mr2617830wbv.78.1281794329235; Sat, 14 Aug 2010 06:58:49 -0700 (PDT) Received: from Mystical (178.128.37.41.dsl.dyn.forthnet.gr [178.128.37.41]) by mx.google.com with ESMTPS id r10sm3394123wbe.18.2010.08.14.06.58.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 14 Aug 2010 06:58:48 -0700 (PDT) Sender: Markos Chandras Date: Sat, 14 Aug 2010 17:00:38 +0300 From: Markos Chandras To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/mlt: ChangeLog mlt-0.5.4-r1.ebuild Message-ID: <20100814140038.GB4529@Mystical> References: <20100806212139.9E8422CE15@corvid.gentoo.org> <201008141535.35239.aballier@gentoo.org> <20100814125053.GA3085@Eternity> <201008141637.04507.aballier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8" Content-Disposition: inline In-Reply-To: <201008141637.04507.aballier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-Archives-Salt: 1f6067a6-0a52-42e1-9e51-c0d71927558a X-Archives-Hash: 6a2f84bdee0f2d72066c38ebf0a45827 --z6Eq5LdranGa6ru8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 14, 2010 at 04:37:04PM +0300, Alexis Ballier wrote: > On Saturday 14 August 2010 15:50:53 Markos Chandras wrote: > > On Sat, Aug 14, 2010 at 03:35:34PM +0300, Alexis Ballier wrote: > > > On Saturday 07 August 2010 00:21:39 Markos Chandras (hwoarang) wrote: > > > > hwoarang 10/08/06 21:21:39 > > > >=20 > > > > Modified: ChangeLog > > > > Added: mlt-0.5.4-r1.ebuild > > > > Log: > > > > Respect {C,LD}FLAGS when building shared library. Bug #308873 > > > > (Portage version: 2.2_rc67/cvs/Linux x86_64) > > >=20 > > > While fixing bugs can't be bad and I thank you for doing it, I can se= e a > > > couple of important quality problems in this commit: > > >=20 > > > - There is absolutely no reference to any patch sent upstream and I h= ave > > > not seen anything on the upstream dev ml. > >=20 > > Thats because I didn't. I've fixed more than 40 bug wrt LDFLAGS. Do you > > expect me to subscribe to 40 different ML and send them upstream?=20 >=20 > you don't need to subscribe, there's usually an AUTHORS file with emails = you=20 > can use... As I said, I thought that maintainers was responsible to do it since they follow all the bug progress after all. So according to you I should do all = the work. Tempting >=20 > > The > > patch is there, the maintainer is CC on the bug. All he has to do it to > > send this damn patch to upstream. >=20 > I can use the same reasoning and ask: > Why don't you do it in the first place if that's "all" ? Cause I cannot maintain all the tree myself >=20 > > I only care about the QA status on tree. >=20 > As I already said, that's good, but that's better achieved with long term= =20 > fixes rather than quick hacks IMHO >=20 > > Most of them just use my patches and > > contact upstream themselves. If this doesn't apply for you just let me > > know. >=20 > Yes this doesn't apply to me because the most probable scenario will be t= his:=20 > I'll touch the package in a couple of months/years, do a review of the=20 > ebuild/patches, find out some patches need porting, waste time trying to= =20 > figure out why it's there in the first place, see it's been there for age= s and=20 > that the author didn't consider the fix good enough to upstream it, drop = it. >=20 Sure, the changelogs are there though. I am trying to always write down as = many details as I can so the maintainer can easily track down changes. > > > - If you are not in cc of the gentoo bug nor in the herd alias, pleas= e cc > > > yourself on the bug. > > > - Please close the bugs, even the dupes (and apply previous point to = the > > > dupes too). > > > - That way you'll be able to quickly fix (apparently, I didn't check) > > > obvious mistakes [1]. > > > - You'll have to do a rev. bump for *FLAGS respect, please also check= if > > > you can avoid it by doing a version bump instead. > >=20 > > Well not always. If something is on ~testing then I don't think I should > > "spam" the tree with revbumps. Stable users are my first priority so > > unless something is on stable branch, I fix it as it is. I don't want to > > version bump anything because I don't want to mess with anyones > > packages. >=20 > You're messing much more with one's package with quick'n'dirty "fixes" th= an=20 > with a clean version bump with upstreamed patches... Quick and dirty? Fair enough. Will try to contact upstream from now on. See= ms like I will maintain the entire tree in the end. >=20 > > I only do QA fixing. If you have problem touching your > > packages just say it >=20 > I don't have problems with anyone touching "my" packages (esp. when they'= re=20 > herds packages...); though when I'm not happy with the technical details = I let=20 > it be known and _really_ appreciate when the comments are taken into acco= unt=20 > instead of aggressively discarded by trying to argue why it's not been pe= rfect=20 > in the first place ;) >=20 > A. >=20 I don't think what I do is perfect. But all this kind of judgement is quite demotivated I must say. --=20 Markos Chandras (hwoarang) Gentoo Linux Developer Web: http://hwoarang.silverarrow.org Key ID: 441AC410 Key FP: AAD0 8591 E3CD 445D 6411 3477 F7F7 1E8E 441A C410 --z6Eq5LdranGa6ru8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iEYEARECAAYFAkxmoYYACgkQ9/cejkQaxBAaWQCfWPIuOR080C6Q8H71MFwzmtrc 8s0An0h3Hpr2nJDPnlceGVKfhSrrnRJV =YQvN -----END PGP SIGNATURE----- --z6Eq5LdranGa6ru8--