From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OkGEr-0001JS-Qd for garchives@archives.gentoo.org; Sat, 14 Aug 2010 12:53:30 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2BA0AE0774; Sat, 14 Aug 2010 12:53:27 +0000 (UTC) Received: from mail-ww0-f53.google.com (mail-ww0-f53.google.com [74.125.82.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 6A12CE0743 for ; Sat, 14 Aug 2010 12:53:15 +0000 (UTC) Received: by wwb17 with SMTP id 17so2523240wwb.10 for ; Sat, 14 Aug 2010 05:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=I2W5gMosL2EwLMtueDDfKNWFMaWvDoQQuHzZrDynJkk=; b=e3ZcxBiZpgSMZeqnSFTQgcGicuJZEtrBT1DA4EFaLO4vneu1AYtWbIvrB/+OM5yqCj Y5N6HsVk41/BXaZvihQ0qM+dSSqbvahmkMuM/dU0qZoQ0JfMcr3dbphwFwB2rWNXWgf8 Kdi7Yg1QwaHGkdXqYMprmODw0OM5uLJuzK+Gw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=C05e12lyvkKailTcNGfJiBCADnXTeZnA7LvPYAPVWM5InCXwxhZHmevLzG3KUCPazS Dy2hXH3sUmyuVmgT4RcSHg5qqmKnLJaQLraQVDvVgKT4ZOYhcs/aultHSrGe62aPC+Zm XEeVGCnkXMFsWIWbP7RtiN3hoTDYkDJsGp4F4= Received: by 10.216.30.10 with SMTP id j10mr624166wea.8.1281790394811; Sat, 14 Aug 2010 05:53:14 -0700 (PDT) Received: from Eternity (178.128.37.41.dsl.dyn.forthnet.gr [178.128.37.41]) by mx.google.com with ESMTPS id e8sm2151598wej.22.2010.08.14.05.53.12 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 14 Aug 2010 05:53:14 -0700 (PDT) Sender: Markos Chandras Date: Sat, 14 Aug 2010 15:50:53 +0300 From: Markos Chandras To: Alexis Ballier Cc: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/mlt: ChangeLog mlt-0.5.4-r1.ebuild Message-ID: <20100814125053.GA3085@Eternity> References: <20100806212139.9E8422CE15@corvid.gentoo.org> <201008141535.35239.aballier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: <201008141535.35239.aballier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-Archives-Salt: 9f1c1e97-f503-424d-ba9e-0f25c86e221c X-Archives-Hash: fe806da1ba4460688f9117c34aacee68 --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 14, 2010 at 03:35:34PM +0300, Alexis Ballier wrote: > On Saturday 07 August 2010 00:21:39 Markos Chandras (hwoarang) wrote: > > hwoarang 10/08/06 21:21:39 > >=20 > > Modified: ChangeLog > > Added: mlt-0.5.4-r1.ebuild > > Log: > > Respect {C,LD}FLAGS when building shared library. Bug #308873 > > (Portage version: 2.2_rc67/cvs/Linux x86_64) >=20 > While fixing bugs can't be bad and I thank you for doing it, I can see a= =20 > couple of important quality problems in this commit: >=20 > - There is absolutely no reference to any patch sent upstream and I have = not=20 > seen anything on the upstream dev ml. Thats because I didn't. I've fixed more than 40 bug wrt LDFLAGS. Do you expect me to subscribe to 40 different ML and send them upstream? The patch is there, the maintainer is CC on the bug. All he has to do it to send this damn patch to upstream. I only care about the QA status on tree. Most of them just use my patches and contact upstream themselves. If this doesn't apply for you just let me know. > - If you are not in cc of the gentoo bug nor in the herd alias, please cc= =20 > yourself on the bug. > - Please close the bugs, even the dupes (and apply previous point to the = dupes=20 > too). > - That way you'll be able to quickly fix (apparently, I didn't check) obv= ious=20 > mistakes [1]. > - You'll have to do a rev. bump for *FLAGS respect, please also check if = you=20 > can avoid it by doing a version bump instead. Well not always. If something is on ~testing then I don't think I should "spam" the tree with revbumps. Stable users are my first priority so unless something is on stable branch, I fix it as it is. I don't want to version bump anything because I don't want to mess with anyones packages. I only do QA fixing. If you have problem touching your packages just say it >=20 >=20 > A. >=20 >=20 >=20 > [1] https://bugs.gentoo.org/show_bug.cgi?id=3D332523 --=20 Markos Chandras (hwoarang) Gentoo Linux Developer Web: http://hwoarang.silverarrow.org --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iEYEARECAAYFAkxmkS0ACgkQ9/cejkQaxBB0HACaA3XdBCZvNtW7a4qq00nDTbBw tfYAnA4wMjQrU+Xz3wyyK8z7Y2PGmPxM =vi58 -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--