From: Jeroen Roovers <jer@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass
Date: Tue, 6 Jul 2010 01:18:27 +0200 [thread overview]
Message-ID: <20100706011827.1adea35a@epia.jer-c2.orkz.net> (raw)
In-Reply-To: <4C3261D0.7090504@gentoo.org>
On Mon, 05 Jul 2010 22:50:56 +0000
"Jorge Manuel B. S. Vicetto" <jmbsvicetto@gentoo.org> wrote:
> I'm not going to delve into the details that have been addressed all
> other this thread. Instead I'll just address one small issue.
> The use of *minor* in the title of this thread and the sheer size of
> the patch attached are not compatible. Please don't label changes
> such as these as *minor* in future instances.
Another major flaw on its own is the sheer size of the patch (it hadn't
been explicitly mentioned to my knowledge). Aren't we supposed to
commit early and often in open source projects instead of dumping all
your changes on reviewers at once (first fork and later merge)? And if
you're still going to do it, a the huge patch should only be necessary
to establish a single sweeping change, not many small changes.
jer
next prev parent reply other threads:[~2010-07-05 23:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 15:23 [gentoo-dev] Minor changes in python.eclass and distutils.eclass Arfrever Frehtes Taifersar Arahesis
2010-07-05 16:13 ` Samuli Suominen
2010-07-05 16:17 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 16:26 ` Samuli Suominen
2010-07-05 16:34 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 16:36 ` Tomáš Chvátal
2010-07-05 17:01 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 17:38 ` Harald van Dijk
2010-07-05 17:43 ` Harald van Dijk
2010-07-05 17:55 ` Pacho Ramos
2010-07-05 18:06 ` Petteri Räty
2010-07-05 16:37 ` Ciaran McCreesh
2010-07-05 17:02 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 18:00 ` Mark Loeser
2010-07-05 18:29 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 19:18 ` Mark Loeser
2010-07-05 20:23 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 21:28 ` Samuli Suominen
2010-07-05 21:38 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 21:49 ` Samuli Suominen
2010-07-05 22:07 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 22:29 ` Mike Frysinger
2010-07-05 23:31 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 23:37 ` Mike Frysinger
2010-07-14 22:36 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 18:26 ` Petteri Räty
2010-07-05 19:59 ` Arfrever Frehtes Taifersar Arahesis
2010-07-05 20:18 ` Petteri Räty
2010-07-05 19:37 ` Alex Alexander
2010-07-05 22:50 ` Jorge Manuel B. S. Vicetto
2010-07-05 23:18 ` Jeroen Roovers [this message]
2010-07-06 6:33 ` Petteri Räty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100706011827.1adea35a@epia.jer-c2.orkz.net \
--to=jer@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox