From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OVtod-0001l4-Uf for garchives@archives.gentoo.org; Mon, 05 Jul 2010 22:07:04 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 04339E0BFB; Mon, 5 Jul 2010 22:07:01 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 6DC49E0ABC for ; Mon, 5 Jul 2010 22:06:54 +0000 (UTC) Received: from afta-gentoo.localnet (ip-85-198-235-97.broker.com.pl [85.198.235.97]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPSA id B21D91B4036 for ; Mon, 5 Jul 2010 22:06:53 +0000 (UTC) From: Arfrever Frehtes Taifersar Arahesis To: Gentoo Development Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass Date: Tue, 6 Jul 2010 00:07:01 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.32-tuxonice-r11-AFTA; KDE/4.4.4; x86_64; ; ) References: <201007051724.02971.Arfrever@gentoo.org> <201007052338.47742.Arfrever@gentoo.org> <4C325386.8060902@gentoo.org> In-Reply-To: <4C325386.8060902@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2606854.2OSvA4ocYX"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201007060007.02674.Arfrever@gentoo.org> X-Archives-Salt: 60a64c99-2845-4361-a5ba-29efeb1fa943 X-Archives-Hash: c38e96b936ceafa9097fbfc126e79270 --nextPart2606854.2OSvA4ocYX Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable 2010-07-05 23:49:58 Samuli Suominen napisa=C5=82(a): > On 07/06/2010 12:38 AM, Arfrever Frehtes Taifersar Arahesis wrote: > > 2010-07-05 23:28:01 Samuli Suominen napisa=C5=82(a): > >> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: > >>> 2010-07-05 21:18:57 Mark Loeser napisa=C5=82(a): > >>>> Arfrever Frehtes Taifersar Arahesis said: > >>>>> 2010-07-05 20:00:11 Mark Loeser napisa=C5=82(a): > >>>>>> Everyone else has already made valid points. I'm just picking thi= s one > >>>>>> to reply to now. Please remove the colors you have added. If you= need > >>>>>> a new function, say "eqawarn", we should have that added in the ne= xt > >>>>>> EAPI with a description of when and where to use it. > >>>>> > >>>>> In case of the colored message added in this patch, if einfo/elog/e= warn/eqawarn/eerror was used, > >>>>> then its output wouldn't be logged by Portage. > >>>> > >>>> I don't understand what you are trying to say. > >>> > >>> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called = in global scope. > >> > >> Can you point to the location of python.eclass / distutils.eclass where > >> you need to send output from global scope, please? > >=20 > > It's at the beginning of this patch. NEED_PYTHON is parsed in global sc= ope. > >=20 >=20 > OK, so let me get this right... are trying to justify using all of the > echo+custom colorization in the eclass by this one occurance, in basis > of it doesn't get logged otherwise? I was justifying using colors in this case (NEED_PYTHON). I'm completely ag= ainst not using colors in status messages (e.g. "Building of dev-python/setuptools-0.6.13 with CPy= thon 3.1..."), which are more useful, when they are easily noticeable by ebuild maintainers. I m= ight agree to remove colors in other deprecation warnings, but this patch wasn't adding any othe= r deprecation warnings. Not using colors in deprecation warnings doesn't have any benefits and only= decreases noticeability of deprecation warnings. =2D-=20 Arfrever Frehtes Taifersar Arahesis --nextPart2606854.2OSvA4ocYX Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMMleGAAoJEFU3/w1zlLfgUCcQAIWdy+NiusJrP/nwM+KMdl/J gzdUTEPEtKJXLlwRb0y3IJh+7UI657gOHC3T89ac1W/8L7Jn74xGj5DKtwuBbdGs 2vJz5z0HEYZ4GZfXhOSBaDWaVoooZ3zQQo7WTraipOfBEvCxa8v/coibMJuYFxmh crF//EejRK/VfxCoxt6Olpsza1YEetejUi6UcOz3TmP9teUecZ+9L4p/dNRJuzrW pxeD5YxGageuK8G4EY52dVqz7HAJXNO7Q65mUh8Ks+FzmbTNlFrJrAndXZlE+9+c u8c5/QaymEQDcdCjqBWi3Nmn5tM5/W87L95fvYApEInMlizjPodlMDFedXR8SP/4 HRsNroOpiqK5pi0AIVonttt2I4XKYEVzmlifQ8cBjwh7I1JZpwr+twkk7+TmGghh HxQF03tCJGV9544gQvvm3Q5A9b7oh5zM8viHfUIZ0ONprbqx0CTFVbeVx0lRN4ul 2sVkh152VIHYsVwu0xFbciy0FGJrkOf4PgJpEuNjZsh8430DrIeeovCcRczX1t0y 9ojP8lxmnZ0egbBziMm3FTWV+uopIXz8Zf3zkDJJ3OGXXLkSo7PFU3/F7O1FZ21G Pm/G4NP1AUYgoe+dveyMSCZkDnuo2qDUo4EhEGNUZMW8FjHl5poXuHfaRVYb58l4 aoY8yeST/5d9nqpT/zPK =p+52 -----END PGP SIGNATURE----- --nextPart2606854.2OSvA4ocYX--