From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OVqR8-0000Ga-Sq for garchives@archives.gentoo.org; Mon, 05 Jul 2010 18:30:35 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BC7451C050; Mon, 5 Jul 2010 18:30:31 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 59CB2E0CAB for ; Mon, 5 Jul 2010 18:30:25 +0000 (UTC) Received: from afta-gentoo.localnet (ip-85-198-235-97.broker.com.pl [85.198.235.97]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPSA id D1B331B40AD for ; Mon, 5 Jul 2010 18:30:24 +0000 (UTC) From: Arfrever Frehtes Taifersar Arahesis To: Gentoo Development Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass Date: Mon, 5 Jul 2010 20:29:50 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.32-tuxonice-r11-AFTA; KDE/4.4.4; x86_64; ; ) References: <201007051724.02971.Arfrever@gentoo.org> <201007051834.40052.Arfrever@gentoo.org> <20100705180011.GB30295@halcy0n.com> In-Reply-To: <20100705180011.GB30295@halcy0n.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1525104.X13YnjVmd2"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201007052030.26739.Arfrever@gentoo.org> X-Archives-Salt: 62c6917e-7abf-4773-8e10-57f276e8e77b X-Archives-Hash: 327fd4a09f37e34039dea21da9dacbbb --nextPart1525104.X13YnjVmd2 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable 2010-07-05 20:00:11 Mark Loeser napisa=C5=82(a): > Arfrever Frehtes Taifersar Arahesis said: > > 2010-07-05 18:26:40 Samuli Suominen napisa=C5=82(a): > > > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote: > > > > 2010-07-05 18:13:26 Samuli Suominen napisa=C5=82(a): > > > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: > > > >>> These minor changes in python.eclass and distutils.eclass have be= en already > > > >>> reviewed on alias of Gentoo Python Project. It's recommended to b= e familiar > > > >>> with internals of current code before trying to understand these = minor changes. > > > >>> Suggestions about indentation and quoting will be rejected. > > > >>> > > > >> > > > >> You have been already told to get rid of all the color customizati= ons in > > > >> the python eclasses here: > > > >> > > > >> http://bugs.gentoo.org/show_bug.cgi?id=3D309057#c2 > > > >> http://bugs.gentoo.org/show_bug.cgi?id=3D309057#c3 > > > >> > > > >> [ .. ] > > > >> > > > >> http://bugs.gentoo.org/show_bug.cgi?id=3D309057#c5 > > > >> > > > >> The bug was wrongly closed as fixed, as it's not really fixed befo= re > > > >> it's all punted > > > >=20 > > > > Colors can be used with echo. > > > >=20 > > >=20 > > > Stop using echo for output and switch to standard output functions, l= ike > > > einfo/eerror/elog/... like told in > > > http://bugs.gentoo.org/show_bug.cgi?id=3D309057#c5 > >=20 > > You should read relevant part of comment #7: > > "The colors can of course be continued to be used in outputs that are p= urely build > > time outputting and not for communicating things for users like what cm= ake builds do." > >=20 > > python.eclass uses colors for build time outputting, which doesn't comm= unicate anything for users. >=20 > Everyone else has already made valid points. I'm just picking this one > to reply to now. Please remove the colors you have added. If you need > a new function, say "eqawarn", we should have that added in the next > EAPI with a description of when and where to use it. In case of the colored message added in this patch, if einfo/elog/ewarn/eqa= warn/eerror was used, then its output wouldn't be logged by Portage. =2D-=20 Arfrever Frehtes Taifersar Arahesis --nextPart1525104.X13YnjVmd2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMMiTCAAoJEFU3/w1zlLfg9AsQALg9zstJcFtiaKa6+v0hhhUS yN/Zk2inyAT/j0P+MT+JgH1f8FdQTDetVRWzkf7eWquVkdNEkWGAE7I33q9YV1wh VnznRsiqWufF0ycv9NCyqbgAstlBlcSTdhRZB5XicpecB54k61kc5FSi2VBIGWMw NcyIpQcpbGakbZyHi8pInXkFjF1kIV2CwdiT8MI1NADOjsQTM+CW3RtRAj2xXMgZ gM7/fwZ6jZVGb9SHr3ASNtR4Tw0AhOG+D4Hi3k7vJO8HB9tsxNWFX41jTs1LsxYE pdf1jI4tm/0K+l/pqiPg8xiRel+2vOI7olT6PwTqucKQqIdGAzS6dJbqvpe55EX9 0NqOp2JAnlQSjNzG0X4pHrd3f0JvIeuX1e7xwYVcCAm/Wpt+qifkxy5+FPXjzP4E sZfLpUeoC2MYRh/8BGSKie8a0q6Klv/fKxRTjxkw16PuN6ve8XEIKuxD3/Wnl3AD 6i9sgkNNVxjoTZG1L1KN7+wdtnSrgeLhgZmKOiLXdgss+nX8WxjSWvTcL8EgFqzI rSUkONEgqLSxAooEOnxNsBaDrzoP90i6W2UUN9IdqfGpyAvnrizsIL4qhEXpLgm0 GHvpArtKMSfRu+d1AlsIrHL7JLhhhtRObTwENDIzy/dNSEX5pz3vg2ysbUymYmeS qCj8nFxLyysoRpUUka7B =Ylx3 -----END PGP SIGNATURE----- --nextPart1525104.X13YnjVmd2--