[gentoo-dev] Minor changes in python.eclass and distutils.eclass

[gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1.1: Type: Text/Plain, Size: 340 bytes --]

These minor changes in python.eclass and distutils.eclass have been already
reviewed on alias of Gentoo Python Project. It's recommended to be familiar
with internals of current code before trying to understand these minor changes.
Suggestions about indentation and quoting will be rejected.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #1.2: eclasses.patch --]
[-- Type: text/x-patch, Size: 48523 bytes --]

--- python.eclass
+++ python.eclass
@@ -161,9 +161,26 @@
 	_parse_PYTHON_DEPEND
 elif [[ -n "${NEED_PYTHON}" ]]; then
 	if ! has "${EAPI:-0}" 0 1 2; then
-		eerror "Use PYTHON_DEPEND instead of NEED_PYTHON."
-		die "NEED_PYTHON cannot be used in this EAPI"
+		eerror "Use PYTHON_DEPEND variable instead of NEED_PYTHON variable."
+		die "NEED_PYTHON variable cannot be used in this EAPI"
 	fi
+
+	if [[ "${NOCOLOR:-false}" =~ ^(false|no)$ ]]; then
+		_RED=$'\e[1;31m'
+		_NORMAL=$'\e[0m'
+	else
+		_RED=
+		_NORMAL=
+	fi
+
+	echo
+	echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
+	echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of NEED_PYTHON variable.${_NORMAL}"
+	echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please report a bug, if it has not been already reported.${_NORMAL}"
+	echo
+
+	unset _BOLD _NORMAL
+
 	_PYTHON_ATOMS=(">=dev-lang/python-${NEED_PYTHON}")
 	DEPEND+="${DEPEND:+ }${_PYTHON_ATOMS[@]}"
 	RDEPEND+="${RDEPEND:+ }${_PYTHON_ATOMS[@]}"
@@ -243,6 +260,10 @@
 	fi
 }
 
+_python_abi-specific_local_scope() {
+	[[ " ${FUNCNAME[@]:2} " =~ " "(_python_final_sanity_checks|python_execute_function|python_mod_optimize|python_mod_cleanup)" " ]]
+}
+
 _python_initialize_prefix_variables() {
 	if has "${EAPI:-0}" 0 1 2; then
 		if [[ -n "${ROOT}" && -z "${EROOT}" ]]; then
@@ -254,10 +275,10 @@
 	fi
 }
 
-unset PYTHON_SANITY_CHECKS
+unset PYTHON_SANITY_CHECKS_EXECUTED PYTHON_SKIP_SANITY_CHECKS
 
 _python_initial_sanity_checks() {
-	if [[ "$(declare -p PYTHON_SANITY_CHECKS 2> /dev/null)" != "declare -- PYTHON_SANITY_CHECKS="* ]]; then
+	if [[ "$(declare -p PYTHON_SANITY_CHECKS_EXECUTED 2> /dev/null)" != "declare -- PYTHON_SANITY_CHECKS_EXECUTED="* || " ${FUNCNAME[@]:1} " =~ " "(python_set_active_version|python_pkg_setup)" " && -z "${PYTHON_SKIP_SANITY_CHECKS}" ]]; then
 		# Ensure that /usr/bin/python and /usr/bin/python-config are valid.
 		if [[ "$(readlink "${EPREFIX}/usr/bin/python")" != "python-wrapper" ]]; then
 			eerror "'${EPREFIX}/usr/bin/python' is not valid symlink."
@@ -273,7 +294,7 @@
 }
 
 _python_final_sanity_checks() {
-	if ! _python_implementation && [[ "$(declare -p PYTHON_SANITY_CHECKS 2> /dev/null)" != "declare -- PYTHON_SANITY_CHECKS="* ]]; then
+	if ! _python_implementation && [[ "$(declare -p PYTHON_SANITY_CHECKS_EXECUTED 2> /dev/null)" != "declare -- PYTHON_SANITY_CHECKS_EXECUTED="* || " ${FUNCNAME[@]:1} " =~ " "(python_set_active_version|python_pkg_setup)" " && -z "${PYTHON_SKIP_SANITY_CHECKS}" ]]; then
 		local PYTHON_ABI="${PYTHON_ABI}"
 		for PYTHON_ABI in ${PYTHON_ABIS-${PYTHON_ABI}}; do
 			# Ensure that appropriate version of Python is installed.
@@ -293,7 +314,7 @@
 			fi
 		done
 	fi
-	PYTHON_SANITY_CHECKS="1"
+	PYTHON_SANITY_CHECKS_EXECUTED="1"
 }
 
 _python_set_color_variables() {
@@ -316,6 +337,14 @@
 
 unset PYTHON_PKG_SETUP_EXECUTED
 
+_python_check_python_pkg_setup_execution() {
+	[[ " ${FUNCNAME[@]:1} " =~ " "(python_set_active_version|python_pkg_setup)" " ]] && return
+
+	if ! has "${EAPI:-0}" 0 1 2 3 && [[ -z "${PYTHON_PKG_SETUP_EXECUTED}" ]]; then
+		die "python_pkg_setup() not called"
+	fi
+}
+
 # @FUNCTION: python_pkg_setup
 # @DESCRIPTION:
 # Perform sanity checks and initialize environment.
@@ -328,6 +357,10 @@
 	# Check if phase is pkg_setup().
 	[[ "${EBUILD_PHASE}" != "setup" ]] && die "${FUNCNAME}() can be used only in pkg_setup() phase"
 
+	if [[ "$#" -ne 0 ]]; then
+		die "${FUNCNAME}() does not accept arguments"
+	fi
+
 	if _python_package_supporting_installation_for_multiple_python_abis; then
 		_python_calculate_PYTHON_ABIS
 		export EPYTHON="$(PYTHON -f)"
@@ -368,7 +401,7 @@
 		}
 
 		if _python_package_supporting_installation_for_multiple_python_abis; then
-			python_execute_function -q python_pkg_setup_check_USE_flags
+			PYTHON_SKIP_SANITY_CHECKS="1" python_execute_function -q python_pkg_setup_check_USE_flags
 		else
 			python_pkg_setup_check_USE_flags
 		fi
@@ -388,6 +421,8 @@
 # @DESCRIPTION:
 # Convert shebangs in specified files. Directories can be specified only with --recursive option.
 python_convert_shebangs() {
+	_python_check_python_pkg_setup_execution
+
 	local argument file files=() only_executables="0" python_version quiet="0" recursive="0"
 
 	while (($#)); do
@@ -466,6 +501,7 @@
 # @DESCRIPTION:
 # Delete needless files in installation image.
 python_clean_installation_image() {
+	_python_check_python_pkg_setup_execution
 	_python_initialize_prefix_variables
 
 	local file files=() quiet="0"
@@ -538,15 +574,23 @@
 # src_prepare, src_configure, src_compile, src_test, src_install.
 if ! has "${EAPI:-0}" 0 1; then
 	python_src_prepare() {
+		_python_check_python_pkg_setup_execution
+
 		if ! _python_package_supporting_installation_for_multiple_python_abis; then
 			die "${FUNCNAME}() cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 		fi
 
+		if [[ "$#" -ne 0 ]]; then
+			die "${FUNCNAME}() does not accept arguments"
+		fi
+
 		python_copy_sources
 	}
 
 	for python_default_function in src_configure src_compile src_test src_install; do
 		eval "python_${python_default_function}() {
+			_python_check_python_pkg_setup_execution
+
 			if ! _python_package_supporting_installation_for_multiple_python_abis; then
 				die \"\${FUNCNAME}() cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs\"
 			fi
@@ -691,19 +735,73 @@
 	_python_final_sanity_checks
 }
 
+_python_prepare_flags() {
+	local array=() deleted_flag element flags new_value old_flag old_value operator pattern prefix variable
+
+	for variable in CPPFLAGS CFLAGS CXXFLAGS LDFLAGS; do
+		eval "_PYTHON_SAVED_${variable}=\"\${!variable}\""
+		for prefix in PYTHON_USER_ PYTHON_; do
+			if [[ "$(declare -p ${prefix}${variable} 2> /dev/null)" == "declare -a ${prefix}${variable}="* ]]; then
+				eval "array=(\"\${${prefix}${variable}[@]}\")"
+				for element in "${array[@]}"; do
+					if [[ "${element}" =~ ^([[:alnum:]]|\.|-|\*|\[|\])+\ (\+|-)\ .+ ]]; then
+						pattern="${element%% *}"
+						element="${element#* }"
+						operator="${element%% *}"
+						flags="${element#* }"
+						if [[ "${PYTHON_ABI}" == ${pattern} ]]; then
+							if [[ "${operator}" == "+" ]]; then
+								eval "export ${variable}+=\"\${variable:+ }${flags}\""
+							elif [[ "${operator}" == "-" ]]; then
+								flags="${flags// /$'\n'}"
+								old_value="${!variable// /$'\n'}"
+								new_value=""
+								while read old_flag; do
+									while read deleted_flag; do
+										if [[ "${old_flag}" == ${deleted_flag} ]]; then
+											continue 2
+										fi
+									done <<< "${flags}"
+									new_value+="${new_value:+ }${old_flag}"
+								done <<< "${old_value}"
+								eval "export ${variable}=\"\${new_value}\""
+							fi
+						fi
+					else
+						die "Element '${element}' of ${prefix}${variable} array has invalid syntax"
+					fi
+				done
+			elif [[ -n "$(declare -p ${prefix}${variable} 2> /dev/null)" ]]; then
+				die "${prefix}${variable} should be indexed array"
+			fi
+		done
+	done
+}
+
+_python_restore_flags() {
+	local variable
+
+	for variable in CPPFLAGS CFLAGS CXXFLAGS LDFLAGS; do
+		eval "${variable}=\"\${_PYTHON_SAVED_${variable}}\""
+		unset _PYTHON_SAVED_${variable}
+	done
+}
+
 # @FUNCTION: python_execute_function
 # @USAGE: [--action-message message] [-d|--default-function] [--failure-message message] [-f|--final-ABI] [--nonfatal] [-q|--quiet] [-s|--separate-build-dirs] [--source-dir source_directory] [--] <function> [arguments]
 # @DESCRIPTION:
 # Execute specified function for each value of PYTHON_ABIS, optionally passing additional
 # arguments. The specified function can use PYTHON_ABI and BUILDDIR variables.
 python_execute_function() {
+	_python_check_python_pkg_setup_execution
+
 	if ! _python_package_supporting_installation_for_multiple_python_abis; then
 		die "${FUNCNAME}() cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 	fi
 
 	_python_set_color_variables
 
-	local action action_message action_message_template= default_function="0" failure_message failure_message_template= final_ABI="0" function i iterated_PYTHON_ABIS nonfatal="0" previous_directory previous_directory_stack previous_directory_stack_length PYTHON_ABI quiet="0" separate_build_dirs="0" source_dir=
+	local action action_message action_message_template= default_function="0" failure_message failure_message_template= final_ABI="0" function iterated_PYTHON_ABIS nonfatal="0" previous_directory previous_directory_stack previous_directory_stack_length PYTHON_ABI quiet="0" return_code separate_build_dirs="0" source_dir=
 
 	while (($#)); do
 		case "$1" in
@@ -800,11 +898,9 @@
 	fi
 
 	# Ensure that python_execute_function() cannot be directly or indirectly called by python_execute_function().
-	for ((i = 1; i < "${#FUNCNAME[@]}"; i++)); do
-		if [[ "${FUNCNAME[${i}]}" == "${FUNCNAME}" ]]; then
-			die "${FUNCNAME}(): Invalid call stack"
-		fi
-	done
+	if _python_abi-specific_local_scope; then
+		die "${FUNCNAME}(): Invalid call stack"
+	fi
 
 	if [[ "${quiet}" == "0" ]]; then
 		[[ "${EBUILD_PHASE}" == "setup" ]] && action="Setting up"
@@ -827,6 +923,8 @@
 		iterated_PYTHON_ABIS="${PYTHON_ABIS}"
 	fi
 	for PYTHON_ABI in ${iterated_PYTHON_ABIS}; do
+		_python_prepare_flags
+
 		if [[ "${quiet}" == "0" ]]; then
 			if [[ -n "${action_message_template}" ]]; then
 				action_message="$(eval echo -n "${action_message_template}")"
@@ -857,7 +955,11 @@
 			EPYTHON="$(PYTHON)" "${function}" "$@"
 		fi
 
-		if [[ "$?" != "0" ]]; then
+		return_code="$?"
+
+		_python_restore_flags
+
+		if [[ "${return_code}" -ne 0 ]]; then
 			if [[ -n "${failure_message_template}" ]]; then
 				failure_message="$(eval echo -n "${failure_message_template}")"
 			else
@@ -924,6 +1026,8 @@
 # @DESCRIPTION:
 # Copy unpacked sources of current package to separate build directory for each Python ABI.
 python_copy_sources() {
+	_python_check_python_pkg_setup_execution
+
 	if ! _python_package_supporting_installation_for_multiple_python_abis; then
 		die "${FUNCNAME}() cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 	fi
@@ -954,6 +1058,8 @@
 # If --respect-EPYTHON option is specified, then generated wrapper scripts will
 # respect EPYTHON variable at run time.
 python_generate_wrapper_scripts() {
+	_python_check_python_pkg_setup_execution
+
 	if ! _python_package_supporting_installation_for_multiple_python_abis; then
 		die "${FUNCNAME}() cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 	fi
@@ -1157,11 +1263,18 @@
 # ========= FUNCTIONS FOR PACKAGES NOT SUPPORTING INSTALLATION FOR MULTIPLE PYTHON ABIS ==========
 # ================================================================================================
 
+unset EPYTHON PYTHON_ABI
+
 # @FUNCTION: python_set_active_version
 # @USAGE: <CPython_ABI|2|3>
 # @DESCRIPTION:
 # Set specified version of CPython as active version of Python.
+#
+# This function can be used only in pkg_setup() phase.
 python_set_active_version() {
+	# Check if phase is pkg_setup().
+	[[ "${EBUILD_PHASE}" != "setup" ]] && die "${FUNCNAME}() can be used only in pkg_setup() phase"
+
 	if _python_package_supporting_installation_for_multiple_python_abis; then
 		die "${FUNCNAME}() cannot be used in ebuilds of packages supporting installation for multiple Python ABIs"
 	fi
@@ -1172,29 +1285,31 @@
 
 	_python_initial_sanity_checks
 
-	if [[ "$1" =~ ^[[:digit:]]+\.[[:digit:]]+$ ]]; then
-		if ! _python_implementation && ! has_version "dev-lang/python:$1"; then
-			die "${FUNCNAME}(): 'dev-lang/python:$1' is not installed"
-		fi
-		export EPYTHON="$(PYTHON "$1")"
-	elif [[ "$1" == "2" ]]; then
-		if ! _python_implementation && ! has_version "=dev-lang/python-2*"; then
-			die "${FUNCNAME}(): '=dev-lang/python-2*' is not installed"
-		fi
-		export EPYTHON="$(PYTHON -2)"
-	elif [[ "$1" == "3" ]]; then
-		if ! _python_implementation && ! has_version "=dev-lang/python-3*"; then
-			die "${FUNCNAME}(): '=dev-lang/python-3*' is not installed"
+	if [[ -z "${PYTHON_ABI}" ]]; then
+		if [[ "$1" =~ ^[[:digit:]]+\.[[:digit:]]+$ ]]; then
+			if ! _python_implementation && ! has_version "dev-lang/python:$1"; then
+				die "${FUNCNAME}(): 'dev-lang/python:$1' is not installed"
+			fi
+			export EPYTHON="$(PYTHON "$1")"
+		elif [[ "$1" == "2" ]]; then
+			if ! _python_implementation && ! has_version "=dev-lang/python-2*"; then
+				die "${FUNCNAME}(): '=dev-lang/python-2*' is not installed"
+			fi
+			export EPYTHON="$(PYTHON -2)"
+		elif [[ "$1" == "3" ]]; then
+			if ! _python_implementation && ! has_version "=dev-lang/python-3*"; then
+				die "${FUNCNAME}(): '=dev-lang/python-3*' is not installed"
+			fi
+			export EPYTHON="$(PYTHON -3)"
+		else
+			die "${FUNCNAME}(): Unrecognized argument '$1'"
 		fi
-		export EPYTHON="$(PYTHON -3)"
-	else
-		die "${FUNCNAME}(): Unrecognized argument '$1'"
-	fi
 
-	# PYTHON_ABI variable is intended to be used only in ebuilds/eclasses,
-	# so it does not need to be exported to subprocesses.
-	PYTHON_ABI="${EPYTHON#python}"
-	PYTHON_ABI="${PYTHON_ABI%%-*}"
+		# PYTHON_ABI variable is intended to be used only in ebuilds/eclasses,
+		# so it does not need to be exported to subprocesses.
+		PYTHON_ABI="${EPYTHON#python}"
+		PYTHON_ABI="${PYTHON_ABI%%-*}"
+	fi
 
 	_python_final_sanity_checks
 
@@ -1206,10 +1321,16 @@
 # @DESCRIPTION: Mark current package for rebuilding by python-updater after
 # switching of active version of Python.
 python_need_rebuild() {
+	_python_check_python_pkg_setup_execution
+
 	if _python_package_supporting_installation_for_multiple_python_abis; then
 		die "${FUNCNAME}() cannot be used in ebuilds of packages supporting installation for multiple Python ABIs"
 	fi
 
+	if [[ "$#" -ne 0 ]]; then
+		die "${FUNCNAME}() does not accept arguments"
+	fi
+
 	export PYTHON_NEED_REBUILD="$(PYTHON --ABI)"
 }
 
@@ -1251,6 +1372,8 @@
 # If --absolute-path option is specified, then absolute path to Python interpreter is printed.
 # --ABI and --absolute-path options cannot be specified simultaneously.
 PYTHON() {
+	_python_check_python_pkg_setup_execution
+
 	local ABI_output="0" absolute_path_output="0" final_ABI="0" PYTHON_ABI="${PYTHON_ABI}" python_interpreter python2="0" python3="0"
 
 	while (($#)); do
@@ -1285,7 +1408,7 @@
 	done
 
 	if [[ "${ABI_output}" == "1" && "${absolute_path_output}" == "1" ]]; then
-		die "${FUNCNAME}(): '--ABI and '--absolute-path' options cannot be specified simultaneously"
+		die "${FUNCNAME}(): '--ABI' and '--absolute-path' options cannot be specified simultaneously"
 	fi
 
 	if [[ "$((${python2} + ${python3} + ${final_ABI}))" -gt 1 ]]; then
@@ -1313,13 +1436,15 @@
 			elif [[ "${PYTHON_ABI}" != "3."* ]]; then
 				die "${FUNCNAME}(): Internal error in \`eselect python show --python3\`"
 			fi
-		elif ! _python_package_supporting_installation_for_multiple_python_abis; then
+		elif _python_package_supporting_installation_for_multiple_python_abis; then
+			if ! _python_abi-specific_local_scope; then
+				die "${FUNCNAME}() should be used in ABI-specific local scope"
+			fi
+		else
 			PYTHON_ABI="$("${EPREFIX}/usr/bin/python" -c "${_PYTHON_ABI_EXTRACTION_COMMAND}")"
 			if [[ -z "${PYTHON_ABI}" ]]; then
 				die "${FUNCNAME}(): Failure of extraction of locally active version of Python"
 			fi
-		elif [[ -z "${PYTHON_ABI}" ]]; then
-			die "${FUNCNAME}(): Invalid usage: ${FUNCNAME}() should be used in ABI-specific local scope"
 		fi
 	elif [[ "$#" -eq 1 ]]; then
 		if [[ "${final_ABI}" == "1" ]]; then
@@ -1364,6 +1489,8 @@
 # Print name of Python implementation.
 # If --final-ABI option is specified, then final ABI from the list of enabled ABIs is used.
 python_get_implementation() {
+	_python_check_python_pkg_setup_execution
+
 	local final_ABI="0" PYTHON_ABI="${PYTHON_ABI}"
 
 	while (($#)); do
@@ -1386,8 +1513,14 @@
 			die "${FUNCNAME}(): '--final-ABI' option cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 		fi
 		PYTHON_ABI="$(PYTHON -f --ABI)"
-	elif [[ -z "${PYTHON_ABI}" ]]; then
-		PYTHON_ABI="$(PYTHON --ABI)"
+	else
+		if _python_package_supporting_installation_for_multiple_python_abis; then
+			if ! _python_abi-specific_local_scope; then
+				die "${FUNCNAME}() should be used in ABI-specific local scope"
+			fi
+		else
+			PYTHON_ABI="${PYTHON_ABI:-$(PYTHON --ABI)}"
+		fi
 	fi
 
 	echo "$(_python_get_implementation "${PYTHON_ABI}")"
@@ -1399,6 +1532,8 @@
 # Print category, name and slot of package providing Python implementation.
 # If --final-ABI option is specified, then final ABI from the list of enabled ABIs is used.
 python_get_implementational_package() {
+	_python_check_python_pkg_setup_execution
+
 	local final_ABI="0" PYTHON_ABI="${PYTHON_ABI}"
 
 	while (($#)); do
@@ -1421,8 +1556,14 @@
 			die "${FUNCNAME}(): '--final-ABI' option cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 		fi
 		PYTHON_ABI="$(PYTHON -f --ABI)"
-	elif [[ -z "${PYTHON_ABI}" ]]; then
-		PYTHON_ABI="$(PYTHON --ABI)"
+	else
+		if _python_package_supporting_installation_for_multiple_python_abis; then
+			if ! _python_abi-specific_local_scope; then
+				die "${FUNCNAME}() should be used in ABI-specific local scope"
+			fi
+		else
+			PYTHON_ABI="${PYTHON_ABI:-$(PYTHON --ABI)}"
+		fi
 	fi
 
 	if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
@@ -1433,15 +1574,21 @@
 }
 
 # @FUNCTION: python_get_includedir
-# @USAGE: [-f|--final-ABI]
+# @USAGE: [-b|--base-path] [-f|--final-ABI]
 # @DESCRIPTION:
 # Print path to Python include directory.
+# If --base-path option is specified, then path not prefixed with "/" is printed.
 # If --final-ABI option is specified, then final ABI from the list of enabled ABIs is used.
 python_get_includedir() {
-	local final_ABI="0" PYTHON_ABI="${PYTHON_ABI}"
+	_python_check_python_pkg_setup_execution
+
+	local base_path="0" final_ABI="0" prefix PYTHON_ABI="${PYTHON_ABI}"
 
 	while (($#)); do
 		case "$1" in
+			-b|--base-path)
+				base_path="1"
+				;;
 			-f|--final-ABI)
 				final_ABI="1"
 				;;
@@ -1455,32 +1602,48 @@
 		shift
 	done
 
+	if [[ "${base_path}" == "0" ]]; then
+		prefix="/"
+	fi
+
 	if [[ "${final_ABI}" == "1" ]]; then
 		if ! _python_package_supporting_installation_for_multiple_python_abis; then
 			die "${FUNCNAME}(): '--final-ABI' option cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 		fi
 		PYTHON_ABI="$(PYTHON -f --ABI)"
-	elif [[ -z "${PYTHON_ABI}" ]]; then
-		PYTHON_ABI="$(PYTHON --ABI)"
+	else
+		if _python_package_supporting_installation_for_multiple_python_abis; then
+			if ! _python_abi-specific_local_scope; then
+				die "${FUNCNAME}() should be used in ABI-specific local scope"
+			fi
+		else
+			PYTHON_ABI="${PYTHON_ABI:-$(PYTHON --ABI)}"
+		fi
 	fi
 
 	if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
-		echo "/usr/include/python${PYTHON_ABI}"
+		echo "${prefix}usr/include/python${PYTHON_ABI}"
 	elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
-		echo "/usr/share/jython-${PYTHON_ABI%-jython}/Include"
+		echo "${prefix}usr/share/jython-${PYTHON_ABI%-jython}/Include"
 	fi
 }
 
 # @FUNCTION: python_get_libdir
-# @USAGE: [-f|--final-ABI]
+# @USAGE: [-b|--base-path] [-f|--final-ABI]
 # @DESCRIPTION:
 # Print path to Python library directory.
+# If --base-path option is specified, then path not prefixed with "/" is printed.
 # If --final-ABI option is specified, then final ABI from the list of enabled ABIs is used.
 python_get_libdir() {
-	local final_ABI="0" PYTHON_ABI="${PYTHON_ABI}"
+	_python_check_python_pkg_setup_execution
+
+	local base_path="0" final_ABI="0" prefix PYTHON_ABI="${PYTHON_ABI}"
 
 	while (($#)); do
 		case "$1" in
+			-b|--base-path)
+				base_path="1"
+				;;
 			-f|--final-ABI)
 				final_ABI="1"
 				;;
@@ -1494,36 +1657,50 @@
 		shift
 	done
 
+	if [[ "${base_path}" == "0" ]]; then
+		prefix="/"
+	fi
+
 	if [[ "${final_ABI}" == "1" ]]; then
 		if ! _python_package_supporting_installation_for_multiple_python_abis; then
 			die "${FUNCNAME}(): '--final-ABI' option cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 		fi
 		PYTHON_ABI="$(PYTHON -f --ABI)"
-	elif [[ -z "${PYTHON_ABI}" ]]; then
-		PYTHON_ABI="$(PYTHON --ABI)"
+	else
+		if _python_package_supporting_installation_for_multiple_python_abis; then
+			if ! _python_abi-specific_local_scope; then
+				die "${FUNCNAME}() should be used in ABI-specific local scope"
+			fi
+		else
+			PYTHON_ABI="${PYTHON_ABI:-$(PYTHON --ABI)}"
+		fi
 	fi
 
 	if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
-		echo "/usr/$(get_libdir)/python${PYTHON_ABI}"
+		echo "${prefix}usr/$(get_libdir)/python${PYTHON_ABI}"
 	elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
-		echo "/usr/share/jython-${PYTHON_ABI%-jython}/Lib"
+		echo "${prefix}usr/share/jython-${PYTHON_ABI%-jython}/Lib"
 	fi
 }
 
 # @FUNCTION: python_get_sitedir
-# @USAGE: [-f|--final-ABI]
+# @USAGE: [-b|--base-path] [-f|--final-ABI]
 # @DESCRIPTION:
 # Print path to Python site-packages directory.
+# If --base-path option is specified, then path not prefixed with "/" is printed.
 # If --final-ABI option is specified, then final ABI from the list of enabled ABIs is used.
 python_get_sitedir() {
-	local options=()
+	_python_check_python_pkg_setup_execution
+
+	local final_ABI="0" options=()
 
 	while (($#)); do
 		case "$1" in
+			-b|--base-path)
+				options+=("$1")
+				;;
 			-f|--final-ABI)
-				if ! _python_package_supporting_installation_for_multiple_python_abis; then
-					die "${FUNCNAME}(): '--final-ABI' option cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
-				fi
+				final_ABI="1"
 				options+=("$1")
 				;;
 			-*)
@@ -1536,20 +1713,36 @@
 		shift
 	done
 
+	if [[ "${final_ABI}" == "1" ]]; then
+		if ! _python_package_supporting_installation_for_multiple_python_abis; then
+			die "${FUNCNAME}(): '--final-ABI' option cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
+		fi
+	else
+		if _python_package_supporting_installation_for_multiple_python_abis && ! _python_abi-specific_local_scope; then
+			die "${FUNCNAME}() should be used in ABI-specific local scope"
+		fi
+	fi
+
 	echo "$(python_get_libdir "${options[@]}")/site-packages"
 }
 
 # @FUNCTION: python_get_library
-# @USAGE: [-f|--final-ABI] [-l|--linker-option]
+# @USAGE: [-b|--base-path] [-f|--final-ABI] [-l|--linker-option]
 # @DESCRIPTION:
 # Print path to Python library.
+# If --base-path option is specified, then path not prefixed with "/" is printed.
 # If --linker-option is specified, then "-l${library}" linker option is printed.
 # If --final-ABI option is specified, then final ABI from the list of enabled ABIs is used.
 python_get_library() {
-	local final_ABI="0" linker_option="0" PYTHON_ABI="${PYTHON_ABI}"
+	_python_check_python_pkg_setup_execution
+
+	local base_path="0" final_ABI="0" linker_option="0" prefix PYTHON_ABI="${PYTHON_ABI}"
 
 	while (($#)); do
 		case "$1" in
+			-b|--base-path)
+				base_path="1"
+				;;
 			-f|--final-ABI)
 				final_ABI="1"
 				;;
@@ -1566,20 +1759,34 @@
 		shift
 	done
 
+	if [[ "${base_path}" == "0" ]]; then
+		prefix="/"
+	fi
+
+	if [[ "${base_path}" == "1" && "${linker_option}" == "1" ]]; then
+		die "${FUNCNAME}(): '--base-path' and '--linker-option' options cannot be specified simultaneously"
+	fi
+
 	if [[ "${final_ABI}" == "1" ]]; then
 		if ! _python_package_supporting_installation_for_multiple_python_abis; then
 			die "${FUNCNAME}(): '--final-ABI' option cannot be used in ebuilds of packages not supporting installation for multiple Python ABIs"
 		fi
 		PYTHON_ABI="$(PYTHON -f --ABI)"
-	elif [[ -z "${PYTHON_ABI}" ]]; then
-		PYTHON_ABI="$(PYTHON --ABI)"
+	else
+		if _python_package_supporting_installation_for_multiple_python_abis; then
+			if ! _python_abi-specific_local_scope; then
+				die "${FUNCNAME}() should be used in ABI-specific local scope"
+			fi
+		else
+			PYTHON_ABI="${PYTHON_ABI:-$(PYTHON --ABI)}"
+		fi
 	fi
 
 	if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
 		if [[ "${linker_option}" == "1" ]]; then
 			echo "-lpython${PYTHON_ABI}"
 		else
-			echo "/usr/$(get_libdir)/libpython${PYTHON_ABI}$(get_libname)"
+			echo "${prefix}usr/$(get_libdir)/libpython${PYTHON_ABI}$(get_libname)"
 		fi
 	elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
 		die "${FUNCNAME}(): Jython does not have shared library"
@@ -1594,6 +1801,8 @@
 # If --full, --major, --minor and --micro options are not specified, then "${major_version}.${minor_version}" is printed.
 # If --final-ABI option is specified, then final ABI from the list of enabled ABIs is used.
 python_get_version() {
+	_python_check_python_pkg_setup_execution
+
 	local final_ABI="0" full="0" major="0" minor="0" micro="0" python_command
 
 	while (($#)); do
@@ -1653,6 +1862,9 @@
 		fi
 		"$(PYTHON -f)" -c "${python_command}"
 	else
+		if _python_package_supporting_installation_for_multiple_python_abis && ! _python_abi-specific_local_scope; then
+			die "${FUNCNAME}() should be used in ABI-specific local scope"
+		fi
 		"$(PYTHON ${PYTHON_ABI})" -c "${python_command}"
 	fi
 }
@@ -1684,6 +1896,7 @@
 # In ebuilds of packages supporting installation for multiple Python ABIs, this function calls
 # python_execute_nosetests_pre_hook() and python_execute_nosetests_post_hook(), if they are defined.
 python_execute_nosetests() {
+	_python_check_python_pkg_setup_execution
 	_python_set_color_variables
 
 	local PYTHONPATH_template= separate_build_dirs=
@@ -1712,14 +1925,9 @@
 	done
 
 	python_test_function() {
-		local evaluated_PYTHONPATH=
+		local evaluated_PYTHONPATH
 
-		if [[ -n "${PYTHONPATH_template}" ]]; then
-			evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")"
-			if [[ ! -e "${evaluated_PYTHONPATH}" ]]; then
-				unset evaluated_PYTHONPATH
-			fi
-		fi
+		evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")"
 
 		_python_test_hook pre
 
@@ -1752,6 +1960,7 @@
 # In ebuilds of packages supporting installation for multiple Python ABIs, this function calls
 # python_execute_py.test_pre_hook() and python_execute_py.test_post_hook(), if they are defined.
 python_execute_py.test() {
+	_python_check_python_pkg_setup_execution
 	_python_set_color_variables
 
 	local PYTHONPATH_template= separate_build_dirs=
@@ -1780,14 +1989,9 @@
 	done
 
 	python_test_function() {
-		local evaluated_PYTHONPATH=
+		local evaluated_PYTHONPATH
 
-		if [[ -n "${PYTHONPATH_template}" ]]; then
-			evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")"
-			if [[ ! -e "${evaluated_PYTHONPATH}" ]]; then
-				unset evaluated_PYTHONPATH
-			fi
-		fi
+		evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")"
 
 		_python_test_hook pre
 
@@ -1820,6 +2024,7 @@
 # In ebuilds of packages supporting installation for multiple Python ABIs, this function
 # calls python_execute_trial_pre_hook() and python_execute_trial_post_hook(), if they are defined.
 python_execute_trial() {
+	_python_check_python_pkg_setup_execution
 	_python_set_color_variables
 
 	local PYTHONPATH_template= separate_build_dirs=
@@ -1848,14 +2053,9 @@
 	done
 
 	python_test_function() {
-		local evaluated_PYTHONPATH=
+		local evaluated_PYTHONPATH
 
-		if [[ -n "${PYTHONPATH_template}" ]]; then
-			evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")"
-			if [[ ! -e "${evaluated_PYTHONPATH}" ]]; then
-				unset evaluated_PYTHONPATH
-			fi
-		fi
+		evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")"
 
 		_python_test_hook pre
 
@@ -1890,6 +2090,12 @@
 # Tell Python to automatically recompile modules to .pyc/.pyo if the
 # timestamps/version stamps have changed.
 python_enable_pyc() {
+	_python_check_python_pkg_setup_execution
+
+	if [[ "$#" -ne 0 ]]; then
+		die "${FUNCNAME}() does not accept arguments"
+	fi
+
 	unset PYTHONDONTWRITEBYTECODE
 }
 
@@ -1899,6 +2105,12 @@
 # even if the timestamps/version stamps do not match. This is done
 # to protect sandbox.
 python_disable_pyc() {
+	_python_check_python_pkg_setup_execution
+
+	if [[ "$#" -ne 0 ]]; then
+		die "${FUNCNAME}() does not accept arguments"
+	fi
+
 	export PYTHONDONTWRITEBYTECODE="1"
 }
 
@@ -2005,6 +2217,7 @@
 #
 # This function can be used only in pkg_postinst() phase.
 python_mod_optimize() {
+	_python_check_python_pkg_setup_execution
 	_python_initialize_prefix_variables
 
 	# Check if phase is pkg_postinst().
@@ -2015,12 +2228,16 @@
 		local dir file iterated_PYTHON_ABIS options=() other_dirs=() other_files=() previous_PYTHON_ABI="${PYTHON_ABI}" return_code root site_packages_absolute_dirs=() site_packages_dirs=() site_packages_absolute_files=() site_packages_files=()
 
 		if _python_package_supporting_installation_for_multiple_python_abis; then
-			if [[ -z "${PYTHON_ABIS}" ]]; then
-				die "${FUNCNAME}(): Environment not initialized"
+			if has "${EAPI:-0}" 0 1 2 3 && [[ -z "${PYTHON_ABIS}" ]]; then
+				die "${FUNCNAME}(): python_pkg_setup() or python_execute_function() not called"
 			fi
 			iterated_PYTHON_ABIS="${PYTHON_ABIS}"
 		else
-			iterated_PYTHON_ABIS="${PYTHON_ABI:=$(PYTHON --ABI)}"
+			if has "${EAPI:-0}" 0 1 2 3; then
+				iterated_PYTHON_ABIS="${PYTHON_ABI:=$(PYTHON --ABI)}"
+			else
+				iterated_PYTHON_ABIS="${PYTHON_ABI}"
+			fi
 		fi
 
 		# Strip trailing slash from EROOT.
@@ -2035,8 +2252,12 @@
 					options+=("$1" "$2")
 					shift
 					;;
+				--)
+					shift
+					break
+					;;
 				-*)
-					ewarn "${FUNCNAME}(): Ignoring option '$1'"
+					die "${FUNCNAME}(): Unrecognized option '$1'"
 					;;
 				*)
 					break
@@ -2062,7 +2283,9 @@
 		fi
 
 		while (($#)); do
-			if ! _python_implementation && [[ "$1" =~ ^/usr/lib(32|64)?/python[[:digit:]]+\.[[:digit:]]+ ]]; then
+			if [[ "$1" =~ ^($|(\.|\.\.|/)($|/)) ]]; then
+				die "${FUNCNAME}(): Invalid argument '$1'"
+			elif ! _python_implementation && [[ "$1" =~ ^/usr/lib(32|64)?/python[[:digit:]]+\.[[:digit:]]+ ]]; then
 				die "${FUNCNAME}(): Paths of directories / files in site-packages directories must be relative to site-packages directories"
 			elif [[ "$1" =~ ^/ ]]; then
 				if _python_package_supporting_installation_for_multiple_python_abis; then
@@ -2073,9 +2296,9 @@
 				elif [[ -f "${root}$1" ]]; then
 					other_files+=("${root}$1")
 				elif [[ -e "${root}$1" ]]; then
-					eerror "'${root}$1' is not a file or a directory!"
+					eerror "${FUNCNAME}(): '${root}$1' is not a regular file or a directory"
 				else
-					eerror "'${root}$1' does not exist!"
+					eerror "${FUNCNAME}(): '${root}$1' does not exist"
 				fi
 			else
 				for PYTHON_ABI in ${iterated_PYTHON_ABIS}; do
@@ -2086,9 +2309,9 @@
 						site_packages_files+=("$1")
 						break
 					elif [[ -e "${root}$(python_get_sitedir)/$1" ]]; then
-						eerror "'$1' is not a file or a directory!"
+						eerror "${FUNCNAME}(): '$1' is not a regular file or a directory"
 					else
-						eerror "'$1' does not exist!"
+						eerror "${FUNCNAME}(): '$1' does not exist"
 					fi
 				done
 			fi
@@ -2173,8 +2396,12 @@
 					myopts+=("$1" "$2")
 					shift
 					;;
+				--)
+					shift
+					break
+					;;
 				-*)
-					ewarn "${FUNCNAME}(): Ignoring option '$1'"
+					die "${FUNCNAME}(): Unrecognized option '$1'"
 					;;
 				*)
 					break
@@ -2200,15 +2427,17 @@
 		fi
 
 		while (($#)); do
-			if [[ -d "${myroot}/${1#/}" ]]; then
+			if [[ "$1" =~ ^($|(\.|\.\.|/)($|/)) ]]; then
+				die "${FUNCNAME}(): Invalid argument '$1'"
+			elif [[ -d "${myroot}/${1#/}" ]]; then
 				mydirs+=("${myroot}/${1#/}")
 			elif [[ -f "${myroot}/${1#/}" ]]; then
 				# Files are passed to python_mod_compile which is EROOT-aware
 				myfiles+=("$1")
 			elif [[ -e "${myroot}/${1#/}" ]]; then
-				eerror "${myroot}/${1#/} is not a file or directory!"
+				eerror "${FUNCNAME}(): ${myroot}/${1#/} is not a regular file or directory"
 			else
-				eerror "${myroot}/${1#/} does not exist!"
+				eerror "${FUNCNAME}(): ${myroot}/${1#/} does not exist"
 			fi
 			shift
 		done
@@ -2245,6 +2474,7 @@
 #
 # This function can be used only in pkg_postrm() phase.
 python_mod_cleanup() {
+	_python_check_python_pkg_setup_execution
 	_python_initialize_prefix_variables
 
 	local dir iterated_PYTHON_ABIS PYTHON_ABI="${PYTHON_ABI}" root search_paths=() sitedir
@@ -2253,12 +2483,16 @@
 	[[ "${EBUILD_PHASE}" != "postrm" ]] && die "${FUNCNAME}() can be used only in pkg_postrm() phase"
 
 	if _python_package_supporting_installation_for_multiple_python_abis; then
-		if [[ -z "${PYTHON_ABIS}" ]]; then
-			die "${FUNCNAME}(): Environment not initialized"
+		if has "${EAPI:-0}" 0 1 2 3 && [[ -z "${PYTHON_ABIS}" ]]; then
+			die "${FUNCNAME}(): python_pkg_setup() or python_execute_function() not called"
 		fi
 		iterated_PYTHON_ABIS="${PYTHON_ABIS}"
 	else
-		iterated_PYTHON_ABIS="${PYTHON_ABI:-$(PYTHON --ABI)}"
+		if has "${EAPI:-0}" 0 1 2 3; then
+			iterated_PYTHON_ABIS="${PYTHON_ABI:-$(PYTHON --ABI)}"
+		else
+			iterated_PYTHON_ABIS="${PYTHON_ABI}"
+		fi
 	fi
 
 	# Strip trailing slash from EROOT.
@@ -2267,7 +2501,9 @@
 	if [[ "$#" -gt 0 ]]; then
 		if ! has "${EAPI:-0}" 0 1 2 || _python_package_supporting_installation_for_multiple_python_abis; then
 			while (($#)); do
-				if ! _python_implementation && [[ "$1" =~ ^/usr/lib(32|64)?/python[[:digit:]]+\.[[:digit:]]+ ]]; then
+				if [[ "$1" =~ ^($|(\.|\.\.|/)($|/)) ]]; then
+					die "${FUNCNAME}(): Invalid argument '$1'"
+				elif ! _python_implementation && [[ "$1" =~ ^/usr/lib(32|64)?/python[[:digit:]]+\.[[:digit:]]+ ]]; then
 					die "${FUNCNAME}(): Paths of directories / files in site-packages directories must be relative to site-packages directories"
 				elif [[ "$1" =~ ^/ ]]; then
 					if _python_package_supporting_installation_for_multiple_python_abis; then
@@ -2325,119 +2561,22 @@
 # ===================================== DEPRECATED FUNCTIONS =====================================
 # ================================================================================================
 
-# @FUNCTION: python_version
-# @DESCRIPTION:
-# Run without arguments and it will export the version of python
-# currently in use as $PYVER; sets PYVER/PYVER_MAJOR/PYVER_MINOR
+# Scheduled for deletion on 2011-01-01.
 python_version() {
-	if ! has "${EAPI:-0}" 0 1 2 || _python_package_supporting_installation_for_multiple_python_abis; then
-		eerror "Use PYTHON() and/or python_get_*() instead of ${FUNCNAME}()."
-		die "${FUNCNAME}() cannot be used in this EAPI"
-	fi
-
-	_python_set_color_variables
-
-	if [[ "${FUNCNAME[1]}" != "distutils_python_version" ]]; then
-		echo
-		echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: ${FUNCNAME}() is deprecated and will be banned on 2010-07-01.${_NORMAL}"
-		echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON() instead of python variable. Use python_get_*() instead of PYVER* variables.${_NORMAL}"
-		echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please report a bug, if it has not been already reported.${_NORMAL}"
-		echo
-
-		einfo &> /dev/null
-		einfo "Deprecation Warning: ${FUNCNAME}() is deprecated and will be banned on 2010-07-01." &> /dev/null
-		einfo "Use PYTHON() instead of python variable. Use python_get_*() instead of PYVER* variables." &> /dev/null
-		einfo "The ebuild needs to be fixed. Please report a bug, if it has not been already reported." &> /dev/null
-		einfo &> /dev/null
-	fi
+	eerror "Use PYTHON() instead of python variable. Use python_get_*() instead of PYVER* variables."
+	die "${FUNCNAME}() is banned"
+}
 
-	[[ -n "${PYVER}" ]] && return 0
-	local tmpstr
-	python="${python:-${EPREFIX}/usr/bin/python}"
-	tmpstr="$(EPYTHON= ${python} -V 2>&1 )"
-	export PYVER_ALL="${tmpstr#Python }"
-	export PYVER_MAJOR="${PYVER_ALL:0:1}"
-	export PYVER_MINOR="${PYVER_ALL:2:1}"
-	if [[ "${PYVER_ALL:3:1}" == "." ]]; then
-		export PYVER_MICRO="${PYVER_ALL:4}"
-	fi
-	export PYVER="${PYVER_MAJOR}.${PYVER_MINOR}"
-}
-
-# @FUNCTION: python_mod_exists
-# @USAGE: <module>
-# @DESCRIPTION:
-# Run with the module name as an argument. It will check if a
-# Python module is installed and loadable. It will return
-# TRUE(0) if the module exists, and FALSE(1) if the module does
-# not exist.
-#
-# Example:
-#         if python_mod_exists gtk; then
-#             echo "gtk support enabled"
-#         fi
+# Scheduled for deletion on 2011-01-01.
 python_mod_exists() {
-	if ! has "${EAPI:-0}" 0 1 2 || _python_package_supporting_installation_for_multiple_python_abis; then
-		eerror "Use USE dependencies and/or has_version() instead of ${FUNCNAME}()."
-		die "${FUNCNAME}() cannot be used in this EAPI"
-	fi
-
-	_python_set_color_variables
-
-	echo
-	echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: ${FUNCNAME}() is deprecated and will be banned on 2010-07-01.${_NORMAL}"
-	echo " ${_RED}*${_NORMAL} ${_RED}Use USE dependencies and/or has_version() instead of ${FUNCNAME}().${_NORMAL}"
-	echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please report a bug, if it has not been already reported.${_NORMAL}"
-	echo
-
-	eerror &> /dev/null
-	eerror "Deprecation Warning: ${FUNCNAME}() is deprecated and will be banned on 2010-07-01." &> /dev/null
-	eerror "Use USE dependencies and/or has_version() instead of ${FUNCNAME}()." &> /dev/null
-	eerror "The ebuild needs to be fixed. Please report a bug, if it has not been already reported." &> /dev/null
-	eerror &> /dev/null
-
-	if [[ "$#" -ne 1 ]]; then
-		die "${FUNCNAME}() requires 1 argument"
-	fi
-	"$(PYTHON ${PYTHON_ABI})" -c "import $1" &> /dev/null
+	eerror "Use USE dependencies and/or has_version() instead of ${FUNCNAME}()."
+	die "${FUNCNAME}() is banned"
 }
 
-# @FUNCTION: python_tkinter_exists
-# @DESCRIPTION:
-# Run without arguments, checks if Python was compiled with Tkinter
-# support.  If not, prints an error message and dies.
+# Scheduled for deletion on 2011-01-01.
 python_tkinter_exists() {
-	if ! has "${EAPI:-0}" 0 1 2 || _python_package_supporting_installation_for_multiple_python_abis; then
-		eerror "Use PYTHON_USE_WITH=\"xml\" and python_pkg_setup() instead of ${FUNCNAME}()."
-		die "${FUNCNAME}() cannot be used in this EAPI"
-	fi
-
-	_python_set_color_variables
-
-	if [[ "${FUNCNAME[1]}" != "distutils_python_tkinter" ]]; then
-		echo
-		echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: ${FUNCNAME}() is deprecated and will be banned on 2010-07-01.${_NORMAL}"
-		echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_USE_WITH=\"xml\" and python_pkg_setup() instead of ${FUNCNAME}().${_NORMAL}"
-		echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please report a bug, if it has not been already reported.${_NORMAL}"
-		echo
-
-		eerror &> /dev/null
-		eerror "Deprecation Warning: ${FUNCNAME}() is deprecated and will be banned on 2010-07-01." &> /dev/null
-		eerror "Use PYTHON_USE_WITH=\"xml\" and python_pkg_setup() instead of ${FUNCNAME}()." &> /dev/null
-		eerror "The ebuild needs to be fixed. Please report a bug, if it has not been already reported." &> /dev/null
-		eerror &> /dev/null
-	fi
-
-	if ! "$(PYTHON ${PYTHON_ABI})" -c "from sys import version_info
-if version_info[0] == 3:
-	import tkinter
-else:
-	import Tkinter" &> /dev/null; then
-		eerror "Python needs to be rebuilt with tkinter support enabled."
-		eerror "Add the following line to '${EPREFIX}/etc/portage/package.use' and rebuild Python"
-		eerror "dev-lang/python tk"
-		die "Python installed without support for tkinter"
-	fi
+	eerror "Use PYTHON_USE_WITH=\"xml\" and python_pkg_setup() instead of ${FUNCNAME}()."
+	die "${FUNCNAME}() is banned"
 }
 
 # @FUNCTION: python_mod_compile
--- distutils.eclass
+++ distutils.eclass
@@ -38,9 +38,13 @@
 # @DESCRIPTION:
 # Set this to use separate source directories for each enabled version of Python.
 
+# @ECLASS-VARIABLE: DISTUTILS_SETUP_FILES
+# @DESCRIPTION:
+# Paths to setup files.
+
 # @ECLASS-VARIABLE: DISTUTILS_GLOBAL_OPTIONS
 # @DESCRIPTION:
-# Global options passed to setup.py.
+# Global options passed to setup files.
 
 # @ECLASS-VARIABLE: DISTUTILS_SRC_TEST
 # @DESCRIPTION:
@@ -180,15 +184,21 @@
 		distutils_building() {
 			_distutils_hook pre
 
-			echo ${_BOLD}"$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" build -b "$(_distutils_get_build_dir)" "$@"${_NORMAL}
-			"$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" build -b "$(_distutils_get_build_dir)" "$@" || return "$?"
+			local setup_file
+			for setup_file in "${DISTUTILS_SETUP_FILES[@]-setup.py}"; do
+				echo ${_BOLD}"$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" build -b "$(_distutils_get_build_dir)" "$@"${_NORMAL}
+				"$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" build -b "$(_distutils_get_build_dir)" "$@" || return "$?"
+			done
 
 			_distutils_hook post
 		}
 		python_execute_function ${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES:+-s} distutils_building "$@"
 	else
-		echo ${_BOLD}"$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" build "$@"${_NORMAL}
-		"$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" build "$@" || die "Building failed"
+		local setup_file
+		for setup_file in "${DISTUTILS_SETUP_FILES[@]-setup.py}"; do
+			echo ${_BOLD}"$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" build "$@"${_NORMAL}
+			"$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" build "$@" || die "Building failed"
+		done
 	fi
 }
 
@@ -231,15 +241,21 @@
 			distutils_testing() {
 				_distutils_hook pre
 
-				echo ${_BOLD}PYTHONPATH="$(_distutils_get_PYTHONPATH)" "$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" $([[ -z "${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES}" ]] && echo build -b "$(_distutils_get_build_dir)") test "$@"${_NORMAL}
-				PYTHONPATH="$(_distutils_get_PYTHONPATH)" "$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" $([[ -z "${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES}" ]] && echo build -b "$(_distutils_get_build_dir)") test "$@" || return "$?"
+				local setup_file
+				for setup_file in "${DISTUTILS_SETUP_FILES[@]-setup.py}"; do
+					echo ${_BOLD}PYTHONPATH="$(_distutils_get_PYTHONPATH)" "$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" $([[ -z "${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES}" ]] && echo build -b "$(_distutils_get_build_dir)") test "$@"${_NORMAL}
+					PYTHONPATH="$(_distutils_get_PYTHONPATH)" "$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" $([[ -z "${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES}" ]] && echo build -b "$(_distutils_get_build_dir)") test "$@" || return "$?"
+				done
 
 				_distutils_hook post
 			}
 			python_execute_function ${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES:+-s} distutils_testing "$@"
 		else
-			echo ${_BOLD}PYTHONPATH="$(_distutils_get_PYTHONPATH)" "$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" test "$@"${_NORMAL}
-			PYTHONPATH="$(_distutils_get_PYTHONPATH)" "$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" test "$@" || die "Testing failed"
+			local setup_file
+			for setup_file in "${DISTUTILS_SETUP_FILES[@]-setup.py}"; do
+				echo ${_BOLD}PYTHONPATH="$(_distutils_get_PYTHONPATH)" "$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" test "$@"${_NORMAL}
+				PYTHONPATH="$(_distutils_get_PYTHONPATH)" "$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" test "$@" || die "Testing failed"
+			done
 		fi
 	elif [[ "${DISTUTILS_SRC_TEST}" == "nosetests" ]]; then
 		_distutils_src_test_hook nosetests
@@ -306,8 +322,11 @@
 		distutils_installation() {
 			_distutils_hook pre
 
-			echo ${_BOLD}"$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" $([[ -z "${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES}" ]] && echo build -b "$(_distutils_get_build_dir)") install --root="${D}" --no-compile "$@"${_NORMAL}
-			"$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" $([[ -z "${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES}" ]] && echo build -b "$(_distutils_get_build_dir)") install --root="${D}" --no-compile "$@" || return "$?"
+			local setup_file
+			for setup_file in "${DISTUTILS_SETUP_FILES[@]-setup.py}"; do
+				echo ${_BOLD}"$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" $([[ -z "${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES}" ]] && echo build -b "$(_distutils_get_build_dir)") install --root="${D}" --no-compile "$@"${_NORMAL}
+				"$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" $([[ -z "${DISTUTILS_USE_SEPARATE_SOURCE_DIRECTORIES}" ]] && echo build -b "$(_distutils_get_build_dir)") install --root="${D}" --no-compile "$@" || return "$?"
+			done
 
 			if [[ -z "${DISTUTILS_DISABLE_VERSIONING_OF_PYTHON_SCRIPTS}" && "${BASH_VERSINFO[0]}" -ge 4 ]]; then
 				rename_scripts_with_versioned_shebangs
@@ -325,8 +344,11 @@
 		# Mark the package to be rebuilt after a Python upgrade.
 		python_need_rebuild
 
-		echo ${_BOLD}"$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" install --root="${D}" --no-compile "$@"${_NORMAL}
-		"$(PYTHON)" setup.py "${DISTUTILS_GLOBAL_OPTIONS[@]}" install --root="${D}" --no-compile "$@" || die "Installation failed"
+		local setup_file
+		for setup_file in "${DISTUTILS_SETUP_FILES[@]-setup.py}"; do
+			echo ${_BOLD}"$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" install --root="${D}" --no-compile "$@"${_NORMAL}
+			"$(PYTHON)" "${setup_file}" "${DISTUTILS_GLOBAL_OPTIONS[@]}" install --root="${D}" --no-compile "$@" || die "Installation failed"
+		done
 	fi
 
 	if [[ -e "${ED}usr/local" ]]; then
@@ -416,40 +438,14 @@
 	fi
 }
 
-# @FUNCTION: distutils_python_version
-# @DESCRIPTION:
-# Deprecated wrapper function for deprecated python_version().
+# Scheduled for deletion on 2011-01-01.
 distutils_python_version() {
-	if ! has "${EAPI:-0}" 0 1 2 || [[ -n "${SUPPORT_PYTHON_ABIS}" ]]; then
-		eerror "Use PYTHON() and/or python_get_*() instead of ${FUNCNAME}()."
-		die "${FUNCNAME}() cannot be used in this EAPI"
-	fi
-
-	_python_set_color_variables
-
-	eerror
-	eerror "${_RED}Deprecation Warning: ${FUNCNAME}() is deprecated and will be banned on 2010-07-01.${_NORMAL}"
-	eerror "${_RED}Use PYTHON() instead of python variable. Use python_get_*() instead of PYVER* variables.${_NORMAL}"
-	eerror
-
-	python_version
+	eerror "Use PYTHON() instead of python variable. Use python_get_*() instead of PYVER* variables."
+	die "${FUNCNAME}() is banned"
 }
 
-# @FUNCTION: distutils_python_tkinter
-# @DESCRIPTION:
-# Deprecated wrapper function for deprecated python_tkinter_exists().
+# Scheduled for deletion on 2011-01-01.
 distutils_python_tkinter() {
-	if ! has "${EAPI:-0}" 0 1 2 || [[ -n "${SUPPORT_PYTHON_ABIS}" ]]; then
-		eerror "Use PYTHON_USE_WITH=\"xml\" and python_pkg_setup() instead of ${FUNCNAME}()."
-		die "${FUNCNAME}() cannot be used in this EAPI"
-	fi
-
-	_python_set_color_variables
-
-	eerror
-	eerror "${_RED}Deprecation Warning: ${FUNCNAME}() is deprecated and will be banned on 2010-07-01.${_NORMAL}"
-	eerror "${_RED}Use PYTHON_USE_WITH=\"xml\" and python_pkg_setup() instead of ${FUNCNAME}().${_NORMAL}"
-	eerror
-
-	python_tkinter_exists
+	eerror "Use PYTHON_USE_WITH=\"xml\" and python_pkg_setup() instead of ${FUNCNAME}()."
+	die "${FUNCNAME}() is banned"
 }

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Samuli Suominen]

On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> These minor changes in python.eclass and distutils.eclass have been already
> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> with internals of current code before trying to understand these minor changes.
> Suggestions about indentation and quoting will be rejected.
> 

You have been already told to get rid of all the color customizations in
the python eclasses here:

http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
http://bugs.gentoo.org/show_bug.cgi?id=309057#c3

[ .. ]

http://bugs.gentoo.org/show_bug.cgi?id=309057#c5

The bug was wrongly closed as fixed, as it's not really fixed before
it's all punted

- Samuli

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 897 bytes --]

2010-07-05 18:13:26 Samuli Suominen napisał(a):
> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > These minor changes in python.eclass and distutils.eclass have been already
> > reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > with internals of current code before trying to understand these minor changes.
> > Suggestions about indentation and quoting will be rejected.
> > 
> 
> You have been already told to get rid of all the color customizations in
> the python eclasses here:
> 
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> 
> [ .. ]
> 
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> 
> The bug was wrongly closed as fixed, as it's not really fixed before
> it's all punted

Colors can be used with echo.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Samuli Suominen]

On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 18:13:26 Samuli Suominen napisał(a):
>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>> These minor changes in python.eclass and distutils.eclass have been already
>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
>>> with internals of current code before trying to understand these minor changes.
>>> Suggestions about indentation and quoting will be rejected.
>>>
>>
>> You have been already told to get rid of all the color customizations in
>> the python eclasses here:
>>
>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
>>
>> [ .. ]
>>
>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
>>
>> The bug was wrongly closed as fixed, as it's not really fixed before
>> it's all punted
> 
> Colors can be used with echo.
> 

Stop using echo for output and switch to standard output functions, like
einfo/eerror/elog/... like told in
http://bugs.gentoo.org/show_bug.cgi?id=309057#c5

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 1573 bytes --]

2010-07-05 18:26:40 Samuli Suominen napisał(a):
> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> >>> These minor changes in python.eclass and distutils.eclass have been already
> >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> >>> with internals of current code before trying to understand these minor changes.
> >>> Suggestions about indentation and quoting will be rejected.
> >>>
> >>
> >> You have been already told to get rid of all the color customizations in
> >> the python eclasses here:
> >>
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> >>
> >> [ .. ]
> >>
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> >>
> >> The bug was wrongly closed as fixed, as it's not really fixed before
> >> it's all punted
> > 
> > Colors can be used with echo.
> > 
> 
> Stop using echo for output and switch to standard output functions, like
> einfo/eerror/elog/... like told in
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5

You should read relevant part of comment #7:
"The colors can of course be continued to be used in outputs that are purely build
time outputting and not for communicating things for users like what cmake builds do."

python.eclass uses colors for build time outputting, which doesn't communicate anything for users.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Tomáš Chvátal]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> 2010-07-05 18:26:40 Samuli Suominen napisał(a):
>> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>> 2010-07-05 18:13:26 Samuli Suominen napisał(a):
>>>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>>>> These minor changes in python.eclass and distutils.eclass have been already
>>>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
>>>>> with internals of current code before trying to understand these minor changes.
>>>>> Suggestions about indentation and quoting will be rejected.
>>>>>
>>>>
>>>> You have been already told to get rid of all the color customizations in
>>>> the python eclasses here:
>>>>
>>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
>>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
>>>>
>>>> [ .. ]
>>>>
>>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
>>>>
>>>> The bug was wrongly closed as fixed, as it's not really fixed before
>>>> it's all punted
>>>
>>> Colors can be used with echo.
>>>
>>
>> Stop using echo for output and switch to standard output functions, like
>> einfo/eerror/elog/... like told in
>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> 
> You should read relevant part of comment #7:
> "The colors can of course be continued to be used in outputs that are purely build
> time outputting and not for communicating things for users like what cmake builds do."
> 
> python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> 
+	echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
+	echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
NEED_PYTHON variable.${_NORMAL}"
+	echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
report a bug, if it has not been already reported.${_NORMAL}"

The above is build outputting since when?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwyCfkACgkQHB6c3gNBRYd2yQCgrpR4HKMnCIqyRbN9eAomZwRK
b8oAnjBW16mkxb7B5hpbqZXN5IQ4W4oy
=xV10
-----END PGP SIGNATURE-----

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

On Mon, 5 Jul 2010 18:34:38 +0200
Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> wrote:
> You should read relevant part of comment #7:
> "The colors can of course be continued to be used in outputs that are
> purely build time outputting and not for communicating things for
> users like what cmake builds do."
> 
> python.eclass uses colors for build time outputting, which doesn't
> communicate anything for users.

Well stop it. You're cluttering up your eclass with pointless junk
under the mistaken impression that more complicated eclasses are
better. If you have a desperate need for a coloured output that isn't
doable using the existing e* functions, make your case for either a new
EAPI or for a special, dedicated eclass.

Besides, if you're not communicating anything for users, why have it
there?

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 2428 bytes --]

2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> > 2010-07-05 18:26:40 Samuli Suominen napisał(a):
> >> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> >>> 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> >>>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> >>>>> These minor changes in python.eclass and distutils.eclass have been already
> >>>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> >>>>> with internals of current code before trying to understand these minor changes.
> >>>>> Suggestions about indentation and quoting will be rejected.
> >>>>>
> >>>>
> >>>> You have been already told to get rid of all the color customizations in
> >>>> the python eclasses here:
> >>>>
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> >>>>
> >>>> [ .. ]
> >>>>
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> >>>>
> >>>> The bug was wrongly closed as fixed, as it's not really fixed before
> >>>> it's all punted
> >>>
> >>> Colors can be used with echo.
> >>>
> >>
> >> Stop using echo for output and switch to standard output functions, like
> >> einfo/eerror/elog/... like told in
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> >
> > You should read relevant part of comment #7:
> > "The colors can of course be continued to be used in outputs that are purely build
> > time outputting and not for communicating things for users like what cmake builds do."
> >
> > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> >
> +	echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
> variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
> +	echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
> NEED_PYTHON variable.${_NORMAL}"
> +	echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
> report a bug, if it has not been already reported.${_NORMAL}"
> 
> The above is build outputting since when?

The colored, non-logged output in deprecation warnings is used as exception to increase
the chance that ebuild maintainers will be notified earlier about the necessity of changes
in given ebuilds.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 476 bytes --]

2010-07-05 18:37:37 Ciaran McCreesh napisał(a):
> You're cluttering up your eclass with pointless junk
> under the mistaken impression that more complicated eclasses are
> better.

These eclasses don't contain any unnecessary code (except deprecated functions/variables).

> Besides, if you're not communicating anything for users, why have it
> there?

The colored output is intended and useful for ebuild maintainers.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Harald van Dijk]

On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> > Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> > >
> > +	echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
> > variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
> > +	echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
> > NEED_PYTHON variable.${_NORMAL}"
> > +	echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
> > report a bug, if it has not been already reported.${_NORMAL}"
> > 
> > The above is build outputting since when?
> 
> The colored, non-logged output in deprecation warnings is used as exception to increase
> the chance that ebuild maintainers will be notified earlier about the necessity of changes
> in given ebuilds.

einfo/ewarn/eerror output is repeated by default when emerge exits. By
not using einfo/ewarn/eerror, you are making it less likely that others
will be reading your deprecation notices.

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Harald van Dijk]

On Mon, Jul 05, 2010 at 07:38:32PM +0200, Harald van Dijk wrote:
> On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> > > Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> > > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> > > >
> > > +	echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
> > > variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
> > > +	echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
> > > NEED_PYTHON variable.${_NORMAL}"
> > > +	echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
> > > report a bug, if it has not been already reported.${_NORMAL}"
> > > 
> > > The above is build outputting since when?
> > 
> > The colored, non-logged output in deprecation warnings is used as exception to increase
> > the chance that ebuild maintainers will be notified earlier about the necessity of changes
> > in given ebuilds.
> 
> einfo/ewarn/eerror output is repeated by default when emerge exits. By
> not using einfo/ewarn/eerror, you are making it less likely that others
> will be reading your deprecation notices.

Ugh. I see that you're using einfo already and suppressing its output.
In that case, my objection doesn't apply, but it's still nasty.

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

El lun, 05-07-2010 a las 19:38 +0200, Harald van Dijk escribió:
> On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> > > Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> > > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> > > >
> > > +	echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
> > > variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
> > > +	echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
> > > NEED_PYTHON variable.${_NORMAL}"
> > > +	echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
> > > report a bug, if it has not been already reported.${_NORMAL}"
> > > 
> > > The above is build outputting since when?
> > 
> > The colored, non-logged output in deprecation warnings is used as exception to increase
> > the chance that ebuild maintainers will be notified earlier about the necessity of changes
> > in given ebuilds.
> 
> einfo/ewarn/eerror output is repeated by default when emerge exits. By
> not using einfo/ewarn/eerror, you are making it less likely that others
> will be reading your deprecation notices.
> 

I fully agree with this, I think that using ewarn would be much more
useful for all of us

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Mark Loeser]

[-- Attachment #1: Type: text/plain, Size: 2342 bytes --]

Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> 2010-07-05 18:26:40 Samuli Suominen napisał(a):
> > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > >>> These minor changes in python.eclass and distutils.eclass have been already
> > >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > >>> with internals of current code before trying to understand these minor changes.
> > >>> Suggestions about indentation and quoting will be rejected.
> > >>>
> > >>
> > >> You have been already told to get rid of all the color customizations in
> > >> the python eclasses here:
> > >>
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> > >>
> > >> [ .. ]
> > >>
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> > >>
> > >> The bug was wrongly closed as fixed, as it's not really fixed before
> > >> it's all punted
> > > 
> > > Colors can be used with echo.
> > > 
> > 
> > Stop using echo for output and switch to standard output functions, like
> > einfo/eerror/elog/... like told in
> > http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> 
> You should read relevant part of comment #7:
> "The colors can of course be continued to be used in outputs that are purely build
> time outputting and not for communicating things for users like what cmake builds do."
> 
> python.eclass uses colors for build time outputting, which doesn't communicate anything for users.

Everyone else has already made valid points.  I'm just picking this one
to reply to now.  Please remove the colors you have added.  If you need
a new function, say "eqawarn", we should have that added in the next
EAPI with a description of when and where to use it.  In the meantime,
Petteri proposed a nice solution awhile back that would centralize this
so it is not a one-off hack.  Here is a link to his original proposal:

http://archives.gentoo.org/gentoo-dev/msg_44d395a1b887468051a1e1c049e99ba3.xml

Thanks,

-- 
Mark Loeser
email         -   halcy0n AT gentoo DOT org
email         -   mark AT halcy0n DOT com
web           -   http://www.halcy0n.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

On 07/05/2010 08:55 PM, Pacho Ramos wrote:
> El lun, 05-07-2010 a las 19:38 +0200, Harald van Dijk escribió:
>> On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
>>> 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
>>>> Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
>>>>> python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
>>>>>
>>>> +	echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
>>>> variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
>>>> +	echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
>>>> NEED_PYTHON variable.${_NORMAL}"
>>>> +	echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
>>>> report a bug, if it has not been already reported.${_NORMAL}"
>>>>
>>>> The above is build outputting since when?
>>>
>>> The colored, non-logged output in deprecation warnings is used as exception to increase
>>> the chance that ebuild maintainers will be notified earlier about the necessity of changes
>>> in given ebuilds.
>>
>> einfo/ewarn/eerror output is repeated by default when emerge exits. By
>> not using einfo/ewarn/eerror, you are making it less likely that others
>> will be reading your deprecation notices.
>>
> 
> I fully agree with this, I think that using ewarn would be much more
> useful for all of us

We should not be spamming our users with deprecation notices. ewarn is
for messages that users should take action for. People can for example
have configured to receive email on these messages.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> These minor changes in python.eclass and distutils.eclass have been already
> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> with internals of current code before trying to understand these minor changes.

If you are looking for review on gentoo-dev you should include something
on what the patch is supposed to do.

> Suggestions about indentation and quoting will be rejected.
> 

Do you think our indentation rules don't concern you? In general the
email reads like you are not really looking for feedback on the patch so
why bother gentoo-dev at all?

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 2256 bytes --]

2010-07-05 20:00:11 Mark Loeser napisał(a):
> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> > 2010-07-05 18:26:40 Samuli Suominen napisał(a):
> > > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > > 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> > > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > >>> These minor changes in python.eclass and distutils.eclass have been already
> > > >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > > >>> with internals of current code before trying to understand these minor changes.
> > > >>> Suggestions about indentation and quoting will be rejected.
> > > >>>
> > > >>
> > > >> You have been already told to get rid of all the color customizations in
> > > >> the python eclasses here:
> > > >>
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> > > >>
> > > >> [ .. ]
> > > >>
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> > > >>
> > > >> The bug was wrongly closed as fixed, as it's not really fixed before
> > > >> it's all punted
> > > > 
> > > > Colors can be used with echo.
> > > > 
> > > 
> > > Stop using echo for output and switch to standard output functions, like
> > > einfo/eerror/elog/... like told in
> > > http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> > 
> > You should read relevant part of comment #7:
> > "The colors can of course be continued to be used in outputs that are purely build
> > time outputting and not for communicating things for users like what cmake builds do."
> > 
> > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> 
> Everyone else has already made valid points.  I'm just picking this one
> to reply to now.  Please remove the colors you have added.  If you need
> a new function, say "eqawarn", we should have that added in the next
> EAPI with a description of when and where to use it.

In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
then its output wouldn't be logged by Portage.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Mark Loeser]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> 2010-07-05 20:00:11 Mark Loeser napisał(a):
> > Everyone else has already made valid points.  I'm just picking this one
> > to reply to now.  Please remove the colors you have added.  If you need
> > a new function, say "eqawarn", we should have that added in the next
> > EAPI with a description of when and where to use it.
> 
> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
> then its output wouldn't be logged by Portage.

I don't understand what you are trying to say.  The QA team has decided
that the coloring should be removed from the python eclass and a
centralized generic solution should be proposed and agreed upon.

Thanks,

-- 
Mark Loeser
email         -   halcy0n AT gentoo DOT org
email         -   mark AT halcy0n DOT com
web           -   http://www.halcy0n.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Alex Alexander]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

On Mon, Jul 05, 2010 at 05:23:58PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> These minor changes in python.eclass and distutils.eclass have been already
> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> with internals of current code before trying to understand these minor changes.
> Suggestions about indentation and quoting will be rejected.


I don't understand. eclass patches are supposed to be sent to -dev as
RFCs, not as "hey, I did this, but if you want to comment, don't, I
don't care".

You should welcome critisism, your fellow devs want whats best for
Gentoo, they are not after you :)

Truth is, all that weird coloring is messing up the eclass. At the very
least you could have defined your own epinfo function or something to
cover it up. Or pushed for Peterri's eqawarn solution.

> -- 
> Arfrever Frehtes Taifersar Arahesis

-- 
Alex Alexander :: wired
Gentoo Developer
www.linuxized.com

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 1470 bytes --]

2010-07-05 20:26:19 Petteri Räty napisał(a):
> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > These minor changes in python.eclass and distutils.eclass have been already
> > reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > with internals of current code before trying to understand these minor changes.
> 
> If you are looking for review on gentoo-dev you should include something
> on what the patch is supposed to do.

In python.eclass:
 - Deprecation of NEED_PYTHON variable
 - Deletion of colors from 3 deprecated functions and some cleanup in these functions
 - Improvements in error messages, sanity checks and handling of arguments
 - First part of support for API of python.eclass in EAPI="4".
 - Some new, optional features in some functions (e.g. --base-path option in some python_get_*() functions)
 - Support for multiple paths in argument of --PYTHONPATH option of test helper functions

In distutils.eclass:
 - Support for custom setup files specified in DISTUTILS_SETUP_FILES array
 - Deletion of colors from 2 deprecated functions and some cleanup in thse functions

> > Suggestions about indentation and quoting will be rejected.
> 
> Do you think our indentation rules don't concern you?

I don't use indentation/quoting, which would violate any rules, but some people
might try to enforce e.g. EAPI=3 instead of EAPI="3". 

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

On 07/05/2010 10:59 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> 
> I don't use indentation/quoting, which would violate any rules, but some people
> might try to enforce e.g. EAPI=3 instead of EAPI="3". 
> 

You are implying you would never screw up accidentally.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 804 bytes --]

2010-07-05 21:18:57 Mark Loeser napisał(a):
> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> > 2010-07-05 20:00:11 Mark Loeser napisał(a):
> > > Everyone else has already made valid points.  I'm just picking this one
> > > to reply to now.  Please remove the colors you have added.  If you need
> > > a new function, say "eqawarn", we should have that added in the next
> > > EAPI with a description of when and where to use it.
> > 
> > In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
> > then its output wouldn't be logged by Portage.
> 
> I don't understand what you are trying to say.

Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Samuli Suominen]

On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 21:18:57 Mark Loeser napisał(a):
>> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
>>> 2010-07-05 20:00:11 Mark Loeser napisał(a):
>>>> Everyone else has already made valid points.  I'm just picking this one
>>>> to reply to now.  Please remove the colors you have added.  If you need
>>>> a new function, say "eqawarn", we should have that added in the next
>>>> EAPI with a description of when and where to use it.
>>>
>>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
>>> then its output wouldn't be logged by Portage.
>>
>> I don't understand what you are trying to say.
> 
> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope.
> 

Can you point to the location of python.eclass / distutils.eclass where
you need to send output from global scope, please?

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 1167 bytes --]

2010-07-05 23:28:01 Samuli Suominen napisał(a):
> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 21:18:57 Mark Loeser napisał(a):
> >> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> >>> 2010-07-05 20:00:11 Mark Loeser napisał(a):
> >>>> Everyone else has already made valid points.  I'm just picking this one
> >>>> to reply to now.  Please remove the colors you have added.  If you need
> >>>> a new function, say "eqawarn", we should have that added in the next
> >>>> EAPI with a description of when and where to use it.
> >>>
> >>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
> >>> then its output wouldn't be logged by Portage.
> >>
> >> I don't understand what you are trying to say.
> > 
> > Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope.
> 
> Can you point to the location of python.eclass / distutils.eclass where
> you need to send output from global scope, please?

It's at the beginning of this patch. NEED_PYTHON is parsed in global scope.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Samuli Suominen]

On 07/06/2010 12:38 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 23:28:01 Samuli Suominen napisał(a):
>> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>> 2010-07-05 21:18:57 Mark Loeser napisał(a):
>>>> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
>>>>> 2010-07-05 20:00:11 Mark Loeser napisał(a):
>>>>>> Everyone else has already made valid points.  I'm just picking this one
>>>>>> to reply to now.  Please remove the colors you have added.  If you need
>>>>>> a new function, say "eqawarn", we should have that added in the next
>>>>>> EAPI with a description of when and where to use it.
>>>>>
>>>>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
>>>>> then its output wouldn't be logged by Portage.
>>>>
>>>> I don't understand what you are trying to say.
>>>
>>> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope.
>>
>> Can you point to the location of python.eclass / distutils.eclass where
>> you need to send output from global scope, please?
> 
> It's at the beginning of this patch. NEED_PYTHON is parsed in global scope.
> 

OK, so let me get this right... are trying to justify using all of the
echo+custom colorization in the eclass by this one occurance, in basis
of it doesn't get logged otherwise?

Seems a bit far fetch. Also I'm not convinced if it's beneficial to log
this.

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 2056 bytes --]

2010-07-05 23:49:58 Samuli Suominen napisał(a):
> On 07/06/2010 12:38 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 23:28:01 Samuli Suominen napisał(a):
> >> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> >>> 2010-07-05 21:18:57 Mark Loeser napisał(a):
> >>>> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> >>>>> 2010-07-05 20:00:11 Mark Loeser napisał(a):
> >>>>>> Everyone else has already made valid points.  I'm just picking this one
> >>>>>> to reply to now.  Please remove the colors you have added.  If you need
> >>>>>> a new function, say "eqawarn", we should have that added in the next
> >>>>>> EAPI with a description of when and where to use it.
> >>>>>
> >>>>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
> >>>>> then its output wouldn't be logged by Portage.
> >>>>
> >>>> I don't understand what you are trying to say.
> >>>
> >>> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope.
> >>
> >> Can you point to the location of python.eclass / distutils.eclass where
> >> you need to send output from global scope, please?
> > 
> > It's at the beginning of this patch. NEED_PYTHON is parsed in global scope.
> > 
> 
> OK, so let me get this right... are trying to justify using all of the
> echo+custom colorization in the eclass by this one occurance, in basis
> of it doesn't get logged otherwise?

I was justifying using colors in this case (NEED_PYTHON). I'm completely against not using colors
in status messages (e.g. "Building of dev-python/setuptools-0.6.13 with CPython 3.1..."), which
are more useful, when they are easily noticeable by ebuild maintainers. I might agree to remove
colors in other deprecation warnings, but this patch wasn't adding any other deprecation warnings.
Not using colors in deprecation warnings doesn't have any benefits and only decreases noticeability
of deprecation warnings.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 1155 bytes --]

On Monday, July 05, 2010 16:23:50 Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 21:18:57 Mark Loeser napisał(a):
> > Arfrever Frehtes Taifersar Arahesis said:
> > > 2010-07-05 20:00:11 Mark Loeser napisał(a):
> > > > Everyone else has already made valid points.  I'm just picking this
> > > > one to reply to now.  Please remove the colors you have added.  If
> > > > you need a new function, say "eqawarn", we should have that added in
> > > > the next EAPI with a description of when and where to use it.
> > > 
> > > In case of the colored message added in this patch, if
> > > einfo/elog/ewarn/eqawarn/eerror was used, then its output wouldn't be
> > > logged by Portage.
> > 
> > I don't understand what you are trying to say.
> 
> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in
> global scope.

dont call it in global scope then.  the more parsing you do in global scope 
the worse you make performance for the tree.  these things get executed during 
dependency generation which means it gets spammed even when not emerging.

use pkg_setup or something similar like everyone else.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Jorge Manuel B. S. Vicetto]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05-07-2010 15:23, Arfrever Frehtes Taifersar Arahesis wrote:
> These minor changes in python.eclass and distutils.eclass have been already
> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> with internals of current code before trying to understand these minor changes.
> Suggestions about indentation and quoting will be rejected.

Arfrever,

I'm not going to delve into the details that have been addressed all
other this thread. Instead I'll just address one small issue.
The use of *minor* in the title of this thread and the sheer size of the
patch attached are not compatible. Please don't label changes such as
these as *minor* in future instances.


- -- 
Regards,

Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org
Gentoo- forums / Userrel / Devrel / KDE / Elections
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJMMmHQAAoJEC8ZTXQF1qEPzG4P/RMaVOxp/cCTq5Y5RZQq0IIE
t6nh8AJGl0nJyjDi4LtpI2A1BpC2m0EcekDmYLkQouo9+IRwIrbawI4N8MQFAiZC
Nj/yideygJMFYE7o6RiIxZ3HtCxhoV0uY48c0azxehwVBykrLKx2GNLLvmveqGcj
85saWl0awP9/KktYYUt+EHTBsTmJCmQX9493pxWUrMczFrz+eyDMjgDc9La77SuU
u3JEFLLmvHtLgY8rAoSm3zDulxsc+fmdWTsS1/36Ko+StAQLMDz1OGUEsokQPSMB
IeouOKxHGIlefaAYhrqtIni+M9hkxFRLS46zmcrD9J36SYcPrD0XagWtEdb31+Ar
PPssQJnUz4FaVXd4rLVhBdOc2FpZR1VqaMK2wVhYKm1aq+We68LGxEd5JU0PCPJT
Y9Do3YfolXyfsF/zDkmuq0v2613i7APqVrmfK3kMHn0u8Ytma1JdLD/KzF/AOwTM
WCoH5Q5os59oN0gpbYUx1EHzIq0qfY6IslZLu/cedN6hM9QK+TOWzks2bqa888iI
J6h9kd20FcfddAbbBIfhe0jSk1kRxVYV7RLfvsBZ2FB7PeIKqli+wDBUOj36FmU3
i+W5v5Uu134Dpdn+pevtFeDZsu4bmXrkasg8HvlH7J2oquCu2Egb88ST0dQEB08Z
lNYugouUn/oPIrgk76t5
=qBaG
-----END PGP SIGNATURE-----

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Jeroen Roovers]

On Mon, 05 Jul 2010 22:50:56 +0000
"Jorge Manuel B. S. Vicetto" <jmbsvicetto@gentoo.org> wrote:

> I'm not going to delve into the details that have been addressed all
> other this thread. Instead I'll just address one small issue.
> The use of *minor* in the title of this thread and the sheer size of
> the patch attached are not compatible. Please don't label changes
> such as these as *minor* in future instances.

Another major flaw on its own is the sheer size of the patch (it hadn't
been explicitly mentioned to my knowledge). Aren't we supposed to
commit early and often in open source projects instead of dumping all
your changes on reviewers at once (first fork and later merge)? And if
you're still going to do it, a the huge patch should only be necessary
to establish a single sweeping change, not many small changes.


     jer

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 1695 bytes --]

2010-07-06 00:29:09 Mike Frysinger napisał(a):
> On Monday, July 05, 2010 16:23:50 Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 21:18:57 Mark Loeser napisał(a):
> > > Arfrever Frehtes Taifersar Arahesis said:
> > > > 2010-07-05 20:00:11 Mark Loeser napisał(a):
> > > > > Everyone else has already made valid points.  I'm just picking this
> > > > > one to reply to now.  Please remove the colors you have added.  If
> > > > > you need a new function, say "eqawarn", we should have that added in
> > > > > the next EAPI with a description of when and where to use it.
> > > > 
> > > > In case of the colored message added in this patch, if
> > > > einfo/elog/ewarn/eqawarn/eerror was used, then its output wouldn't be
> > > > logged by Portage.
> > > 
> > > I don't understand what you are trying to say.
> > 
> > Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in
> > global scope.
> 
> dont call it in global scope then.  the more parsing you do in global scope 
> the worse you make performance for the tree.  these things get executed during 
> dependency generation which means it gets spammed even when not emerging.
> 
> use pkg_setup or something similar like everyone else.

Only 84 ebuilds in the tree set NEED_PYTHON variable. NEED_PYTHON can be used only in EAPI <=2.
python_pkg_setup() is optional in EAPI <=3. Exactly 0 ebuilds, which use NEED_PYTHON, also call
python_pkg_setup(). EXPORT_FUNCTIONS wasn't ommitted during this calculation.

There are over 27000 ebuilds in the tree. Performance penalty from <=84 ebuilds shouldn't be
noticeable during `emerge --regen`.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 856 bytes --]

On Monday, July 05, 2010 19:31:59 Arfrever Frehtes Taifersar Arahesis wrote:
> Only 84 ebuilds in the tree set NEED_PYTHON variable. NEED_PYTHON can be
> used only in EAPI <=2. python_pkg_setup() is optional in EAPI <=3. Exactly
> 0 ebuilds, which use NEED_PYTHON, also call python_pkg_setup().
> EXPORT_FUNCTIONS wasn't ommitted during this calculation.

well then, it shouldnt be hard for you to fix that small number and drop this 
crap from the tree.

your global scope echo still doesnt require color support.  everyone is 
telling you for obvious reasons to stop doing this.  so do it already.

> There are over 27000 ebuilds in the tree. Performance penalty from <=84
> ebuilds shouldn't be noticeable during `emerge --regen`.

your few ebuilds and my few ebuilds and that guys few ebuilds and ...  see how 
it all adds up ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

On 07/06/2010 02:18 AM, Jeroen Roovers wrote:
> On Mon, 05 Jul 2010 22:50:56 +0000
> "Jorge Manuel B. S. Vicetto" <jmbsvicetto@gentoo.org> wrote:
> 
>> I'm not going to delve into the details that have been addressed all
>> other this thread. Instead I'll just address one small issue.
>> The use of *minor* in the title of this thread and the sheer size of
>> the patch attached are not compatible. Please don't label changes
>> such as these as *minor* in future instances.
> 
> Another major flaw on its own is the sheer size of the patch (it hadn't
> been explicitly mentioned to my knowledge). Aren't we supposed to
> commit early and often in open source projects instead of dumping all
> your changes on reviewers at once (first fork and later merge)? And if
> you're still going to do it, a the huge patch should only be necessary
> to establish a single sweeping change, not many small changes.
> 

Indeed the patch should be splitted if you expect people to reasonably
review it.

Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]

Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: Text/Plain, Size: 886 bytes --]

2010-07-06 01:37:01 Mike Frysinger napisał(a):
> On Monday, July 05, 2010 19:31:59 Arfrever Frehtes Taifersar Arahesis wrote:
> > Only 84 ebuilds in the tree set NEED_PYTHON variable. NEED_PYTHON can be
> > used only in EAPI <=2. python_pkg_setup() is optional in EAPI <=3. Exactly
> > 0 ebuilds, which use NEED_PYTHON, also call python_pkg_setup().
> > EXPORT_FUNCTIONS wasn't ommitted during this calculation.
> 
> well then, it shouldnt be hard for you to fix that small number and drop this 
> crap from the tree.
> 
> your global scope echo still doesnt require color support.  everyone is 
> telling you for obvious reasons to stop doing this.  so do it already.

NEED_PYTHON has been removed from all ebuilds in gentoo-x86, so now there shouldn't be any
problems with printing this deprecation warning in global scope.

-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]