From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OTfzR-0000F1-Uk for garchives@archives.gentoo.org; Tue, 29 Jun 2010 18:57:03 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D6795E0CEA; Tue, 29 Jun 2010 18:56:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id DF0EBE0B35 for ; Tue, 29 Jun 2010 18:56:48 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7C01B1B4091; Tue, 29 Jun 2010 18:56:44 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: Sergei Trofimovich Subject: Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2) Date: Tue, 29 Jun 2010 14:55:52 -0400 User-Agent: KMail/1.13.1 (Linux/2.6.34; KDE/4.4.4; x86_64; ; ) Cc: gentoo-dev@lists.gentoo.org, bronksos@gmail.com References: <20100628212745.3b6248a9@mosly> <201006290224.14248.vapier@gentoo.org> <20100629195753.63ca786a@mosly> In-Reply-To: <20100629195753.63ca786a@mosly> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2569007.YQ943ydTHg"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201006291455.53671.vapier@gentoo.org> X-Archives-Salt: ba8b190a-cc1c-429a-8eb1-2724be4fd5c1 X-Archives-Hash: de1d8aa66de50f5c2555cf47d1ec8caf --nextPart2569007.YQ943ydTHg Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable > return 0 nowhere do you check the return value of xmms2_flag, so not much point in=20 returning a value (also, the eerror path no longer returns 1) > ${CHOST:+--with-target-platform=3D${CHOST}} \ CHOST is guaranteed to always be set, so no need for the ${VAR:+} magic > for option in "${option_map[@]}"; do > for plugin in "${plugin_map[@]}"; do you didnt declare option/plugin local anywhere that i can see =2Dmike --nextPart2569007.YQ943ydTHg Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMKkG5AAoJEEFjO5/oN/WBoPYP/0g0NA170YH99hxttG+DC3oJ eY9aWjZsXobxirpDn1Ik+pSgWK9RE/OZpC1Jg11rj5vqtUyiYLzlxi8ZinWb5znK NsoPuY8IgG2/xX75CqQgUzAPdE6txWaB5YSeEXXz/tUtQD8VAKeAWskZbf/rum0p WN7LaxvvtZMjPB9ZNDW8xLgoRpl0QGgDwyd8n+RvWznXpjiQu1v241aD3bsE34oe qxui99zn+WrGw+e6kD1alv9o7iEZpe0H1NKlDY+Bc4a/L2f05FntHl441FtB/LEc 6iqbXGIG+qUq+hGIOOA5LHLBVU2R+X0AHMQrFlGtEMK7VMeqsOVH8ho1ypZ3Egmf 0XNaTKAtsDo8HNL+LqM67a4RBMZOKDXRMCqRhF3OnxoAc7C6vvI55Ro4rv/t5xFm tnQnSxDLbztY61a701ZkHMcsufWg8sXKjalaExL92WdXWhGl992ihVOqQBDBO20e KxA5728vArP1C8RbdpjxJk/l59mMlts2/likrLko0oPz6OMY4GpitR7vjNBU0tXD BjZWLsaPxfkn7KL97vUgYHu99bGVH3iKZ/qCEofmz2+THzOU1ZjrXqZRSQMLTwL0 NCKISSxlvkf0EwZhKG2QX7UgJAHcztyUSccaYPvr94LjZ77HzNqNmCb9hralqkxl 86UJ9qrcixb1YV6x2yl6 =1S9H -----END PGP SIGNATURE----- --nextPart2569007.YQ943ydTHg--