From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OTUGA-0007ph-9j for garchives@archives.gentoo.org; Tue, 29 Jun 2010 06:25:30 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0121DE0B64; Tue, 29 Jun 2010 06:25:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 3364EE0B2E for ; Tue, 29 Jun 2010 06:25:11 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id F36321B401D; Tue, 29 Jun 2010 06:25:04 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild Date: Tue, 29 Jun 2010 02:24:13 -0400 User-Agent: KMail/1.13.1 (Linux/2.6.34; KDE/4.4.4; x86_64; ; ) Cc: Sergei Trofimovich References: <20100628212745.3b6248a9@mosly> In-Reply-To: <20100628212745.3b6248a9@mosly> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1457873.LLg4sH6RSa"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201006290224.14248.vapier@gentoo.org> X-Archives-Salt: 9d5dd2a3-a43a-4d35-b9fe-836496dd0441 X-Archives-Hash: 5d5f013db0a3b97e0bf2c80392f9fe12 --nextPart1457873.LLg4sH6RSa Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit > if [[ -z "$1" ]]; then either lose the quotes or lose the double brackets. hint: the former. > echo "!!! xmms2_flag() called without a parameter." >&2 > echo "!!! xmms2_flag() []" >&2 use eerror or die > if use "$1"; then USE flag cannot contain spaces or anything else that requires quoting > else > : # nothing is generated > fi my, we sure do like to be verbose > --destdir="${D}" \ you need to give the DESTDIR to configure ? no wonder xmms2 sucks > ${CTARGET:+--with-target-platform=${CTARGET}} \ i highly suspect this isnt what you think it is. if this option is for cross- compiling, then use ${CHOST}. > optionals+="$(xmms2_flag $option)" dont need the quoting when doing ...=$(...) > "${S}"/waf the default dir for most src_* funcs is $S, so just use ./waf > use python && python_mod_optimize $(python_get_sitedir)/xmmsclient shouldnt sitedir be quoted ? -mike --nextPart1457873.LLg4sH6RSa Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMKZGOAAoJEEFjO5/oN/WBbFwP/0idyoBYH24bYPc5kAaSDOwr yFL6B5n+qyBk6Jlcn9GIBNJD1u+GEkCXucZ8cMXK1hnsfig4N0Uy4l1BpnkRk2aV RRNk+cPmN0+QM98o0+QUXQgxK2nR7zvEDXeA4lUpX8YS7+HE4qh7N+IAgnCTOOcB a/NWfWKzbF8WW6zk3C4bxr/vfT3RbTgwcSp9tB1/CsB4SYDOFZ06fJ9ExHASGHCY YHgabnrJOaPNjTcR5kvSGZHvZ582SyBUMg5EEXnmaB6rtYwD71YKIKvQKURaYbCe r2AstM8xTQeauThloADqvqX4tSNE/n9GTpQbcNrrJ3IdBVXBr7GFxgCoHj2C7ISI n84VLEWTmf3yw3D6coaqLGKUl428GDW94JOgeVOnFTDi2u1y84+qtmgLrmllIkMT RVvZ+K1aKSjgGitdlgyhPtNwoRzM+jDL7e3ugMCdWqSg74zziJPCjXyb0xJku5AU j2erL9pTLHNdKx7saULXcxIO8iO69BiN/a6NR3dZ3bSOkvzkxObYoasbHt0OAV83 W/5j1FB3/2eDrqxhuywyPMAdLbrrErLBcGTAC0a9lYNOArvMT7Kwe/FPrgSbYjUe IB+BgXIel5CfHkiD+bkR8DIVmQFsBiMXBxl+cAmHkmv0CuFgeZZ8RtR0adsZhXQV Jjvkh3o79mGynkMpzHt5 =M59+ -----END PGP SIGNATURE----- --nextPart1457873.LLg4sH6RSa--