From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OQoXi-00047i-9J for garchives@archives.gentoo.org; Mon, 21 Jun 2010 21:28:34 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4268DE0CEF; Mon, 21 Jun 2010 21:28:32 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id DA194E0B61 for ; Mon, 21 Jun 2010 21:28:25 +0000 (UTC) Received: from afta-gentoo.localnet (ip-85-198-235-97.broker.com.pl [85.198.235.97]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 276041B40CC for ; Mon, 21 Jun 2010 21:28:25 +0000 (UTC) From: Arfrever Frehtes Taifersar Arahesis To: Gentoo Development Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild Date: Mon, 21 Jun 2010 23:28:31 +0200 User-Agent: KMail/1.13.3 (Linux/2.6.32-tuxonice-r9-AFTA; KDE/4.4.4; x86_64; ; ) References: <20100610191934.39FEA2CAD8@corvid.gentoo.org> <201006201556.14340.Arfrever@gentoo.org> <201006201827.01782.vapier@gentoo.org> In-Reply-To: <201006201827.01782.vapier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2212807.LdRnlqqmq4"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201006212328.32986.Arfrever@gentoo.org> X-Archives-Salt: eaac4658-4e2a-4297-859e-c49be5d23a29 X-Archives-Hash: d609686327b6a361f1c33bf9259a0764 --nextPart2212807.LdRnlqqmq4 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable 2010-06-21 00:27:00 Mike Frysinger napisa=C5=82(a): > On Sunday, June 20, 2010 09:55:39 Arfrever Frehtes Taifersar Arahesis wro= te: > > 2010-06-19 22:53:37 Mike Frysinger napisa=C5=82(a): > > > On Thursday, June 10, 2010 16:45:29 Arfrever Frehtes Taifersar wrote: > > > > 2010-06-10 22:20:44 Nirbheek Chauhan napisa=C5=82(a): > > > > > On Fri, Jun 11, 2010 at 1:30 AM, Arfrever Frehtes Taifersar wrote: > > > > > > 2010-06-10 21:27:40 Jeremy Olexa napisa=C5=82(a): > > > > > >> I see no reason to *not* add a ChangeLog entry here. > > > > > >=20 > > > > > > ChangeLog entries are not required for trivial changes. > > > > >=20 > > > > > A "trivial" change is fixing a typo, or a manifest problem, a mis= sing > > > > > quotation mark, etc. Anything else is not "trivial". > > > > >=20 > > > > > Anything that changes how an ebuild functions, what it does, or t= he > > > > > installed files (and/or their contents) is NOT a trivial change. > > > >=20 > > > > This commit only removed some compiler warnings. > > >=20 > > > mucking with CFLAGS without documentation is wrong. compiler warnings > > > come and go, so a flag that was relevant one day could be completely > > > extraneous the next. > > >=20 > > > however, especially with strict aliasing, you arent "just fixing > > > warnings", you're changing optimization behavior of gcc to workaround > > > broken C code. this obviously does not fall anywhere near the "trivia= l" > > > mark. > > >=20 > > > i see you still havent fixed this, so get on it already. a bug needs= to > > > be opened somewhere to get the package properly *fixed* > >=20 > > This problem is probably caused by bugs in Python 2, which have been fi= xed > > in Python 3. >=20 > the new information you've provided here only reinforces the fact the cur= rent=20 > code is wrong. properly document the append-flags and properly restrict = it to=20 > when python-2 is being used. I have added the comment to the ebuild. dev-python/traits supports only Pyt= hon 2. > considering python-2 is going to be in our lives for a while, how hard is= it=20 > to backport the changes in question to the headers ? presumably it's=20 > struct/union/cast shuffling in the headers. I don't know what exactly would need to be backported. I suspect that Pytho= n developers would have backported the fix if it wasn't breaking backward compatibility. =2D-=20 Arfrever Frehtes Taifersar Arahesis --nextPart2212807.LdRnlqqmq4 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMH9mAAAoJEFU3/w1zlLfg3OMQAKhH5L7ZxIlPf5LYkElBQJic oSKjqNrU35gCnKKfQDtCfOnhrxvMbXBJ7geflALGabqAiAlRZH+wAiLgNKO/jhxk eZHofOahOk23iNeH9sWmFvTrARfuGQEOAunKP8hyWSLPRfDhR1vmbRtPY36SS4R5 S85UYeNPxDg5dccsoXi+Hl+mnTMQqjeurH6woeKVMIXimCpAuAx4C/8TZ1APTvno H5qgTEqvLO6ooCZFRYcJjaUl/p9omzhldKtxFFB/m7VA6gUB7cvcVGc2uTK5Izc7 tHga59QDg9VmJPpwPMbt0Hlh74rbDuVY/uCuWpL+7EExInwiIu9vth3HJAAZ4Asv 0uUMYKRDxSP9kaNK8cDiw9XqeEp5xEfMKceLEReXW9wFu/56agM1SkBqfCdDfgO0 Uc7Vp5dMSMok89pmeO2RvbY7iQ4rO8UGoM4n0Iwej6FTyDCNT6Fx0XxWLjMuSFaS NcOn0SNKug8+T0UmODTIykB1Xax7zS51FoWvHiAN42OnOdbPG2KMkD30melpMX2E gD57y4AevGXoGPCmu2jF4a94S5taxnTzpoYG55EwsTtkgPC2G2i92824B9DtLbvp 38diua/e2NC+Cts1CZicc2udvv+wWfsw4iQ18IRbG4vWSKRpjRbCF4FVer1/WtyN kiP5mGQsE151S6antayi =vv5y -----END PGP SIGNATURE----- --nextPart2212807.LdRnlqqmq4--