From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OQYEj-0007cT-EK for garchives@archives.gentoo.org; Mon, 21 Jun 2010 04:03:53 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7D156E08D3; Mon, 21 Jun 2010 04:03:47 +0000 (UTC) Received: from mail-pw0-f53.google.com (mail-pw0-f53.google.com [209.85.160.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 01D6FE08EE for ; Mon, 21 Jun 2010 04:03:27 +0000 (UTC) Received: by pwi3 with SMTP id 3so439210pwi.40 for ; Sun, 20 Jun 2010 21:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=mrwN8zWgchxOq1qnGmT7e6X3RkC+1Ph5yupCj7I4Hx8=; b=aT7lWMgpgbFyYrWl/tGXLg5hCLQFnc5FEtRCt6o/7iSyMRQsgO1KOE26ULTZeWyZ7E styCvHBZw4FxzbgpQzY27Wzzvq4/p99HYLVPmQ9fnwV69BFUWxD+FHGD680QAfaRmupO WT7eb5R4l5184iveqfvhf7erKol6TNTWU5tQc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=q/V6/me9wboBMVaP1SseAsXXx01MaCus6oXVKSXFdtk8dirZsmiv3PwuGkEtUPDKbx UTuE3QCFMMSbLnECrUNbz+bY8ZQw2zJqrT6Wk9wn603lj6fcyF3W7indzYEzZcfkkSVL CyoOO9Lp1k4Y3NarCD5lgelCLa1vARmYGZQek= Received: by 10.115.149.4 with SMTP id b4mr3358613wao.143.1277093007086; Sun, 20 Jun 2010 21:03:27 -0700 (PDT) Received: from smtp.gmail.com (c-67-171-128-62.hsd1.wa.comcast.net [67.171.128.62]) by mx.google.com with ESMTPS id a23sm14410264wam.14.2010.06.20.21.03.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 20 Jun 2010 21:03:25 -0700 (PDT) Received: by smtp.gmail.com (sSMTP sendmail emulation); Sun, 20 Jun 2010 21:01:27 -0700 Date: Sun, 20 Jun 2010 21:01:27 -0700 From: Brian Harring To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild Message-ID: <20100621040127.GN12490@hrair> References: <20100610191934.39FEA2CAD8@corvid.gentoo.org> <201006191653.38750.vapier@gentoo.org> <201006201556.14340.Arfrever@gentoo.org> <201006201827.01782.vapier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gw4vLALk08fVJy3V" Content-Disposition: inline In-Reply-To: <201006201827.01782.vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-Archives-Salt: 1e590109-dffb-406b-a935-7f9084d59f52 X-Archives-Hash: 6f5355fc40bb4d042ffb1f142b1e35a3 --gw4vLALk08fVJy3V Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 20, 2010 at 06:27:00PM -0400, Mike Frysinger wrote: > On Sunday, June 20, 2010 09:55:39 Arfrever Frehtes Taifersar Arahesis wro= te: > > 2010-06-19 22:53:37 Mike Frysinger napisa=C5=82(a): > > > On Thursday, June 10, 2010 16:45:29 Arfrever Frehtes Taifersar wrote: > > > > 2010-06-10 22:20:44 Nirbheek Chauhan napisa=C5=82(a): > > > > > On Fri, Jun 11, 2010 at 1:30 AM, Arfrever Frehtes Taifersar wrote: > > > > > > 2010-06-10 21:27:40 Jeremy Olexa napisa=C5=82(a): > > > > > >> I see no reason to *not* add a ChangeLog entry here. > > > > > >=20 > > > > > > ChangeLog entries are not required for trivial changes. > > > > >=20 > > > > > A "trivial" change is fixing a typo, or a manifest problem, a mis= sing > > > > > quotation mark, etc. Anything else is not "trivial". > > > > >=20 > > > > > Anything that changes how an ebuild functions, what it does, or t= he > > > > > installed files (and/or their contents) is NOT a trivial change. > > > >=20 > > > > This commit only removed some compiler warnings. > > >=20 > > > mucking with CFLAGS without documentation is wrong. compiler warnings > > > come and go, so a flag that was relevant one day could be completely > > > extraneous the next. > > >=20 > > > however, especially with strict aliasing, you arent "just fixing > > > warnings", you're changing optimization behavior of gcc to workaround > > > broken C code. this obviously does not fall anywhere near the "trivia= l" > > > mark. > > >=20 > > > i see you still havent fixed this, so get on it already. a bug needs= to > > > be opened somewhere to get the package properly *fixed* > >=20 > > This problem is probably caused by bugs in Python 2, which have been fi= xed > > in Python 3. >=20 > the new information you've provided here only reinforces the fact the cur= rent=20 > code is wrong. properly document the append-flags and properly restrict = it to=20 > when python-2 is being used. >=20 > considering python-2 is going to be in our lives for a while, how hard is= it=20 > to backport the changes in question to the headers ? presumably it's=20 > struct/union/cast shuffling in the headers. This is upstream python bug 969718 offhand; basically if cflags exists=20 for distutils consumers, base cflags don't make it fully through-=20 meaning no -fno-strict-aliasing as is generally needed for building=20 python extensions. As for py3k, looks of it py3.1 still suffers it. Either way, this is the wrong thing to fix- python's distutils=20 needs fixing, not consumers. In snakeoil, we detect and fix it on the=20 fly to provide a fixed version of distutils, but obviously not many=20 pkgs consume that... ~harring --gw4vLALk08fVJy3V Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iEYEARECAAYFAkwe5BcACgkQsiLx3HvNzgefvwCeKEcB0wfmxGR2hdhP8q/BCytV fSsAn1+Zs/z76nR0YxKSt/qL6zk+0pQL =/Bkt -----END PGP SIGNATURE----- --gw4vLALk08fVJy3V--