From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from <gentoo-dev+bounces-41438-garchives=archives.gentoo.org@lists.gentoo.org>) id 1OQSzE-0003LF-4r for garchives@archives.gentoo.org; Sun, 20 Jun 2010 22:27:32 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E895AE0891; Sun, 20 Jun 2010 22:27:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 3748FE0854 for <gentoo-dev@lists.gentoo.org>; Sun, 20 Jun 2010 22:27:11 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id CC7C41B4029; Sun, 20 Jun 2010 22:27:09 +0000 (UTC) From: Mike Frysinger <vapier@gentoo.org> Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild Date: Sun, 20 Jun 2010 18:27:00 -0400 User-Agent: KMail/1.13.1 (Linux/2.6.34; KDE/4.4.3; x86_64; ; ) Cc: Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> References: <20100610191934.39FEA2CAD8@corvid.gentoo.org> <201006191653.38750.vapier@gentoo.org> <201006201556.14340.Arfrever@gentoo.org> In-Reply-To: <201006201556.14340.Arfrever@gentoo.org> Precedence: bulk List-Post: <mailto:gentoo-dev@lists.gentoo.org> List-Help: <mailto:gentoo-dev+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org> X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7200973.VjJrtFPA1N"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201006201827.01782.vapier@gentoo.org> X-Archives-Salt: 8fea109e-d2ed-40a3-a034-22694e889765 X-Archives-Hash: bcad4de0525640817d2b3860a50fad4f --nextPart7200973.VjJrtFPA1N Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday, June 20, 2010 09:55:39 Arfrever Frehtes Taifersar Arahesis wrote: > 2010-06-19 22:53:37 Mike Frysinger napisa=C5=82(a): > > On Thursday, June 10, 2010 16:45:29 Arfrever Frehtes Taifersar wrote: > > > 2010-06-10 22:20:44 Nirbheek Chauhan napisa=C5=82(a): > > > > On Fri, Jun 11, 2010 at 1:30 AM, Arfrever Frehtes Taifersar wrote: > > > > > 2010-06-10 21:27:40 Jeremy Olexa napisa=C5=82(a): > > > > >> I see no reason to *not* add a ChangeLog entry here. > > > > >=20 > > > > > ChangeLog entries are not required for trivial changes. > > > >=20 > > > > A "trivial" change is fixing a typo, or a manifest problem, a missi= ng > > > > quotation mark, etc. Anything else is not "trivial". > > > >=20 > > > > Anything that changes how an ebuild functions, what it does, or the > > > > installed files (and/or their contents) is NOT a trivial change. > > >=20 > > > This commit only removed some compiler warnings. > >=20 > > mucking with CFLAGS without documentation is wrong. compiler warnings > > come and go, so a flag that was relevant one day could be completely > > extraneous the next. > >=20 > > however, especially with strict aliasing, you arent "just fixing > > warnings", you're changing optimization behavior of gcc to workaround > > broken C code. this obviously does not fall anywhere near the "trivial" > > mark. > >=20 > > i see you still havent fixed this, so get on it already. a bug needs to > > be opened somewhere to get the package properly *fixed* >=20 > This problem is probably caused by bugs in Python 2, which have been fixed > in Python 3. the new information you've provided here only reinforces the fact the curre= nt=20 code is wrong. properly document the append-flags and properly restrict it= to=20 when python-2 is being used. considering python-2 is going to be in our lives for a while, how hard is i= t=20 to backport the changes in question to the headers ? presumably it's=20 struct/union/cast shuffling in the headers. =2Dmike --nextPart7200973.VjJrtFPA1N Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMHpW1AAoJEEFjO5/oN/WBv+kP/joGGDnvwGwStmZYp6GrvekY gp7Vhd/mX1FU8Kys24B3vIk1JVd7Pr2TzwBFUIal9zW+XV2uLUaO735bxTVw6Szk 6xmBu6x8yfzwtCT+uRomjZuFdvsb8nQLOp4iCQdJf5P0jvNdp1u+zE/B6wPSFfIM j6GuR7Ey9aSfbIjTzEeHJ2ollvsT4VrBhFLIDCJQle08euMl2gSHltMuLck2ggia SL3Q18rbvqoMJ9Bmn+YGQP+F/h8mkuGfulQzuCmo7+BQ0BU4dJmzy+kkyTOD7Ixd 7LsgkOs/5+pbGgWOyiqItj+JEvbNTBjYafrCEFSzTlU4mNmr00iigX/HIUBg2s4K SM4uKa54djxNR5tER3Vjobd90fX/0DD59TJzm8Gzxg8aUl8aOIj8aaODgRJkluvh kv9d63W2rOnjr3xT2LP5DwSqklJL/pAYYrIDfq/27hQNtDq1ZLyQNOSH0sIAnriZ mJFKrSJKoHq2ewyuCcNu4BOf7vaCswtpZOcwsfcxa+HtmSnfOYFzNU1v2N0A+pYR x8bxX+8ZQOqgjftE/0wAGCexaPB2eIvks+PnYynkOsVpRP/8oxONpa7VCI2hkqm9 y4h8ZoRuC5yCTFL67ALQifi25XczVo48L5RTq8Kx4kTsFSZ+4ALQOo5jPKR3DsqQ B9Llgpy6MgqOQve/33UF =+BNw -----END PGP SIGNATURE----- --nextPart7200973.VjJrtFPA1N--