From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OQ535-0002Hy-GB for garchives@archives.gentoo.org; Sat, 19 Jun 2010 20:53:55 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B2740E0ACC; Sat, 19 Jun 2010 20:53:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id A37D1E0ABC for ; Sat, 19 Jun 2010 20:53:41 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 876081B408E; Sat, 19 Jun 2010 20:53:37 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild Date: Sat, 19 Jun 2010 16:53:37 -0400 User-Agent: KMail/1.13.1 (Linux/2.6.34; KDE/4.4.3; x86_64; ; ) Cc: Arfrever Frehtes Taifersar Arahesis References: <20100610191934.39FEA2CAD8@corvid.gentoo.org> <201006102245.30298.Arfrever@gentoo.org> In-Reply-To: <201006102245.30298.Arfrever@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4254820.vk652klHGc"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201006191653.38750.vapier@gentoo.org> X-Archives-Salt: daa26114-276c-40ab-90e9-9be769393ec6 X-Archives-Hash: ea03bb4180e689a210788d9eaea59ab7 --nextPart4254820.vk652klHGc Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thursday, June 10, 2010 16:45:29 Arfrever Frehtes Taifersar Arahesis wro= te: > 2010-06-10 22:20:44 Nirbheek Chauhan napisa=C5=82(a): > > On Fri, Jun 11, 2010 at 1:30 AM, Arfrever Frehtes Taifersar wrote: > > > 2010-06-10 21:27:40 Jeremy Olexa napisa=C5=82(a): > > >> I see no reason to *not* add a ChangeLog entry here. > > >=20 > > > ChangeLog entries are not required for trivial changes. > >=20 > > A "trivial" change is fixing a typo, or a manifest problem, a missing > > quotation mark, etc. Anything else is not "trivial". > >=20 > > Anything that changes how an ebuild functions, what it does, or the > > installed files (and/or their contents) is NOT a trivial change. >=20 > This commit only removed some compiler warnings. mucking with CFLAGS without documentation is wrong. compiler warnings come= =20 and go, so a flag that was relevant one day could be completely extraneous = the=20 next. however, especially with strict aliasing, you arent "just fixing warnings",= =20 you're changing optimization behavior of gcc to workaround broken C code. = =20 this obviously does not fall anywhere near the "trivial" mark. i see you still havent fixed this, so get on it already. a bug needs to be= =20 opened somewhere to get the package properly *fixed*, and your change eithe= r=20 out right reverted or add a comment around the flag to indicate the open bu= g=20 on the issue. append-flags ... #12345 =2Dmike --nextPart4254820.vk652klHGc Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMHS5SAAoJEEFjO5/oN/WBQk0P/1qRUahpBmTQcl5pCTUurJ4d Vgzw/7HOOKra4o/VDuKvvmIhjIiCJndumQNyFJ/JpZxINMhlaJL9JmU20YWOT5OK 3rPUpR0IwtqWcyVdA+lqKCpuFcH3UyjgRH97sQWipT7KCQBJVCdX3IddmrAnmwvp n+GWqDRXT/yO6lGGLR+uhfJLN05Q4bVOHaHSgdzj/xLC1vu5c+ud9Kh4/6mphX09 2f3dUDUkKHpmn9VY4WuBETXZ74X2hyWTs2D+bt9fa9lA26+pRVyDy5/j0r1pgfUB SE2QMArO4Oi8raBeWMspFShB7jDvBQ26+T6bIzbxsB4QFg8IsxbYOONsX7ZWRU2u pSrdreqClcrKXdwfhsPRAXjiKdYvIM0DTdt2n3O48YYHZxNegPA7wjKWBqfO3Orl abdpkSvDfPwVUpqe/0mYwztOkRoN16cjHSrPVW9lT+WI7AOq3W+thRwIZDCt4qzQ jEDnQV/7KNcwDrrCFf00St4gJhSgybAAm2vLZfskby6lOmZtcgJaxGMpc0q78bY4 4tl/KERc0x4op0fsRfAx6hppov0Pb7/Lv5/cE+wwJqJTWFYxQr2XjU4PnDADSWKE vh7Gg2iqyrUNnrx2YHjd5gUF9OVRAVFJjhYVMOShFNzmWi9MIxjJiP95dWChiUFP /mgR8GtknegA/qVlyuv4 =K+G6 -----END PGP SIGNATURE----- --nextPart4254820.vk652klHGc--