From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OMzqS-0002T1-Uj for garchives@archives.gentoo.org; Fri, 11 Jun 2010 08:44:09 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B5D36E0AF9; Fri, 11 Jun 2010 08:44:07 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id CB71CE0AEF for ; Fri, 11 Jun 2010 08:44:00 +0000 (UTC) Received: from portable.localnet (agw-sparknet.utu.fi [130.232.202.233]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 544C91B400C for ; Fri, 11 Jun 2010 08:44:00 +0000 (UTC) From: Alexis Ballier Organization: LIF To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild Date: Fri, 11 Jun 2010 11:43:52 +0300 User-Agent: KMail/1.13.3 (Linux/2.6.34; KDE/4.4.4; x86_64; ; ) References: <20100610191934.39FEA2CAD8@corvid.gentoo.org> <201006102245.30298.Arfrever@gentoo.org> In-Reply-To: <201006102245.30298.Arfrever@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2575925.zHjeDAcgXD"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201006111143.53158.aballier@gentoo.org> X-Archives-Salt: a9d58831-63c3-4fe9-89a2-77221ea16e93 X-Archives-Hash: 6cbe5a2c5bb109f08bc43c79025aa047 --nextPart2575925.zHjeDAcgXD Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable On Thursday 10 June 2010 23:45:29 Arfrever Frehtes Taifersar Arahesis wrote: [...] > This commit only removed some compiler warnings. This adds a cflag preventing the compiler to make some assumptions on the c= ode=20 for its optimisations, hence making the code slower/bigger. While the=20 changelog entry will help figuring out why this was added, a comment in the= =20 ebuild explaining why will be even better. Once you'll have to dig into 4 years of cvs log to figure out wth a cflag=20 filtering/addition was added into an ebuild maybe you'll reconsider your=20 opinion. Please always keep in mind that you're not the only one that will ever comm= it=20 to $package and even less the only one that will have a look at a given=20 ebuild. A. --nextPart2575925.zHjeDAcgXD Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iEYEABECAAYFAkwR90kACgkQvFcC4BYPU0oH3QCgnDKXedgCUgaU2lbxMdsnOpIf B9AAoI7wntvjW4KUD2LLSPgKhbjOvStM =z21t -----END PGP SIGNATURE----- --nextPart2575925.zHjeDAcgXD--