From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1OGyut-0008Qq-Q0 for garchives@archives.gentoo.org; Tue, 25 May 2010 18:31:52 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9A02FE0A91; Tue, 25 May 2010 18:31:49 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id AC807E0A76 for ; Tue, 25 May 2010 18:31:44 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 419B61B407F; Tue, 25 May 2010 18:31:44 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [Survey || RFC] autotools-utils.eclass Date: Tue, 25 May 2010 14:31:33 -0400 User-Agent: KMail/1.13.1 (Linux/2.6.34; KDE/4.4.3; x86_64; ; ) Cc: Maciej Mrozowski References: <201005251302.56615.reavertm@gmail.com> In-Reply-To: <201005251302.56615.reavertm@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart57950941.Drzyd1eesV"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201005251431.34053.vapier@gentoo.org> X-Archives-Salt: 24cabd58-3616-47e1-ab7c-094d1a2036da X-Archives-Hash: ad8f5b78f5b163527ffbeda27711d3bf --nextPart57950941.Drzyd1eesV Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable internal functions should not be documented with the eclass doc comments=20 (_check_build_dir) reusing a PM variable (ECONF_SOURCE) seems a little iffy the library handling is incorrect. i dont think you can pass around --enab= le- shared all the time without having configure generate warnings about unknow= n=20 options. default to --disable-static when static-libs doesnt exist is wron= g=20 =2D- that's the opposite of what you should be doing. ignoring the same is= sue=20 as the share option i mentioned above. pushd/popd should have stdout sent to /dev/null, not stderr too the src_install func has the static-libs checks in the incorrect order the src_test func looks like its copying & pasting stuff from the PM. this= =20 really should be kept in the PM without duplicating it everywhere. =2Dmike --nextPart57950941.Drzyd1eesV Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJL/BeFAAoJEEFjO5/oN/WB/2MQAIKkMBfpRXrnVM0ZMD8j4gJ0 OBo49ZMYoFJBalxMhysJyoHTUXlQh6GOslM5L02B9plwsqVNeIsF245DmAo+Zajr wbYIn3g7jR60iF1s8bYppx50aKkYOR9owcSC0x1kDGpqWGaS2gZs6BAFaGNn1eWt LMWtFMHt0zPRcNH9msAJ3bsCCzjKDE6GDy+tQfICWLZ71znfxtXS9vEj4++jhBzm p39jLK9PYbdRGgYTu8y0w8f+NGbGMhkuVbiFpkNWI5aOgULKFWDbsZ2H9Bt1RMd9 z6Tqp432v6zEM6y0o8NA0XIQwvE/12EUE6mezNYcsrbp65ZFw9+A7v7zQPD342xL RsH3Q1XgnYGt+fbblkYsdlGQrRkTqdEe7bIjFUi8MI7l2Hhrpg5HUCP29zr9yWNX qY9PPeY/m+NLn8lsgnC8SDvWzO5NiUyVRJ/7N582y1CQMqzf/Qs4jm0Tj0nYfyFJ H7QCuRQrT195spzOYCLUvKET0P/oMQvTLlUsytnopex9Jdg6WLToF1J98jWsQanZ vYSue314484N803/rJnvzplwWySnHNoeAebbvcYsC98TCVQ4ARti3cMT6QtcLSPb WD5AJpxqrULSV0B1YIEQ0K/7BhJ3xKHfsFmzv6He/uiRRBkWefHbluYxNrzOU9e8 87d32nLpgU96SZxB86Ue =7QML -----END PGP SIGNATURE----- --nextPart57950941.Drzyd1eesV--