From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1O606J-00070B-8z for garchives@archives.gentoo.org; Sun, 25 Apr 2010 11:34:16 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9C000E091A; Sun, 25 Apr 2010 11:34:12 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 8574BE0913 for ; Sun, 25 Apr 2010 11:34:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 353CB1B4026 for ; Sun, 25 Apr 2010 11:34:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at gentoo.org X-Spam-Score: -1.949 X-Spam-Level: X-Spam-Status: No, score=-1.949 required=5.5 tests=[AWL=-1.209, BAYES_20=-0.74] Received: from smtp.gentoo.org ([127.0.0.1]) by localhost (smtp.gentoo.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XUlJxQ1fZXDk for ; Sun, 25 Apr 2010 11:33:56 +0000 (UTC) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by smtp.gentoo.org (Postfix) with ESMTP id 4F8C61B4071 for ; Sun, 25 Apr 2010 11:33:55 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1O605q-0001FY-Tw for gentoo-dev@gentoo.org; Sun, 25 Apr 2010 13:33:46 +0200 Received: from s0106001f3b27cbf6.mj.shawcable.net ([70.64.215.98]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 25 Apr 2010 13:33:46 +0200 Received: from dirtyepic by s0106001f3b27cbf6.mj.shawcable.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 25 Apr 2010 13:33:46 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org connect(): No such file or directory From: Ryan Hill Subject: [gentoo-dev] Re: Requiring two sets of eyes for all eclass commits Date: Sun, 25 Apr 2010 05:36:25 -0600 Message-ID: <20100425053625.6a72ee87@gentoo.org> References: <4BD32D26.5090005@gentoo.org> <20100425040601.5dc8e5d7@gentoo.org> <4BD4153F.5000509@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/KLOcN2Tz/KECmzPE0sxpGht"; protocol="application/pgp-signature" X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: s0106001f3b27cbf6.mj.shawcable.net X-Newsreader: Claws Mail 3.7.5 (GTK+ 2.18.9; x86_64-unknown-linux-gnu) X-Archives-Salt: 6d12438e-d663-4552-bcd8-98f5d15664f2 X-Archives-Hash: 86a328810ad33108a739562c4c4ad1b2 --Sig_/KLOcN2Tz/KECmzPE0sxpGht Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, 25 Apr 2010 13:11:11 +0300 Petteri R=E4ty wrote: > On 04/25/2010 01:06 PM, Ryan Hill wrote: > > I think it's a good idea to strongly encourage it, but actually forcing= it > > through cvs? No thanks. I'm not tracking down another dev just to fix= a > > spelling mistake. :P >=20 > How did the spelling mistake get there in the first place? A review > system should reduce having them in the first place. People make mistakes. Anyways my point is that requiring a peer review for trivial changes is just unneeded bureaucracy. Even for non-trivial changes, it doesn't make sense to force someone who knows their eclass inside out and knows what they're doing to get a review from someone else who may not have= a clue. I'm not saying that peer-review shouldn't be done; it's a very good idea, especially if you're new, or unsure of your changes, or you have a te= am consisting of more than one person. In fact I would support a policy that said eclasses need to be reviewed before committing. But enforcing it thro= ugh cvs is never going to fly. Just use common sense. If we were having ongoing issues with people breaking eclasses then I could see where you're coming from. But as it is, it's a non-problem. --=20 fonts, by design, by neglect gcc-porting, for a fact or just for effect wxwidgets @ gentoo EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662 --Sig_/KLOcN2Tz/KECmzPE0sxpGht Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iEYEARECAAYFAkvUKUMACgkQiqiDRvmkBmIDYgCg1yUONz2nTGLW+KOru0mhInst lXwAoLEQO0zQn/tlQOf3RHiwc8I6GqFm =yf37 -----END PGP SIGNATURE----- --Sig_/KLOcN2Tz/KECmzPE0sxpGht--