From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1O47I1-0002Hv-Op for garchives@archives.gentoo.org; Tue, 20 Apr 2010 06:50:34 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8279EE08F7; Tue, 20 Apr 2010 06:50:27 +0000 (UTC) Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.29.7]) by pigeon.gentoo.org (Postfix) with ESMTP id F2CCFE084F for ; Tue, 20 Apr 2010 06:50:04 +0000 (UTC) Received: from [93.210.59.202] (helo=arkane.local) by smtprelay03.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1O47HX-0007AM-Kr for gentoo-dev@lists.gentoo.org; Tue, 20 Apr 2010 08:50:03 +0200 Received: by arkane.local (Postfix, from userid 1000) id 08E9C1554; Tue, 20 Apr 2010 08:49:49 +0200 (CEST) Date: Tue, 20 Apr 2010 08:49:49 +0200 From: Torsten Veller To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: perl eclass review - EAPI=3 + new helper eclass Message-ID: <20100420074544.TA09dbc.tv@veller.net> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20100330111154.GA28735@veller.net> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100330111154.GA28735@veller.net> X-Face: ===_______=8)_=8)_______A_very_very_nice_face_______=8)_=8)_______=== Jabber-ID: tove@jabber.ccc.de X-PGP-Fingerprint: 0416 3C11 8D79 65B9 AAD0 2065 BBC7 14D1 9C67 CD96 User-Agent: Mutt/1.5.20 (2010-03-22) X-Df-Sender: 1067115 X-Archives-Salt: f79c3c21-0a3b-40f4-ae99-82eaf470d6fa X-Archives-Hash: 2f4606d534c3417dfd289c062c715b1c * Torsten Veller : > The perl-module.eclass must be updated to support EAPI=3 [1] and > a new eclass will be added which does contain some (more or less) useful > stand-alone functions split from the old perl-module.eclass without > exporting phase functions. Somehow I was sleeping: It's more useful to set EXPORT_FUNCTIONS conditionally and have all functions in perl-module.eclass. I think this justifies the elimination of the perl-helper.eclass. Sorry for the confusion. Hopefully wide awake now. New perl-helper.eclass: | # Copyright 1999-2010 Gentoo Foundation | # Distributed under the terms of the GNU General Public License v2 | # $Header: $ | | # @DEAD | | PERL_EXPORT_PHASE_FUNCTIONS=no | inherit perl-module Head of new perl-module.eclass: http://git.overlays.gentoo.org/gitweb/?p=proj/perl-overlay.git;a=tree;f=eclass;hb=HEAD | @@ -12,19 +12,19 @@ | # The perl-module eclass is designed to allow easier installation of perl | # modules, and their incorporation into the Gentoo Linux system. | | -inherit perl-helper eutils base | +inherit eutils base | [[ ${CATEGORY} == "perl-core" ]] && inherit alternatives | | PERL_EXPF="src_unpack src_compile src_test src_install" | | case "${EAPI:-0}" in | 0|1) | - PERL_EXPF="${PERL_EXPF} pkg_setup pkg_preinst pkg_postinst pkg_prerm pkg_postrm" | + PERL_EXPF+=" pkg_setup pkg_preinst pkg_postinst pkg_prerm pkg_postrm" | ;; | 2|3) | - PERL_EXPF="${PERL_EXPF} src_prepare src_configure" | + PERL_EXPF+=" src_prepare src_configure" | [[ ${CATEGORY} == "perl-core" ]] && \ | - PERL_EXPF="${PERL_EXPF} pkg_postinst pkg_postrm" | + PERL_EXPF+=" pkg_postinst pkg_postrm" | | case "${GENTOO_DEPEND_ON_PERL:-yes}" in | yes) | @@ -38,7 +38,17 @@ case "${EAPI:-0}" in | ;; | esac | | -EXPORT_FUNCTIONS ${PERL_EXPF} | +case "${PERL_EXPORT_PHASE_FUNCTIONS:-yes}" in | + yes) | + EXPORT_FUNCTIONS ${PERL_EXPF} | + ;; | + no) | + debug-print "PERL_EXPORT_PHASE_FUNCTIONS=no" | + ;; | + *) | + DEPEND+=" PERL_EXPORT_PHASE_FUNCTIONS-UNSUPPORTED" | + ;; | +esac | | DESCRIPTION="Based on the $ECLASS eclass" ...