[gentoo-dev] Re: perl eclass review - EAPI=3 + new helper eclass

[Christian Faulhammer <fauli@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

Hi,

Torsten Veller <ml-en@veller.net>:
> 	find "${S}" -type f -name "._*" -print0 | while read -rd ''
> f ; do einfo "Removing AppleDouble encoded Macintosh file: ${f#${S}/}"
> 		rm -f "${f}"
> 		f=${f#${S}/}
> 	#	f=${f//\//\/}
> 	#	f=${f//\./\.}
> 	#	sed -i "/${f}/d" "${S}"/MANIFEST || die
> 		grep -q "${f}" "${S}"/MANIFEST && \
> 			elog "AppleDouble encoded Macintosh file in
> MANIFEST: ${f#${S}/}" done
> }

 Are those f= lines commented?  And what was their purpose?  Can they
be deleted?

> 	if [[ -d ${D}/${VENDOR_LIB} ]] ; then

 Haven't checked, but quotes not needed?

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://gentoo.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]