From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NxmNs-0004jB-NH for garchives@archives.gentoo.org; Fri, 02 Apr 2010 19:18:25 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0BEB3E09B9; Fri, 2 Apr 2010 19:18:21 +0000 (UTC) Received: from mail-bw0-f210.google.com (mail-bw0-f210.google.com [209.85.218.210]) by pigeon.gentoo.org (Postfix) with ESMTP id 178D9E06D6 for ; Fri, 2 Apr 2010 19:18:12 +0000 (UTC) Received: by bwz2 with SMTP id 2so1760543bwz.30 for ; Fri, 02 Apr 2010 12:18:12 -0700 (PDT) Received: by 10.204.84.142 with SMTP id j14mr795807bkl.124.1270235891394; Fri, 02 Apr 2010 12:18:11 -0700 (PDT) Received: from pomiot.lan (77-253-21-153.adsl.inetia.pl [77.253.21.153]) by mx.google.com with ESMTPS id 16sm4642503bwz.13.2010.04.02.12.18.10 (version=SSLv3 cipher=RC4-MD5); Fri, 02 Apr 2010 12:18:10 -0700 (PDT) Sender: Spam Box Date: Fri, 2 Apr 2010 21:18:00 +0200 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Unification of variables used within SCM eclasses Message-ID: <20100402211800.462f4778@pomiot.lan> In-Reply-To: <4BB63B58.8030007@gentoo.org> References: <20100324122838.0cd4e330@pomiocik> <4BB63B58.8030007@gentoo.org> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.9; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_//ZA3hF2rdwPcchAsu5YbaoU"; protocol="application/pgp-signature" X-Archives-Salt: 1f480ed4-2221-4276-9729-98b515050095 X-Archives-Hash: 5974d886e618799c7a8207c5458d56d3 --Sig_//ZA3hF2rdwPcchAsu5YbaoU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 02 Apr 2010 19:45:44 +0100 Krzysztof Pawlik wrote: > On 03/24/10 11:28, Micha=C5=82 G=C3=B3rny wrote: > > 3. ESCM_LIVE_FAIL_IF_REPO_NOT_UPDATED (similar to the one in > > git.eclass) > > - a common switch to force unpack() phase to fail if no updates > > were found during the pull/update. >=20 > What about ESCM_REVISION defaulting to empty value meaning to use > head/tip/etc revision? ESCM_* variables would rather be set on a global basis (in make.conf or calling env), not in specific ebuild. > > b) Common eclass-specific variables - these ones should allow user > > to override above variables for single SCM. > >=20 > > 1. E*_STORE_DIR (defaulting to ${ESCM_DISTDIR}/*-src) > > - already used by few eclasses, allowing user to change > > the location where SCM-specific clones are stored. >=20 > Is it really necessary? Can't we switch to one, common vcs-src/ (or > something like this) directory? I don't see any real benefits of using single directory, and we would either have to move all existing repos (which would break backwards compat and will probably have at least one serious issues) or force user to refetch all of them. Just after a month or two ago shklee had to it anyway due to changes in git.eclass. > > 2. E*_OFFLINE (defaulting to ${ESCM_OFFLINE}) > > - allowing user to override global 'offline switch'. Thus, it > > should also support setting 'false' value to enable network > > interaction for single SCM. >=20 > If there's a ESCM_OFFLINE is it necessary to copy the information > again to vcs-specific eclasses? I don't think so. In other words: I > don't think that copying variables from parent eclass to vcs-specific > one has any point. True. But this particular var is already defined in few eclasses, and I really do not want to break compat. And last of all, as I should have mentioned earlier, I would like to avoid raising a revolution. I would rather like developing some common feature list based on what eclasses currently do, and adding missing ones to particular eclasses. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_//ZA3hF2rdwPcchAsu5YbaoU Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iEYEARECAAYFAku2QvUACgkQnGSe5QXeB7uVOwCgpwbYBcFmHjo9FQsKaD6L4dLc vSYAn0RqFYx6lnCsj/PFMg50cpVeteS1 =6Njx -----END PGP SIGNATURE----- --Sig_//ZA3hF2rdwPcchAsu5YbaoU--