From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Np474-00086f-Md for garchives@archives.gentoo.org; Tue, 09 Mar 2010 18:25:03 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6786FE0991; Tue, 9 Mar 2010 18:24:58 +0000 (UTC) Received: from smtp.t-com.sk (mylady.t-com.sk [213.81.152.142]) by pigeon.gentoo.org (Postfix) with ESMTP id 835F9E08F9 for ; Tue, 9 Mar 2010 18:24:34 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-2 Received: from amit.localdomain ([unknown] [91.127.238.81]) by relay1.stonline.sk (STOnline ESMTP Server) with ESMTPA id <0KZ10034Y1SWUP00@relay1.stonline.sk> for gentoo-dev@lists.gentoo.org; Tue, 09 Mar 2010 19:24:33 +0100 (CET) Received: by amit.localdomain (Postfix, from userid 1000) id 57BBB8B791D; Tue, 09 Mar 2010 19:24:32 +0100 (CET) Date: Tue, 09 Mar 2010 19:24:32 +0100 From: =?ISO-8859-2?B?UvNiZXJ0IMhlcvJhbnNr/Q==?= To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Low hanging bug fruit patterns Message-id: <20100309192432.75f8b756@amit.kihnet.sk> In-reply-to: <20100309001718.3b2e4c0e@epia.jer-c2.orkz.net> References: <4B94CC30.6020700@gentoo.org> <20100308141330.43a77611@amit.kihnet.sk> <20100309001718.3b2e4c0e@epia.jer-c2.orkz.net> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.16.6; x86_64-pc-linux-gnu) Content-transfer-encoding: quoted-printable X-Archives-Salt: c9ba2983-af9b-4300-9fa7-427df7458237 X-Archives-Hash: 3d91f17fee570a9e022164596045a7f5 On Tue, 9 Mar 2010 00:17:18 +0100 Jeroen Roovers wrote: > On Mon, 08 Mar 2010 14:13:30 +0100 > R=F3bert =C8er=F2ansk=FD wrote: >=20 > > - Minor version bumps (After examination what upstream changed and > > after confirmation with mantainer, if any.) >=20 > The stuff you put in brackets is exactly the sort of stuff that > tends to make version bumps hard to fix. >=20 > You would first have to determine what major/minor means, on a per > package-version basis, so these aren't really as trivial to fix as > (non) package maintainer as a "minor version change" might suggest. Yes, one needs to be carefull when doing even "minor" version bump. And after examination of changes one can decide to do the bump or leave it because it looks too risky. I'm sure there are upstream releases that contains only bug fixes and it can be relatively easy determined by looking into NEWS, Changelog or similar files. After all, the examination should not exceed 1 day of effort (Sebastian wrote that it should not "take days" to fix). So if we say that 1 day is still less than "days" then I think it is plenty of time to examine upstream changes. But maybe 1 day is too much for "low hanging fruits" so let's say 2 hours is acceptable. In that time it should be possible to fully examine changes. Which means read the changelogs, do some internet search (upstream and other distros bugzillas) and even take a peek to the source code. > Also, any version bump is a splendid occasion on which to revise the > ebuild (introduce missing features, check for novel QA issues, move up > an EAPI to cut out a few build phases, review COPYING to make sure > the LICENSE variable is still OK, figure out that one slight syntax > change might serve to fix a compilation error with a > newer-toolchain-than-you-use). It still can be done at another time after bump; which is maybe even better because it could be easily distinguished whether potencial new bugs were caused by the bump or by ebuild enhancement changes. Also I think that the overall quality of a package is increased if it is "just" bumped to the new minor/bugfix upstream release and ebuild stays at the same quality level as before. Compared to staying at the older upstream version and also with the same ebuild because nobody has time to do bump with ebuild enhacement. > So I generally don't regard a version bump as a low hanging fruit, > as you might end up painfully ignoring the wasps' nest hanging > directly beside it. Cenrtailny not in general. So let's say it is low hanging fruit at which you have to stare for a while and look at it from all sides before you pick it up. ;-) Robert --=20 Robert Cernansky E-mail: hslists2@zoznam.sk Jabber: hs@jabber.sk