From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NoOHX-0005Th-JJ for garchives@archives.gentoo.org; Sun, 07 Mar 2010 21:45:03 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 48EEDE0CB3; Sun, 7 Mar 2010 21:44:58 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 8B96FE0B94 for ; Sun, 7 Mar 2010 21:44:39 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 066BD1B4008 for ; Sun, 7 Mar 2010 21:44:39 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [rfc] making autotools.eclass depends flexible Date: Sun, 7 Mar 2010 16:44:37 -0500 User-Agent: KMail/1.13.1 (Linux/2.6.32.6; KDE/4.4.1; x86_64; ; ) References: <201003051359.58724.vapier@gentoo.org> <201003071336.39657.vapier@gentoo.org> <4B93F9AD.9020907@gentoo.org> In-Reply-To: <4B93F9AD.9020907@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1303342.TiXnBTL4zU"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003071644.37504.vapier@gentoo.org> X-Archives-Salt: 24c4644a-7947-4ff8-aeb1-19be44bf72da X-Archives-Hash: 1e2f0cd2108858a40a9d6bb2e622d0e0 --nextPart1303342.TiXnBTL4zU Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 07 March 2010 14:08:29 Petteri R=C3=A4ty wrote: > On 03/07/2010 08:36 PM, Mike Frysinger wrote: > > On Sunday 07 March 2010 13:31:56 Petteri R=C3=A4ty wrote: > >> On 03/07/2010 07:42 PM, Mike Frysinger wrote: > >>> On Saturday 06 March 2010 02:11:15 Petteri R=C3=A4ty wrote: > >>>> On 03/05/2010 08:59 PM, Mike Frysinger wrote: > >>>>> sometimes i have optional patches (ignoring the "patches should > >>>>> always be applied") where autotools should be run. always > >>>>> inheriting autotools is currently annoying because it always adds > >>>>> the related dependencies. USE based inherits are obviously out. > >>>>>=20 > >>>>> so unless there's some burgeoning standard i'm not aware of, below = is > >>>>> what i have in mind. packages set AUTOTOOLS_AUTO_DEPEND to "no" > >>>>> before inheriting autotools.eclass and that allows them to put > >>>>> ${AUTOTOOLS_DEPEND} behind a USE flag in their own DEPEND string. > >>>>=20 > >>>> What we use in Java is JAVA_PKG_OPT_USE to declare what use flag the > >>>> DEPENDs should be under. This approach doesn't allow the ebuild > >>>> maintainer to forget adding the depends. > >>>=20 > >>> i'm more inclined towards Jonathan's opinion, so ive kept the proposed > >>> behavior (plus a fix from Torsten). > >>=20 > >> And what about my latest response to him? > >=20 > > considering your proposal saves ${FOO} in DEPEND, it hasnt changed my > > opinion >=20 > Why would it be better to require ebuild writers to have do it > themselves instead of the eclass automatically taking care of it? as Jonathan mentioned, it gives explicit control via multiple USE flags whi= ch=20 your way does not =2Dmike --nextPart1303342.TiXnBTL4zU Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLlB5FAAoJEEFjO5/oN/WBM7EP/2HTXcJ5KVlueifs53nFlv0B 7UW8XEYVv4JGAmlxHGthdVNOeUScl4Gso9/tjTe5MoPPQzuDFHlmu3/5A0+ZYZJ0 +e1zbdPQie9I3FaPRLUSCnb47ONOfLje+DB9irRirjGDNKsbIhvfE0vJbeGl0ed5 L47t0Vz8s1HNfTHcXDXDldI6ONlpJqz01SU2sJVY91CgHn476cDNtS2lCBnTKiHU csb7ORUhs2c63AiwlBCD059mLufp0eyC3efx53OLexj87fiWsJqvaiw8PXV8M+/7 XP01Hs5xRLBfUuVV5fAEbIOX6b8JHTMMhhrF/JaPaGHr+rVw9UeDnWnRM9nyj6b+ YNySQNlNSu0n3jJwx65uEHXNwsP+OfQFnGTU0cPd1ug11D6hMi7NetC2XnIUUYWQ h7djuZum+Nm5DWAIxYMZhyvaD5ilB9tok6zNMXVkxFE0MerrFKHsYv98fZfw3pMC oyhvdLKWdRQao7RH34UMR0PvJ169FM+bzMKp3V8oYnpxO6bMzAe3hALKLlGoMqEM kMkLEo9uUEKpNVsag207yPRA9JXcbtrbSuUizcrwZVuhiQU/U87iBh0W5CqiVCxw F2QlW6qtcLiElTz3E2aNo32B3wZhMm9ApayNVKAUYLM8017aqULOH6yg1EhJRubD Z/Fj81MExVDWuqlrM4BI =rdzU -----END PGP SIGNATURE----- --nextPart1303342.TiXnBTL4zU--