From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NoL1f-0002TY-3s for garchives@archives.gentoo.org; Sun, 07 Mar 2010 18:16:27 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 05D42E0A6E; Sun, 7 Mar 2010 18:16:25 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 3CCC4E095B for ; Sun, 7 Mar 2010 18:16:16 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id C77731B416A for ; Sun, 7 Mar 2010 18:16:15 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Changes to flag-o-matic's _filter-var Date: Sun, 7 Mar 2010 13:16:14 -0500 User-Agent: KMail/1.13.1 (Linux/2.6.32.6; KDE/4.4.1; x86_64; ; ) References: <4B858BA9.2070300@gmail.com> <201003071250.04043.vapier@gentoo.org> <4B93F78D.90300@gmail.com> In-Reply-To: <4B93F78D.90300@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4548915.zBHD7KQVKh"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003071316.14493.vapier@gentoo.org> X-Archives-Salt: 05c1a1c0-43ec-4503-ab6b-daf7b5bbf06a X-Archives-Hash: 5a8a7382280aae0ba16268fb4ae22400 --nextPart4548915.zBHD7KQVKh Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 07 March 2010 13:59:25 ChIIph wrote: > On 03/07/10 14:50, Mike Frysinger wrote: > > On Sunday 07 March 2010 12:54:34 ChIIph wrote: > >> [snip] > >> The commas are only added when there's LDFLAGS being changed. > >=20 > > you missed my point. read the whole eclass -- this function isnt only > > used on LDFLAGS. your patch opens the door to incorrectly split/mangle > > other variables. >=20 > I know, what I wanted to say is that I've tested those changes with more > than filter-ldflags funtion, and I proposed it here because it works in > every case. no, it really doesnt. it took me two seconds to put together an example wh= ere=20 your change corrupted CFLAGS. an unlikely value, but a valid value=20 nonetheless, which means your proposal is unacceptable on that merit alone. > >>> plus, there are a few other ways to trick the system. > >>>=20 > >>> my opinion is still: > >>> - bypassing the system is sometimes useful > >>> - use separate -Wl flags and things just work > >>=20 > >> Ok, but in the default profiles LDFLAGS are separated with commas, so > >> for that second opinion to be possible, I think that should be changed. > >=20 > > i really have no idea what you're talking about. no default profile us= es > > the multi-linker flag form. >=20 > grep -nR LDFLAGS /usr/portage/profiles/* > (...) > /usr/portage/profiles/default/linux/make.defaults:53:LDFLAGS=3D"-Wl,-O1" > (...) how is that relevant ? people use `filter-flags -Wl,-O1`, they dont use=20 `filter-flags -O1`. this is not multiple linker flags combined into one -W= l. =2Dmike --nextPart4548915.zBHD7KQVKh Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLk+1uAAoJEEFjO5/oN/WBcmkP/jrE+YYa7ZDHNSGb9aqt1G+0 eThXs10O6mZ5QzCdKVlcByDt67c1cLz8o9ykWYVQ2aXnyBsR/9Bic9Gg2BUVtWSf 0MVSrMDcybiQ1XqXZiGImn4YZ8EFqkVKpKCfgdUnjuvwqX6HLLrfdDawQjdCSxRk mjoEG7FwDwXO3VHLO9mlrPcBV6tfZN/ghNmY+Tfh76S2/tp1l3tdDf0HF9AleC7m 3KigtnL3QZJHcA/KqDT1mWFkHS/5sWLMz2w5gylTTNNhiyM4RtlVpr9RJefQGL6u UJgH2ml6/fdmRv1fMG0G0y20PX2+tXTwxVpM5e52fdQWyEu7KFkXsrOr44pSnBvi Z4vjgrKrKUmJu7IDVpw51Vy2f4jDeYPx1USkO/g9khJq9vWsOObw+YC76pvINM/T Kv52tqkhA9It4kdYoJJVSxfLXoOp+NrwvGZ+3BRGf1es7RIWW1exkT0gwoiRpl9W RiElpD2BJJvJgwglPZTcswUrs1VFNyfijWUmARh4w5abQtFcimb0qHs8FQArJKwI rxVPgfBKnA85Mv3AMIsOFWCQAIZK5YZD+wyi/V4iHTprP1X/KX/uOLXCGub6Aq7m g6GCC/i5JKmtam/5IoVxQEh+lXyjO5NnxfsgxjA3pzTgvzCEvpRAPHLJR0wfEPMy pcw2p1aFZKN2a8WJp9Ck =eD4/ -----END PGP SIGNATURE----- --nextPart4548915.zBHD7KQVKh--