From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NoKcH-0006ed-JK for garchives@archives.gentoo.org; Sun, 07 Mar 2010 17:50:16 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5507DE0968; Sun, 7 Mar 2010 17:50:11 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 58EBEE086A for ; Sun, 7 Mar 2010 17:50:06 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id A51121B4089; Sun, 7 Mar 2010 17:50:05 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Changes to flag-o-matic's _filter-var Date: Sun, 7 Mar 2010 12:50:03 -0500 User-Agent: KMail/1.13.1 (Linux/2.6.32.6; KDE/4.4.1; x86_64; ; ) Cc: ChIIph References: <4B858BA9.2070300@gmail.com> <201003062127.48227.vapier@gentoo.org> <4B93E85A.6030908@gmail.com> In-Reply-To: <4B93E85A.6030908@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3023174.QMWUti7reo"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003071250.04043.vapier@gentoo.org> X-Archives-Salt: d6b48382-9c40-4530-8158-7c9d66bc3e5a X-Archives-Hash: 8ef429c4b04f0142463db60eeae8591f --nextPart3023174.QMWUti7reo Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 07 March 2010 12:54:34 ChIIph wrote: > On 03/06/10 23:27, Mike Frysinger wrote: > > On Wednesday 24 February 2010 15:27:21 ChIIph wrote: > >> Here are some minor changes I'd like to propose to flag-o-matic's > >> _filter-var() to work properly with LDFLAGS. > >> Without this, things like "-Wl,-O1,--as-needed" won't be affected by a= ny > >> kind of filter since there are no spaces to separate each flag. > >>=20 > >> I don't know of any better way to do this, but here's a patch that wor= ks > >> just fine. > >=20 > > the func is used by other code where you dont want to screw with commas. >=20 > The commas are only added when there's LDFLAGS being changed. you missed my point. read the whole eclass -- this function isnt only used= on=20 LDFLAGS. your patch opens the door to incorrectly split/mangle other=20 variables. > > plus, there are a few other ways to trick the system. > >=20 > > my opinion is still: > > - bypassing the system is sometimes useful > > - use separate -Wl flags and things just work >=20 > Ok, but in the default profiles LDFLAGS are separated with commas, so > for that second opinion to be possible, I think that should be changed. i really have no idea what you're talking about. no default profile uses t= he=20 multi-linker flag form. > On the other hand, a lot of us use comma separated flags, so for all of > us filter-ldflags doesn't work, and what I've modify doesn't mess with > any of all the other function (or at least I haven't found the case in > which it does). then change your LDFLAGS > Anyway, filter-ldflags doesn't work like it is right now, I'm not saying > use _my_ code, but use whatever you think it's best to fix this. i dont see any bug so you're going to have to be more specific =2Dmike --nextPart3023174.QMWUti7reo Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLk+dLAAoJEEFjO5/oN/WBA9sP/0HmtljrORYswayPrIcPSTT2 qC1JcM2sHaD4IT6mjim3ucV2BX8JiNNWBpDcpXtbjoZfcpOfHL6QNHIuGk0MylBL 8GRNVJBJjOibcceBdhXRYMhHRiXEPULJx5e1fDLmJKrvJkMklzgYCBslWjv9ZnlU 7tCDvyz5EeC2uOIfB7O3WKUK6qb7V3idG/PAnVKbLmOWpm89rLaDYE4K96lV79/c lo9LUPTmTb0Nn4k2eNlkZIqnG1Yybhu9jDS2n8QVVP/DZTUB+WjnY4yXK2ODVnte tJtcKNBMAdVb8iVjKuHn7H+CFvt2DKLpCI8eVJ8I3aM+t6nXikHcs3RXgB8IgcW6 y1fXYrDjzZDB2pXMKNaujv4AmqFuKx8FvzgEN6CFHDW5eycFJayzaexsHC9hxhSj CaP1k4IVe7SeUHGl6AWuU3YTqKvOiQd2/aI4uoxvlSwY+1yH3dmDf6lYzx3VOg4N t0LoyvaBErOdH0jBtk/jtFgJkqM+dl9uf3DZcNN9vEcrYbwdYAgAPRLBjc51WScm 09nEAlXXDN1CVcFKOjmr+MCbtVZXtd8q1QWlrIShC3g3lh8OT7f1XbJsRMFM/RKp kq6nq8tyCqLwxFkAwo+2uZTi0DGVvSZtycn4J9da8a6MEDWqTr02I4QA7UC5izzn oRfDf/CZuS3Dq6U9KOPV =4hyj -----END PGP SIGNATURE----- --nextPart3023174.QMWUti7reo--