From: Fabian Groffen <grobian@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [RFC] Font eclass EAPI update and design
Date: Tue, 2 Feb 2010 11:50:04 +0100 [thread overview]
Message-ID: <20100202105004.GG24425@gentoo.org> (raw)
In-Reply-To: <20100202101832.GA6052@veller.net>
On 02-02-2010 11:18:32 +0100, Torsten Veller wrote:
> > # Prefix compat
> > case ${EAPI:-0} in
> > 0|1|2)
> > if ! use prefix; then
> > EPREFIX=
> > ED=${D}
> > EROOT=${ROOT}
> > [[ ${EROOT} = */ ]] || EROOT+="/"
> > fi
> > ;;
> > esac
>
> Don't we need this for every eclass using EPREFIX, ED and EROOT
> independent of EAPI?
> Can't we move this to prefix.eclass and inherit it? Or is the EPREFIX
> setting in prefix.eclass already enough?
You cannot set EROOT and ED (reliably) from prefix.eclass, unless you
wrap them in phase funcs for which ROOT and D are guaranteed to be
defined. OIW: The logic can be moved but a simple "inherit prefix"
won't be enough to use EROOT and ED.
--
Fabian Groffen
Gentoo on a different level
prev parent reply other threads:[~2010-02-02 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 10:35 [gentoo-dev] [RFC] Font eclass EAPI update and design Tomáš Chvátal
2010-02-01 13:14 ` [gentoo-dev] " Peter Volkov
2010-02-01 13:29 ` Tomáš Chvátal
2010-02-01 18:53 ` Peter Volkov
2010-02-01 22:26 ` Ryan Hill
2010-02-02 10:18 ` Torsten Veller
2010-02-02 10:30 ` Tomáš Chvátal
2010-02-02 10:50 ` Fabian Groffen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202105004.GG24425@gentoo.org \
--to=grobian@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox