From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Nc4iI-0004rX-LR for garchives@archives.gentoo.org; Mon, 01 Feb 2010 22:25:47 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A35DDE0C2D; Mon, 1 Feb 2010 22:25:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 7FF9CE0C28 for ; Mon, 1 Feb 2010 22:25:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id CF1B11B40F5 for ; Mon, 1 Feb 2010 22:25:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at gentoo.org X-Spam-Score: -3.024 X-Spam-Level: X-Spam-Status: No, score=-3.024 required=5.5 tests=[AWL=-0.425, BAYES_00=-2.599] Received: from smtp.gentoo.org ([127.0.0.1]) by localhost (smtp.gentoo.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UPpbesggJ0o4 for ; Mon, 1 Feb 2010 22:25:11 +0000 (UTC) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by smtp.gentoo.org (Postfix) with ESMTP id 2EDB91B40AB for ; Mon, 1 Feb 2010 22:25:09 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Nc4he-00028d-9E for gentoo-dev@gentoo.org; Mon, 01 Feb 2010 23:25:06 +0100 Received: from s010600240142d32f.mj.shawcable.net ([70.64.214.224]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 01 Feb 2010 23:25:06 +0100 Received: from dirtyepic by s010600240142d32f.mj.shawcable.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 01 Feb 2010 23:25:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Ryan Hill Subject: [gentoo-dev] Re: [RFC] Font eclass EAPI update and design Date: Mon, 1 Feb 2010 16:26:52 -0600 Organization: Gentoo Message-ID: <20100201162652.588d029a@gentoo.org> References: <4B66AE86.9090006@gentoo.org> <1265030081.10636.23.camel@tablet> <4B66D72F.3060303@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: s010600240142d32f.mj.shawcable.net X-Newsreader: Claws Mail 3.7.4 (GTK+ 2.18.6; x86_64-unknown-linux-gnu) Sender: news X-Archives-Salt: 65db4cf1-9e04-42ff-9d25-12c13c9a5863 X-Archives-Hash: 08d965b296bac7984a56821db0ebc86a On Mon, 01 Feb 2010 14:29:19 +0100 Tom=C3=A1=C5=A1 Chv=C3=A1tal wrote: > Dne 1.2.2010 14:14, Peter Volkov napsal(a): > > 1. > > -FONT_SUFFIX=3D${FONT_SUFFIX:-} > > +: ${FONT_SUFFIX:=3D} > >=20 > > What are the benefits of this change? Personally I prefer first syntax > > more since it's more evident and does not need to run empty command : > I am just used to this syntax. I dont think it is so huge issue that it > would need revert. No thanks. The second form is unreadable. > > 4. > > + [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation > > failed" ; } > >=20 > > This should be non fatal, until somebody installs all packages that > > inherit font.eclass and assures us that nothing broke with this change. > >=20 > Actualy former behaviour was violating QA rules for dodoc, so it should > be fixed anyway. Well then the QA rules for dodoc are dumb. :P There is no reason for an ebuild to die when a generic doc file doesn't get installed. The prefix changes are welcome assuming they've been tested. --=20 fonts, by design, by neglect gcc-porting, for a fact or just for effect wxwidgets @ gentoo EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662