From: Ryan Hill <dirtyepic@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: [RFC] Font eclass EAPI update and design
Date: Mon, 1 Feb 2010 16:26:52 -0600 [thread overview]
Message-ID: <20100201162652.588d029a@gentoo.org> (raw)
In-Reply-To: 4B66D72F.3060303@gentoo.org
On Mon, 01 Feb 2010 14:29:19 +0100
Tomáš Chvátal <scarabeus@gentoo.org> wrote:
> Dne 1.2.2010 14:14, Peter Volkov napsal(a):
> > 1.
> > -FONT_SUFFIX=${FONT_SUFFIX:-}
> > +: ${FONT_SUFFIX:=}
> >
> > What are the benefits of this change? Personally I prefer first syntax
> > more since it's more evident and does not need to run empty command :
> I am just used to this syntax. I dont think it is so huge issue that it
> would need revert.
No thanks. The second form is unreadable.
> > 4.
> > + [[ -n ${DOCS} ]] && { dodoc ${DOCS} || die "docs installation
> > failed" ; }
> >
> > This should be non fatal, until somebody installs all packages that
> > inherit font.eclass and assures us that nothing broke with this change.
> >
> Actualy former behaviour was violating QA rules for dodoc, so it should
> be fixed anyway.
Well then the QA rules for dodoc are dumb. :P There is no reason for an
ebuild to die when a generic doc file doesn't get installed.
The prefix changes are welcome assuming they've been tested.
--
fonts, by design, by neglect
gcc-porting, for a fact or just for effect
wxwidgets @ gentoo EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662
next prev parent reply other threads:[~2010-02-01 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 10:35 [gentoo-dev] [RFC] Font eclass EAPI update and design Tomáš Chvátal
2010-02-01 13:14 ` [gentoo-dev] " Peter Volkov
2010-02-01 13:29 ` Tomáš Chvátal
2010-02-01 18:53 ` Peter Volkov
2010-02-01 22:26 ` Ryan Hill [this message]
2010-02-02 10:18 ` Torsten Veller
2010-02-02 10:30 ` Tomáš Chvátal
2010-02-02 10:50 ` Fabian Groffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201162652.588d029a@gentoo.org \
--to=dirtyepic@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox