From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NRLR6-0006Yl-Na for garchives@archives.gentoo.org; Sun, 03 Jan 2010 08:03:42 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5329AE0824 for ; Sun, 3 Jan 2010 08:03:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id A8F25E055B for ; Sun, 3 Jan 2010 06:22:43 +0000 (UTC) Received: from gentoo.org (cp237988-a.mill1.nb.home.nl [84.26.213.160]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id ACC4067F3B for ; Sun, 3 Jan 2010 06:22:42 +0000 (UTC) Date: Sun, 3 Jan 2010 07:23:07 +0100 From: Harald van =?utf-8?Q?D=C4=B3k?= To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [RFC] base.eclass Message-ID: <20100103062307.GA13558@boostbox> References: <4B3F6BB5.1030703@gentoo.org> <4B3FF949.40901@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4B3FF949.40901@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 51799827-41ac-444e-93aa-7375ec989caf X-Archives-Hash: 3ab07c9d121dd0900414ebebafad4b67 On Sun, Jan 03, 2010 at 02:56:01AM +0100, Tom=C3=A1=C5=A1 Chv=C3=A1tal wr= ote: > Dne 3.1.2010 01:56, Mark Bateman napsal(a): > > There seems to be alot of unquoted variables > >=20 > > 65 base_src_util $@ > This is not problem Only because you can be sure there will be exactly one word in the result, which will not be split. In general, $@ should be quoted, and it would be a good idea to either do it here too even though it's not strictly necessary, or make the intent clearer and just write base_src_util $1 > > 90 case $1 in > Yarp this is problem and fixed That's not a problem. A case expression is another example where quoting is unnecessary; there won't be any word splitting on $1 anyway. > > 95 [[ ! -z "${A}" ]] && unpack ${A} > ${A} is not used quoted :] Right, that doesn't need quoting, and it would even be okay to drop the unnecessary quotes in [[.