Re: [gentoo-dev] Re: [RFC] base.eclass

["Harald van Dijk" <truedfx@gentoo.org>]

On Sun, Jan 03, 2010 at 02:56:01AM +0100, Tomáš Chvátal wrote:
> Dne 3.1.2010 01:56, Mark Bateman napsal(a):
> > There seems to be alot of unquoted variables
> > 
> > 65                 base_src_util $@
> This is not problem

Only because you can be sure there will be exactly one word in the
result, which will not be split. In general, $@ should be quoted, and it
would be a good idea to either do it here too even though it's not
strictly necessary, or make the intent clearer and just write

  base_src_util $1

> > 90                 case $1 in
> Yarp this is problem and fixed

That's not a problem. A case expression is another example where quoting
is unnecessary; there won't be any word splitting on $1 anyway.

> > 95                                 [[ ! -z "${A}" ]] && unpack ${A}
> ${A} is not used quoted :]

Right, that doesn't need quoting, and it would even be okay to drop the
unnecessary quotes in [[.