From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NPYxW-0005VS-Vq for garchives@archives.gentoo.org; Tue, 29 Dec 2009 10:05:50 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8C466E09B2 for ; Tue, 29 Dec 2009 10:05:46 +0000 (UTC) Received: from mo-p05-ob.rzone.de (mo-p05-ob.rzone.de [81.169.146.181]) by pigeon.gentoo.org (Postfix) with ESMTP id 67EEAE07FD for ; Tue, 29 Dec 2009 08:55:23 +0000 (UTC) X-RZG-AUTH: :K2kKYU+nW/MMMlTokcN5Yot1/Bj/FTl+WviP6RIJci0HRMpbh/x+X6ShOQ7VOjs5giuSCsp0nhiC X-RZG-CLASS-ID: mo05 Received: from localhost ([82.113.121.222]) by post.strato.de (mrclete mo44) (RZmta 22.5) with ESMTP id j04bb1lBT7hT2H for ; Tue, 29 Dec 2009 09:55:19 +0100 (MET) Date: Tue, 29 Dec 2009 09:54:58 +0100 From: Christian Faulhammer To: Gentoo Development Subject: [gentoo-dev] Re: Major changes to gdesklets.eclass Message-ID: <20091229095458.456afc15@gentoo.org> In-Reply-To: <4B29A0E4.4040608@gentoo.org> References: <4B29A0E4.4040608@gentoo.org> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/FQL6ZAgiwx8__u7o92fz2CI"; protocol="application/pgp-signature" X-Archives-Salt: b8497988-9b84-47a4-b9f9-9fecd968cd16 X-Archives-Hash: afbbf58a9e7ccb7fd1c9ec6f48efcd8f --Sig_/FQL6ZAgiwx8__u7o92fz2CI Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Joe Sapp : > Anyways, a diff would be useless so I've attached the proposed eclass > [2]. Looks fine so far. What puzzled me is the documentation of the SLOT variable. What is the motivation to do so? * Sometimes you give a default on undefined ROOT variable, sometimes not. Please make it consistent for cosmetic reasons. * addwrite "${ROOT}/root/.gnome2": Is this unconditionally necessary? Or could a "boolean" in the ebuild be set to activate it? * DISPLAY variable export could be done with the assignment. Or is the export always needed? * Is the file name LICENSE always used for the license or is COPYING for example also possible? * einfo "Installing Control ${CTRL_DIRNAME}": Is not mirrored in the desklet branch of the if clause. V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/FQL6ZAgiwx8__u7o92fz2CI Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) iEYEARECAAYFAks5w+gACgkQNQqtfCuFneP9zACeJJtRJGhLvkAqTRwnGZtmoLMk S8wAnjeDdkX4ksaGNVApOdzYuBB4VMqV =CkPc -----END PGP SIGNATURE----- --Sig_/FQL6ZAgiwx8__u7o92fz2CI--