From: Ryan Hill <dirtyepic@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/abiword: abiword-2.4.6.ebuild
Date: Fri, 18 Dec 2009 19:24:25 -0600 [thread overview]
Message-ID: <20091218192425.537b136f@gentoo.org> (raw)
In-Reply-To: 1261049430.17782.1.camel@gdartigu.lan.rep.sj
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Thu, 17 Dec 2009 12:30:30 +0100
Gilles Dartiguelongue <eva@gentoo.org> wrote:
> > diff -u -r1.15 -r1.16
> > --- abiword-2.4.6.ebuild 4 Jan 2009 22:51:26 -0000 1.15
> > +++ abiword-2.4.6.ebuild 17 Dec 2009 10:54:05 -0000 1.16
> [...]
> > @@ -65,12 +65,12 @@
> >
> > src_install() {
> > dodir /usr/{bin,lib}
> > - make DESTDIR="${D}" icondir="/usr/share/pixmaps" install || die "install failed"
> > + emake DESTDIR="${D}" icondir="/usr/share/pixmaps" install || die "install failed"
>
> I see no bug report about checking this actually works and making the
> fix. Please warn people before using your QA hat for doing things like
> this.
You want a bug report every time someone changes make to emake?!
If emake doesn't work, comment it. Otherwise this is the type of thing that
anyone touching an ebuild should and will fix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2009-12-19 1:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1NLDzh-0003RM-Qc@stork.gentoo.org>
2009-12-17 11:30 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/abiword: abiword-2.4.6.ebuild Gilles Dartiguelongue
2009-12-19 1:24 ` Ryan Hill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218192425.537b136f@gentoo.org \
--to=dirtyepic@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox