From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NIj5s-0000NS-HK for garchives@archives.gentoo.org; Thu, 10 Dec 2009 13:30:08 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9094AE0790; Thu, 10 Dec 2009 13:28:12 +0000 (UTC) Received: from mo-p05-ob.rzone.de (mo-p05-ob.rzone.de [81.169.146.181]) by pigeon.gentoo.org (Postfix) with ESMTP id 16B57E0790; Thu, 10 Dec 2009 13:28:11 +0000 (UTC) X-RZG-AUTH: :K2kKYU+nW/MMMlTokcN5Yot1/Bj/FTl+WviP6RIJci0HRMpbh/x+X6ShOQvVOj8z7U+h3vxOqQ== X-RZG-CLASS-ID: mo05 Received: from localhost (p579F06ED.dip.t-dialin.net [87.159.6.237]) by post.strato.de (fruni mo53) (RZmta 22.5) with ESMTP id 2026d4lBADAOpM ; Thu, 10 Dec 2009 14:28:03 +0100 (MET) Date: Thu, 10 Dec 2009 14:28:02 +0100 From: Christian Faulhammer To: Martin von Gagern Cc: gentoo-dev@lists.gentoo.org, gentoo-java@lists.gentoo.org, Andrey Kislyuk Subject: [gentoo-dev] Re: Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass Message-ID: <20091210142802.2e2229eb@gentoo.org> In-Reply-To: <4B1E294B.70906@gmx.net> References: <17e1a1290911170922q7a27b7b3t55aeca55397401ea@mail.gmail.com> <17e1a1290911180459j2c458e7bleb8c2727b1f9a321@mail.gmail.com> <20091118193748.3d80c4f3@gentoo.org> <4B1E294B.70906@gmx.net> Organization: Gentoo X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/mQF.gKR6EzU8jYAakxjj60Q"; protocol="application/pgp-signature" X-Archives-Salt: dc19fedb-078e-4bb9-bb4b-2c10de0c793d X-Archives-Hash: 6bc8b19e5b0c4e34e7e9152a667cf2ef --Sig_/mQF.gKR6EzU8jYAakxjj60Q Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Martin von Gagern : > Christian Faulhammer wrote: > > java-pkg-simple: > > In my eyes, defining all local variables at the beginning of a > > function makes it easier to read. >=20 > Sorry, Fauli, i totally missed your mail as it was only addressed to > gentoo-dev, while I've been intently watching gentoo-java... I am not subscribed to that list, so my mail would not get through. > To sum things up: yes, I could change the local declarations, but I'd > rather keep things as they are, unless you object more vehemently. No problem, it was a matter of style. V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/mQF.gKR6EzU8jYAakxjj60Q Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) iEYEARECAAYFAksg92IACgkQNQqtfCuFneOfnQCfd8nplJ9VnbybZ0K9w/H+iac5 XJEAnRVvEUVGC1SKf4t4l6sFCdsKR7mw =pIQq -----END PGP SIGNATURE----- --Sig_/mQF.gKR6EzU8jYAakxjj60Q--