From: Christian Faulhammer <fauli@gentoo.org>
To: Martin von Gagern <Martin.vGagern@gmx.net>
Cc: gentoo-dev@lists.gentoo.org, gentoo-java@lists.gentoo.org,
Andrey Kislyuk <weaver@gentoo.org>
Subject: [gentoo-dev] Re: Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass
Date: Thu, 10 Dec 2009 14:28:02 +0100 [thread overview]
Message-ID: <20091210142802.2e2229eb@gentoo.org> (raw)
In-Reply-To: <4B1E294B.70906@gmx.net>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
Hi,
Martin von Gagern <Martin.vGagern@gmx.net>:
> Christian Faulhammer wrote:
> > java-pkg-simple:
> > In my eyes, defining all local variables at the beginning of a
> > function makes it easier to read.
>
> Sorry, Fauli, i totally missed your mail as it was only addressed to
> gentoo-dev, while I've been intently watching gentoo-java...
I am not subscribed to that list, so my mail would not get through.
> To sum things up: yes, I could change the local declarations, but I'd
> rather keep things as they are, unless you object more vehemently.
No problem, it was a matter of style.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
<URL:http://gentoo.faulhammer.org/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2009-12-10 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <17e1a1290911170922q7a27b7b3t55aeca55397401ea@mail.gmail.com>
2009-11-18 12:59 ` [gentoo-dev] Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass Andrey Kislyuk
2009-11-18 18:37 ` [gentoo-dev] " Christian Faulhammer
[not found] ` <4B1E294B.70906@gmx.net>
2009-12-10 13:28 ` Christian Faulhammer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210142802.2e2229eb@gentoo.org \
--to=fauli@gentoo.org \
--cc=Martin.vGagern@gmx.net \
--cc=gentoo-dev@lists.gentoo.org \
--cc=gentoo-java@lists.gentoo.org \
--cc=weaver@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox