From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NDamM-00008l-0G for garchives@archives.gentoo.org; Thu, 26 Nov 2009 09:36:46 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1D275E08E2; Thu, 26 Nov 2009 09:36:20 +0000 (UTC) Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.31.26]) by pigeon.gentoo.org (Postfix) with ESMTP id CD254E08E2 for ; Thu, 26 Nov 2009 09:36:19 +0000 (UTC) Received: from [93.210.45.252] (helo=arkane.local) by smtprelay03.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1NDalu-00008d-H8; Thu, 26 Nov 2009 10:36:18 +0100 Received: by arkane.local (Postfix, from userid 1000) id 24B8564054; Thu, 26 Nov 2009 10:35:48 +0100 (CET) Date: Thu, 26 Nov 2009 10:35:48 +0100 From: Torsten Veller To: gentoo-dev@lists.gentoo.org, lavajoe@gentoo.org Cc: stuart@hickinbottom.com Subject: [gentoo-dev] Re: gentoo-x86 commit in media-sound/squeezeboxserver: ChangeLog squeezeboxserver-7.4.1.ebuild metadata.xml Message-ID: <20091126092958.TAa5856.tv@veller.net> Mail-Followup-To: gentoo-dev@lists.gentoo.org, lavajoe@gentoo.org, stuart@hickinbottom.com References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Face: ===_______=8)_=8)_______A_very_very_nice_face_______=8)_=8)_______=== Jabber-ID: tove@jabber.ccc.de X-PGP-Fingerprint: 0416 3C11 8D79 65B9 AAD0 2065 BBC7 14D1 9C67 CD96 User-Agent: Mutt/1.5.20 (2009-08-27) X-Df-Sender: 1067115 X-Archives-Salt: 757fc23f-5264-48e3-bc1f-96e0deeb23b6 X-Archives-Hash: ea8714f6466ecf6bc162dda79c97c595 * "Joe Peterson (lavajoe)" : > 1.1 media-sound/squeezeboxserver/squeezeboxserver-7.4.1.ebuild > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-sound/squeezeboxserver/squeezeboxserver-7.4.1.ebuild?rev=1.1&view=markup > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-sound/squeezeboxserver/squeezeboxserver-7.4.1.ebuild?rev=1.1&content-type=text/plain > > Index: squeezeboxserver-7.4.1.ebuild > =================================================================== > RDEPEND=" > >=dev-perl/Class-XSAccessor-1.03 > >=dev-perl/Class-XSAccessor-Array-1.04 Class-XSAccessor-Array was merge in dev-perl/Class-XSAccessor-1.05 (#275520) Please depend on ">=dev-perl/Class-XSAccessor-1.05" and drop -Array. > " > # Selected contents of SqueezeCenter's local CPAN collection that we include > # in the installation. This removes duplication of CPAN modules. (See Gentoo > # bug #251494). Hm, I've added a bunch of these modules as requested in https://bugs.gentoo.org/showdependencytree.cgi?id=251494 Why don't you use them now? > CPANKEEP=" > Class/XSAccessor/Array.pm > > JSON/XS/VersionOneAndTwo.pm > Class/Accessor/ > Class/Accessor.pm > MRO/Compat.pm > Algorithm/C3.pm > Data/ > DBIx/ > File/BOM.pm > Net/UPnP/ > Net/UPnP.pm > Proc/Background/ > Proc/Background.pm > Text/Unidecode/ > Text/Unidecode.pm > Tie/Cache/LRU/ > Tie/Cache/LRU.pm > Tie/LLHash.pm > Tie/RegexpHash.pm > UUID/Tiny.pm > URI/Find.pm > PAR/ > PAR.pm > enum.pm > " > LIBDIR="/usr/lib/squeezeboxserver" get_libdir ? > pkg_setup() { > # Sox has optional OGG and FLAC support, so make sure it has that included > # if required > if use ogg; then > if ! built_with_use media-sound/sox ogg; then > eerror "media-sound/sox not built with USE=ogg" > die "Squeezebox Server needs media-sound/sox to be built with USE=ogg" > fi > fi > if use flac; then > if ! built_with_use media-sound/sox flac; then > eerror "media-sound/sox not built with USE=flac" > die "Squeezebox Server needs media-sound/sox to be built with USE=flac" > fi > fi Use EAPI=2 and "USE Dependencies" > src_install() { > # The main Perl executables > exeinto /usr/sbin > newexe slimserver.pl squeezeboxserver > newexe scanner.pl squeezeboxserver-scanner > newexe cleanup.pl squeezeboxserver-cleanup || die > # Get the Perl package name and version > eval `perl '-V:package'` > eval `perl '-V:version'` > > # The custom OS module for Gentoo - provides OS-specific path details > cp "${FILESDIR}/gentoo-filepaths.pm" "Slim/Utils/OS/Custom.pm" || die "Unable to install Gentoo custom OS module" > > # The server Perl modules > dodir "/usr/lib/${package}/vendor_perl/${version}" > cp -r Slim "${D}/usr/lib/${package}/vendor_perl/${version}" || die "Unable to install server Perl modules" You can make use of: perl -V:installvendorlib > # Compiled CPAN module go under lib as they are arch-specific > dodir "/usr/lib/squeezeboxserver/CPAN" > cp -r CPAN/arch "${D}/usr/lib/squeezeboxserver/CPAN" || die "Unable to install compiled CPAN modules" > > # Preseve some of the Squeezebox Server-packaged CPAN modules that Gentoo > # doesn't provide ebuilds for. > for ITEM in ${CPANKEEP}; do > dodir "/usr/share/squeezeboxserver/CPAN/$(dirname ${ITEM})" > cp -r "CPAN/${ITEM}" "${D}/usr/share/squeezeboxserver/CPAN/${ITEM}" || die "Unable to preserve CPAN item ${ITEM}" > done For CPANKEEP, see above. > # Install preferences > insinto "${PREFSDIR}" > if [ ! -f "${PREFSDIR}/squeezeboxserver.prefs" ]; then This test in src_test is wrong. > newins "${FILESDIR}/squeezeboxserver.prefs" squeezeboxserver.prefs > fi > fowners squeezeboxserver:squeezeboxserver "${PREFSDIR}" > fperms 770 "${PREFSDIR}" > pkg_postinst() { > # Album art requires PNG and JPEG support from GD, so if it's not there > # then warn the user. It's not mandatory as the user may not be using > # album art. > if ! built_with_use dev-perl/GD jpeg || \ > ! built_with_use dev-perl/GD png || \ > ! built_with_use media-libs/gd jpeg || \ > ! built_with_use media-libs/gd png; then EAPI=2 and "if ! has_version dev-perl/GD[jpeg] || \ ..." is prefered. Regards