From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NApQQ-0002mw-8H for garchives@archives.gentoo.org; Wed, 18 Nov 2009 18:38:42 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4527BE086B; Wed, 18 Nov 2009 18:37:50 +0000 (UTC) Received: from mo-p05-ob.rzone.de (mo-p05-ob.rzone.de [81.169.146.181]) by pigeon.gentoo.org (Postfix) with ESMTP id EAB77E086B for ; Wed, 18 Nov 2009 18:37:49 +0000 (UTC) X-RZG-AUTH: :K2kKYU+nW/MMMlTokcN5Yot1/Bj/FTl+WviP6RIJci0HRMpbh/x+X6ShOQvVOj8z7Ui7wv5Ixkg= X-RZG-CLASS-ID: mo05 Received: from localhost (p579F0E70.dip.t-dialin.net [87.159.14.112]) by post.strato.de (mrclete mo10) (RZmta 22.2) with ESMTP id 9005felAIHcxCN for ; Wed, 18 Nov 2009 19:37:48 +0100 (MET) Date: Wed, 18 Nov 2009 19:37:48 +0100 From: Christian Faulhammer To: Gentoo Development Subject: [gentoo-dev] Re: Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass Message-ID: <20091118193748.3d80c4f3@gentoo.org> In-Reply-To: <17e1a1290911180459j2c458e7bleb8c2727b1f9a321@mail.gmail.com> References: <17e1a1290911170922q7a27b7b3t55aeca55397401ea@mail.gmail.com> <17e1a1290911180459j2c458e7bleb8c2727b1f9a321@mail.gmail.com> Organization: Gentoo X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/+BGnqNAoIscAtRs+iFa=2QB"; protocol="application/pgp-signature" X-Archives-Salt: 6ec3cafd-2d54-42c4-861b-d497e4a53096 X-Archives-Hash: 84127dc70904ed4d4b4b0e654410125e --Sig_/+BGnqNAoIscAtRs+iFa=2QB Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Andrey Kislyuk : > ... and let's say after 30 days from this email pending resolution of > any complaints mvg and I will push these to main tree. You should review your docstrings. Some of them contain overlong sentences, which are hard to grasp. java-pkg-simple: In my eyes, defining all local variables at the beginning of a function makes it easier to read. V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/+BGnqNAoIscAtRs+iFa=2QB Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) iEYEARECAAYFAksEPvwACgkQNQqtfCuFneNAOACfXJUXw+DSncCRWrndSshtAaLB AG4An2nS2/Txx7SGiwgfg/bYITNC8WmV =jiXQ -----END PGP SIGNATURE----- --Sig_/+BGnqNAoIscAtRs+iFa=2QB--