From: Christian Faulhammer <fauli@gentoo.org>
To: Gentoo Development <gentoo-dev@lists.gentoo.org>
Subject: [gentoo-dev] Re: Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass
Date: Wed, 18 Nov 2009 19:37:48 +0100 [thread overview]
Message-ID: <20091118193748.3d80c4f3@gentoo.org> (raw)
In-Reply-To: <17e1a1290911180459j2c458e7bleb8c2727b1f9a321@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
Hi,
Andrey Kislyuk <weaver@gentoo.org>:
> ... and let's say after 30 days from this email pending resolution of
> any complaints mvg and I will push these to main tree.
You should review your docstrings. Some of them contain overlong
sentences, which are hard to grasp.
java-pkg-simple:
In my eyes, defining all local variables at the beginning of a function
makes it easier to read.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
<URL:http://gentoo.faulhammer.org/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-11-18 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <17e1a1290911170922q7a27b7b3t55aeca55397401ea@mail.gmail.com>
2009-11-18 12:59 ` [gentoo-dev] Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass Andrey Kislyuk
2009-11-18 18:37 ` Christian Faulhammer [this message]
[not found] ` <4B1E294B.70906@gmx.net>
2009-12-10 13:28 ` [gentoo-dev] " Christian Faulhammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118193748.3d80c4f3@gentoo.org \
--to=fauli@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox