public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Brian Harring <ferringb@gmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] eapi files and profiles
Date: Fri, 23 Oct 2009 14:04:25 -0700	[thread overview]
Message-ID: <20091023210425.GA7171@hrair> (raw)
In-Reply-To: <4AE1683B.7090106@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 2294 bytes --]

On Fri, Oct 23, 2009 at 11:24:27AM +0300, Samuli Suominen wrote:
> So I was told Council needs to approve inheritance of eapi files from
> parent profiles?
> 
> I'm not sure why, because we shouldn't have any files in default/linux/
> which was decided long ago when the new profiles was introduced...
> 
> gentoo-x86/profiles/default/linux $ find ./ -name eapi | wc -l
> 63
> 
> That's 63 duplicated files. We should only have one releases/10.0/eapi
> file, and others wouldn't be required as it would cover all the 10.0
> profiles.
> 
> See, http://bugs.gentoo.org/288320
> 
> Can we get a decision on this soon, so we can drop the duplication for
> 10.1 (or whatever the name for next profile set will be called) ?

This is going to break compatibility for pkgcore at least- we limit 
what forms of atoms are allowed dependant on the eapi of that profile 
node.  I'd hope paludis does the same- I know portage doesn't however.

Further... the more I think about this, the more I'm inclined to think 
this will blow someones foot off.  If the eapi is inherited from the 
parent, what happens when the parent switches to an EAPI that changes 
the atom parsing rules?  Specifically, *restricts* the atom parsing 
rules?

Say that we got rid of the ~ operator w/in EAPI4.  '~' is completely 
valid in the default EAPI=0; if the parent profile switches to EAPI4, 
it suddenly breaks parsing of any defaulted EAPI that used revision 
matching.

So... inheritance sucks.  It gets worse when you have user 
configuration (custom profiles) inheriting from gentoo-x86 provided 
profiles- I'd expect user config to use things that are more cutting 
edge.

Alternative approach- the default EAPI currently is 0, and isn't 
overridable.  Add a file into the base of the profile directory that 
specifies the default EAPI.

Via that, you can do your file optimizations- if the majority of 
profile nodes are eapi=2, then you set the default to 2 and update the 
nodes that were reliant on the previous default.

Note this still requires having this change sit in the tree for a 
while for compatibilty reasons- but it is a good idea regardless to 
avoid requiring EAPI to be specified for every single profile node 
when we've hit EAPI=7....

~harring

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

      parent reply	other threads:[~2009-10-23 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23  8:24 [gentoo-dev] eapi files and profiles Samuli Suominen
2009-10-23 10:20 ` Ulrich Mueller
2009-10-23 20:26   ` Petteri Räty
2009-10-23 20:32     ` Ciaran McCreesh
2009-10-23 20:37 ` Ciaran McCreesh
2009-10-23 21:04 ` Brian Harring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091023210425.GA7171@hrair \
    --to=ferringb@gmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox