From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Mplah-0006dg-60 for garchives@archives.gentoo.org; Mon, 21 Sep 2009 16:18:15 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 43D01E094F; Mon, 21 Sep 2009 16:18:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id E6698E094F for ; Mon, 21 Sep 2009 16:18:13 +0000 (UTC) Received: from arcarius.localnet (smer.tone.cz [89.250.247.23]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 509D766F7B for ; Mon, 21 Sep 2009 16:18:13 +0000 (UTC) From: =?utf-8?q?Tom=C3=A1=C5=A1_Chv=C3=A1tal?= To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: perl-module.class review Date: Mon, 21 Sep 2009 18:10:56 +0200 User-Agent: KMail/1.12.1 (Linux/2.6.29-gentoo; KDE/4.3.1; x86_64; ; ) References: <20090920182031.GA2962@veller.net> <200909211739.01116.scarabeus@gentoo.org> <20090921174720.TA77b59.tv@veller.net> In-Reply-To: <20090921174720.TA77b59.tv@veller.net> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1442717.BH6219JtJW"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200909211810.59623.scarabeus@gentoo.org> X-Archives-Salt: c5650284-f0c1-4f00-a3a5-cd91447c0549 X-Archives-Hash: 9a3db0b85d3e28f9fb902639f0456ea7 --nextPart1442717.BH6219JtJW Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Dne pond=C4=9Bl=C3=AD 21 Z=C3=A1=C5=99=C3=AD 2009 18:03:56 Torsten Veller n= apsal(a): > * Tom=C3=A1=C5=A1 Chv=C3=A1tal : > > I think it is not required > > EXPF=3D"src_compile src_test src_install" <- definition, also nulls > > anything what was in it before :] > > case ${EAPI:-0} in > > 2) EXPF=3D"${EXPF} src_configure" ;; > > 1|0) ;; > > *) die "Unknown EAPI, Bug eclass maintainers." ;; > > esac > > EXPORT_FUNCTIONS ${EXPF} <- export >=20 > And later in cmake-utils_src_compile you use: > | has src_configure ${EXPF} || cmake-utils_src_configure >=20 > What will happen if an EAPI=3D2 ebuild inherits cmake-utils and another > eclass also using EXPF that does not EXPORT_FUNCTIONS src_configure and > the ebuild uses cmake-utils_src_compile? >=20 > It will call cmake-utils_src_configure during src_configure and later in > cmake-utils_src_compile it will run cmake-utils_src_configure again, > won't it? >=20 You dont do this magic before inherits, so you are safe, if you inherit in= =20 middle of your eclass code, then you probably deserve the breakage for=20 writting such horrible thing ;] A - inherit B EXPF - value from B A - define our own export_functions EXPF - value from A --nextPart1442717.BH6219JtJW Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (GNU/Linux) iEYEABECAAYFAkq3pZMACgkQHB6c3gNBRYdmcQCgww5k2V9aS+3MWq/f0FaspDHJ 4FUAoLCYsWHN81SoUYzn/SXRObdQTbSn =rcRF -----END PGP SIGNATURE----- --nextPart1442717.BH6219JtJW--