public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Tomáš Chvátal" <scarabeus@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: perl-module.class review
Date: Mon, 21 Sep 2009 17:38:53 +0200	[thread overview]
Message-ID: <200909211739.01116.scarabeus@gentoo.org> (raw)
In-Reply-To: <20090921170238.TA9e1bd.tv@veller.net>

[-- Attachment #1: Type: Text/Plain, Size: 1351 bytes --]

Dne pondělí 21 Září 2009 17:29:26 Torsten Veller napsal(a):
> * Ciaran McCreesh <ciaran.mccreesh@googlemail.com>:
> > Torsten Veller <tove@gentoo.org> wrote:
> > > +EXPORTED_FUNCTIONS="src_unpack src_compile src_test src_install"
> >
> > You're probably not the only one using this trick, so it might be wise
> > to use PERL_EXPORTED_FUNCTIONS or somesuch to avoid name collisions
> > with other eclasses.
> 
> git and x-modular use EXPORTED_FUNCTIONS and
> cmake and xfconf use EXPF.
> 
> | eclass/git.eclass:EXPORT_FUNCTIONS ${EXPORTED_FUNCTIONS}
> | eclass/x-modular.eclass:EXPORT_FUNCTIONS ${EXPORTED_FUNCTIONS}
> |
> | eclass/cmake-utils.eclass:EXPORT_FUNCTIONS ${EXPF}
> | eclass/xfconf.eclass:EXPORT_FUNCTIONS ${EXPF}
> 
> I'll use PERL_EXPORTED_FUNCTIONS in the perl eclass.
> 
> Thanks :)
> 
I think it is not required
EXPF="src_compile src_test src_install" <- definition, also nulls anything 
what was in it before :]
case ${EAPI:-0} in                     
        2) EXPF="${EXPF} src_configure" ;;
        1|0) ;;                           
        *) die "Unknown EAPI, Bug eclass maintainers." ;;
esac                                                     
EXPORT_FUNCTIONS ${EXPF}  <- export

i used expf cause it was shorter
and in git eclass i was too lazy for adjusting for the shorter name :]

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2009-09-21 15:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-20 18:20 [gentoo-dev] perl-5.10.1 status update Torsten Veller
2009-09-20 18:28 ` [gentoo-dev] perl-module.class review Torsten Veller
2009-09-21 14:40   ` Ciaran McCreesh
2009-09-21 15:29     ` [gentoo-dev] " Torsten Veller
2009-09-21 15:38       ` Tomáš Chvátal [this message]
2009-09-21 16:03         ` Torsten Veller
2009-09-21 16:10           ` Tomáš Chvátal
2009-09-21 16:55             ` Torsten Veller
2009-09-21 17:51               ` Jeremy Olexa
2009-09-21 16:30         ` Maciej Mrozowski
2009-09-21 16:59           ` Torsten Veller
2009-10-27 10:10 ` [gentoo-dev] Re: perl-5.10.1 status update Torsten Veller
2009-10-27 10:59   ` Kent Fredric
2009-10-27 11:07   ` Patrick Lauer
2009-10-27 11:50   ` David Abbott
2009-10-28  9:21   ` Bernard Cafarelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909211739.01116.scarabeus@gentoo.org \
    --to=scarabeus@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox