From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Mh2vh-00061q-D6 for garchives@archives.gentoo.org; Fri, 28 Aug 2009 14:59:53 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 03F3EE08D3; Fri, 28 Aug 2009 20:09:01 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id D864CE08D3 for ; Fri, 28 Aug 2009 20:09:00 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 61A7965A5B for ; Fri, 28 Aug 2009 20:09:02 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Proposal for flag-o-matic.eclass (append-ldflags) Date: Fri, 28 Aug 2009 16:08:59 -0400 User-Agent: KMail/1.12.0 (Linux/2.6.30.4; KDE/4.3.0; x86_64; ; ) References: <90b936c0812080833q1079ea5bsaf48a8b7b703ad64@mail.gmail.com> <90b936c0812141339r2cd242acr697164d59ff2088d@mail.gmail.com> In-Reply-To: <90b936c0812141339r2cd242acr697164d59ff2088d@mail.gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5573574.IX7Lzjk66M"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200908281608.59694.vapier@gentoo.org> X-Archives-Salt: 201ba677-2c4e-4b41-ba1e-611cabda397d X-Archives-Hash: 2930754b7e76ae982ac8030cbf448ed7 --nextPart5573574.IX7Lzjk66M Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Sunday 14 December 2008 16:39:17 Jeremy Olexa wrote: > On Mon, Dec 8, 2008 at 10:33 AM, Jeremy Olexa wrote: > > I am seeking a positive code review on the following change to > > flag-o-matic.eclass, diff is below (reasons are below that): > > Er, cancel that. The proposed patch isn't robust enough to catch > something like "append-ldflags -Wl,--bad-flag" sounds like we need a test-flag-LD() func that can go the extra mile > As such, we will leave > it local to Gentoo Prefix until we can come up with a better idea. stick it behind userland_GNU ? i dont mind extending append-ldflags in suc= h a=20 way, but the "pro" you listed originally (protect users from typos in ebuil= ds)=20 isnt a pro in my book -- it should fail. i.e. something like: append-ldflags() { use userland_GNU || set -- $(test-flag-LD "$@") ...... } =2Dmike --nextPart5573574.IX7Lzjk66M Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) iQIcBAABAgAGBQJKmDlbAAoJEEFjO5/oN/WBtRUP/1auxdPvXH8ykwZ6DaknLCHs QzCchxvNDc0y4L2m302Fb/gGsl/L1suHZ8ikUk0H0jOpikn0OCcz1sLcIl7xgtFP Lh/My0Q1Nv/HJkxfgpbQnxcfDGtDRt9cgWN1xdhDMNKl3fC4RHwUuQj+HLGniN3M 6IBQ4kN4TfWQkYqPwuaLGH5rmPoNzIG4/9+LtUQb7Vu/R5GHXov770k7wwJUPyhf cENRwu1szbyAvxR0AY/fy3GvNVqrguCc5Tu9Zyl9vcoEkNxJ6T96N1ZMIajqGE7O FIxeuECAJ/fPWIEQs+gNQ7NitGRSvPIorLVqVf7DYpGL4xw8eOxEdbaVwbaNH3ho 3q1ARCYnO1N8qdQDvNqCuHwv7g/9RQHlh//aBrkXd/StoM8aw1NswiXnUNxrxl6l lhbAaXm6h+HEQAaQaChQHCfs2DiHFVcNQp9JvPHa9m5EOKWd4nypSQ3VtQW4d/BU dbx4Dvaz2/ADQdTEG5A1+xk4GQBHn0IXZ4lf1ubflKmi1/ZDf1p8Cn/0YsQWKt+y wf6zc9906ipfGbiGbRjC9nSboqm97Ar90wUxdkqP1hoJuOnXxyfqc0Il2gdoYsLf Dv+/L3tpzn/FgH1rMXVB+pX2SZhlpoZaJTzQSMKw+XaiTiBFRTGX1tIr1H0x004g 2y7w89Y3TLP8TA5DaZiL =xo4H -----END PGP SIGNATURE----- --nextPart5573574.IX7Lzjk66M--