From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Mh2rn-0005WZ-T0 for garchives@archives.gentoo.org; Fri, 28 Aug 2009 14:55:52 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F15E4E08BA; Fri, 28 Aug 2009 20:04:58 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id D2D84E08BA for ; Fri, 28 Aug 2009 20:04:58 +0000 (UTC) Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 5F38B65EE9 for ; Fri, 28 Aug 2009 20:05:00 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Proposal for flag-o-matic.eclass (append-ldflags) Date: Fri, 28 Aug 2009 16:04:54 -0400 User-Agent: KMail/1.12.0 (Linux/2.6.30.4; KDE/4.3.0; x86_64; ; ) References: <90b936c0812080833q1079ea5bsaf48a8b7b703ad64@mail.gmail.com> <20081209191405.GC2455@comet> In-Reply-To: <20081209191405.GC2455@comet> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3228593.Fqa47vD9u4"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200908281604.55789.vapier@gentoo.org> X-Archives-Salt: a3ab6273-75e6-495f-9cd7-dc643d1e49e3 X-Archives-Hash: 0cccae855c0e8ed9d3892f83a5c4b46c --nextPart3228593.Fqa47vD9u4 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 09 December 2008 14:14:05 Donnie Berkholz wrote: > On 10:33 Mon 08 Dec , Jeremy Olexa wrote: > > Hello, > > I am seeking a positive code review on the following change to > > flag-o-matic.eclass, diff is below (reasons are below that): > > > > %% cvs diff > > Index: flag-o-matic.eclass > > RCS file: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v > > retrieving revision 1.126 > > diff -u -r1.126 flag-o-matic.eclass > > --- flag-o-matic.eclass 3 Nov 2008 05:52:39 -0000 1.126 > > +++ flag-o-matic.eclass 25 Nov 2008 18:36:04 -0000 > > @@ -417,7 +417,8 @@ > > > > x=3D"" > > for x in "$@" ; do > > - test-flag-${comp} "${x}" && flags=3D"${flags}${flags:+ > > }${x}" + test-flag-${comp} "${x}" && > > flags=3D"${flags}${flags:+ }${x}" || \ + ewarn > > "removing ${x} because ${comp} rejected it" done > > > > echo "${flags}" > > @@ -656,7 +657,7 @@ > > ewarn "Appending a library link instruction > > (${flag}); libraries to link to should not be passed through LDFLAGS" > > done > > > > - export LDFLAGS=3D"${LDFLAGS} $*" > > + export LDFLAGS=3D"${LDFLAGS} $(test-flags "$@")" > > return 0 > > } > > I like the consistency with other flags: > > comet $ grep FLAGS.*test-fl /usr/portage/eclass/flag-o-matic.eclass > export CFLAGS=3D$(test-flags-CC ${CFLAGS}) > export CXXFLAGS=3D$(test-flags-CXX ${CXXFLAGS}) > export FFLAGS=3D$(test-flags-F77 ${FFLAGS}) > export FCFLAGS=3D$(test-flags-FC ${FCFLAGS}) your grep ignores the bigger picture. this is only in the strip-unsupporte= d- flag function. so while we should flesh it out to include CPPFLAGS/LDFLAGS= ,=20 it doesnt really address the original question. =2Dmike --nextPart3228593.Fqa47vD9u4 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) iQIcBAABAgAGBQJKmDhnAAoJEEFjO5/oN/WBncQQAIa3FAXItio5tWhTV6nVIakg w/tzODi6YDxPsPqK4joHT49D9TpBfW9Q1onKSIj8WoM/IZsx+EJY2YyGl8buRTV9 noGXFJT7ezsxuyvZBQ++r51gxD/zsQKGNbKvE4VQ92/GgTT3oloAe+FlM0x12hJR o2pdFZtlU4PAdFqFq5Uno+FhFI30eJZyVvvNYLNHf/+MmtXlS8iUO2Uh7i24mEY2 BMx8+EobUGs7vIe53xQEhTrXuZPJH7pP6W8APXOZS23yTXF7WKKkKjADPs2XfZUD SvhucqhBiSaqPaLE8bWtGQxX4uH8yhAb9I3tgpcU+Mcj8eAwORIaTVKmlRCTr81L 6rZfMrjmfqmNyJvWMNpSE9EBPAYt2LycZ7Lxr+JIXPSdpWQe2QY2Jh8sY4WxBbj/ E0nZxFMYGwpSx7LtL1wb6A1S2tqt/ANfpLRWlZ9Bvl5vuy9wfttZRGNv5v0HE7cW r2HfPZyBH/8NYK6qaej6XTUXZg/9KcOb3laOBDnz0hMQkEYLyvyRF3NLwCLXhkQ9 Ip1RAPXv0LymTTS+LuWlO6gJMrMgOuPaKLZpMjXc6j0JuOgnR0BSoLiZkGar2Oaw 6KGKKQSkvmA2GThmDBFNhAXa8iiVyU4KI/c2VjKj/0ClcHJuo7RdqAIyooZIm/LV mf5rFVlYq0BO0tECdKSP =x4KL -----END PGP SIGNATURE----- --nextPart3228593.Fqa47vD9u4--