From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Mfhqc-0004JW-EF for garchives@archives.gentoo.org; Mon, 24 Aug 2009 22:17:06 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 590B0E027C; Mon, 24 Aug 2009 22:17:05 +0000 (UTC) Received: from mail-ew0-f218.google.com (mail-ew0-f218.google.com [209.85.219.218]) by pigeon.gentoo.org (Postfix) with ESMTP id 1CBF3E027C for ; Mon, 24 Aug 2009 22:17:05 +0000 (UTC) Received: by ewy18 with SMTP id 18so3164981ewy.14 for ; Mon, 24 Aug 2009 15:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=NofuXPve9HEqMaJZUNOQuKGJ5Yqb5V94j8YBWxhlTbw=; b=racLcuTh5yhOTCSper5Zbn5sLKnw22D0EMroTMaCzPwicREfKB8WyMa7Eqq3bAeM+k VxovOOZL3QjRJhYcipHVsxNE8wRnLC7QiSefq2kuNnSWPQNh+bty3IvE0v3TMan7jgOv FVduX3KCUU2UtX6MqJuVNkGG6AlOSdJiJnnHg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=Iq1bJdA3YzpTkuqFcFdfzUk0GL27jwjD98h7wzZDEyhv6ZLQom6Ts3Os55DIWun7XS 5gpAL6xHh4c09SY6SU38iT3Rerk3Ti94Td2NvfpcXuHdPS7IiFEhQj64ZCPVvk2nbaOU uE48rdGCDRzmQmU6e03sKgktSXhmJTIF98kP8= Received: by 10.211.200.7 with SMTP id c7mr5783079ebq.54.1251152224419; Mon, 24 Aug 2009 15:17:04 -0700 (PDT) Received: from snowmobile (92-235-187-79.cable.ubr18.sgyl.blueyonder.co.uk [92.235.187.79]) by mx.google.com with ESMTPS id 28sm322652eye.26.2009.08.24.15.17.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 24 Aug 2009 15:17:04 -0700 (PDT) Date: Mon, 24 Aug 2009 23:16:58 +0100 From: Ciaran McCreesh To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: EAPI 3 and "nonfatal die" Message-ID: <20090824231658.3224df06@snowmobile> In-Reply-To: <4A930FB0.5010309@gentoo.org> References: <200908212156.42396.levertond@googlemail.com> <20090821204619.2fd2bda5@gentoo.org> <4A930FB0.5010309@gentoo.org> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.16.5; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/e8g1HyDDi4no9Zf04k0OP61"; protocol="application/pgp-signature" X-Archives-Salt: 369c27db-9210-4506-b9de-52ff698a7431 X-Archives-Hash: 6239a8747c2393e43067fb8ccd03c6ba --Sig_/e8g1HyDDi4no9Zf04k0OP61 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 24 Aug 2009 15:09:52 -0700 Zac Medico wrote: > > I'd like die to respect nonfatal. People using nonfatal should > > check beforehand that the functions they're calling won't do > > anything stupid if die's are ignored. >=20 > If you're doing that then it might be wise to add an 'assert' helper > that is guaranteed to generate an exception regardless of 'nonfatal' > status. Probably not the best choice of name... 'assert' is already in use for checking PIPESTATUS. The other problem with doing things that way is that people have to start writing code that does an EAPI check just to be able to force a die. An IGNORE_NONFATAL environment variable, whilst slightly ickier, avoids that issue if we do change the definitions of die and nonfatal. *shrug* I still think the way it was originally worded is the best option. Otherwise we'll just replace the "some helpers die, some don't, and no-one knows which" situation with "some eclass functions are nonfatal aware, some aren't, and no-one knows which", with an added side helping of "people need to find out whether any of the callers in any overlay anywhere expect this function to work with nonfatal before changing it". --=20 Ciaran McCreesh --Sig_/e8g1HyDDi4no9Zf04k0OP61 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (GNU/Linux) iEYEARECAAYFAkqTEV0ACgkQ96zL6DUtXhFbBACdFXvoNlbQYGriwriCq4WHhT4r WG4AoIBsQeDjse/Vzxxd4PdLHvm4C3fx =NCC3 -----END PGP SIGNATURE----- --Sig_/e8g1HyDDi4no9Zf04k0OP61--