From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1M64qf-0002zx-7Z for garchives@archives.gentoo.org; Mon, 18 May 2009 15:33:53 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 838D3E02F2; Mon, 18 May 2009 15:33:51 +0000 (UTC) Received: from mail-fx0-f158.google.com (mail-fx0-f158.google.com [209.85.220.158]) by pigeon.gentoo.org (Postfix) with ESMTP id 24EA8E02F2 for ; Mon, 18 May 2009 15:33:50 +0000 (UTC) Received: by fxm2 with SMTP id 2so795500fxm.10 for ; Mon, 18 May 2009 08:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=Ga/N8oX3EvKQy8zr8U0kbW/YQvkHTCqBmn7DL4u+xsY=; b=RLfoEliWSZB9xBCMB7mLudEVKXl1kJMHQn6VbPxLalA2YifSgvVYgrydYCzpWICVpR IKoGG+CuoxfqMG6FSc2H5jgc0XCd8c3xLVySW7lBiY45GfzlJlA96kgBl0GBA8GY+nyX eK5SuRi5HsOLu2UOU+VUNuDrupnwr8kLOneNg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:from:to:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=vseOQwcUaBW9s/ZqyqN4YP8N+8TnZg71MX1UCXDNlzIIYKxOLHB26VP2nNT1fDM6vH LV94VUdqCCZtyRGkwOcKAmGG1F0W8dH6fclIDBc3CI9x+XnyPjRIT68EQgJZAhBOWdGX DZ1jQzImoe9G55TjPZFaKxmsXUd8LUJ4z7RK8= Received: by 10.103.224.2 with SMTP id b2mr2304119mur.39.1242660830151; Mon, 18 May 2009 08:33:50 -0700 (PDT) Received: from snowcone (92-235-187-79.cable.ubr18.sgyl.blueyonder.co.uk [92.235.187.79]) by mx.google.com with ESMTPS id u9sm28689muf.7.2009.05.18.08.33.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 May 2009 08:33:49 -0700 (PDT) Date: Mon, 18 May 2009 16:33:44 +0100 From: Ciaran McCreesh To: gentoo-dev@lists.gentoo.org Subject: Re: versionator.eclass terminator, was [gentoo-dev] Re: GLEP 55 updated Message-ID: <20090518163344.5b5aa8ee@snowcone> In-Reply-To: <20090518172800.7576c34a@epia.jer-c2.orkz.net> References: <7c612fc60905170920k22189731i2540514e24e60959@mail.gmail.com> <18960.18295.65849.57779@a1ihome1.kph.uni-mainz.de> <4A104BCE.7000001@gentoo.org> <4A107F05.7020001@gentoo.org> <20090517222016.3164b564@snowmobile> <4A1089E6.7070909@gentoo.org> <12688336.dTPDegVI1m@news.friendly-coders.info> <20090518161646.2c29b637@snowcone> <20090518172800.7576c34a@epia.jer-c2.orkz.net> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.14.7; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/ZzsH/KJLHCMn.AwLhkmS.IH"; protocol="application/pgp-signature" X-Archives-Salt: 22f452d6-9982-4c39-83a9-f7042444c454 X-Archives-Hash: 594d077bbef2998e840df0d5b8c89b83 --Sig_/ZzsH/KJLHCMn.AwLhkmS.IH Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 18 May 2009 17:28:00 +0200 Jeroen Roovers wrote: > On Mon, 18 May 2009 16:16:46 +0100 > Ciaran McCreesh wrote: > > Why do you think I wrote the awful hack that is versionator? >=20 > Why don't you explain why, historically, you put that in the tree? It > would help us now if you were to simply record your mistakes for > everybody else to easily avoid. It's still being used in the tree and > should be discouraged. Versionator was created because the alternative was worse: developers were hard-coding versions in ebuilds, writing dodgy bash substitutions that wouldn't reliably convert between versions and using things like sed and tr in global scope. The problem is, versionator was written before the current version rules. It doesn't handle some things that are now legal, and it still uses the old meanings for numeric components. The correct solution is two-fold: * Replace versionator with package-manager internal functions that use the package manager's rules for version parsing. * Reduce the need to use MY_PV by extending the version rules. Both of these are things that can't be done with current EAPI rules. > > Anything that finally lets us kill that off has to be good... >=20 > Loosening VERSION requirements won't fix the problem. This will: >=20 > 1) Discourage its use by putting a QA ewarn in the eclass. > 2) Have all ebuilds converted either through QA bugs or a nice > Saturday afternoon coding spree. > 3) Announce its removal. > 4) Remove. You can't discourage versionator until the replacement's in place. Going back to the old way of doing things is a loooooot worse than using versionator. So no, the way to fix it is: 1) Change the EAPI rules to allow global scope and version suffix changes. 2) Bring in a versionator replacement done as internals in a new EAPI. 3) Extend the version format rules in a new EAPI. 4) Disallow versionator use in the first EAPI that has 2) and 3). --=20 Ciaran McCreesh --Sig_/ZzsH/KJLHCMn.AwLhkmS.IH Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkoRf9oACgkQ96zL6DUtXhF4jgCgufj49yprzEkIPCab92pUiYx5 kewAn1gh3UyE0lxqWqq1zpBhwpLer941 =wpe0 -----END PGP SIGNATURE----- --Sig_/ZzsH/KJLHCMn.AwLhkmS.IH--